Differential D804

Remove deps from setup.py
ClosedPublic
Actions

Authored by mkrizek on Apr 6 2016, 1:23 PM.

Details

Reviewers
tflink
Maniphest Tasks
T768: Fix requirements.txt in taskotron-trigger to work with rpm deployments
Commits
rTRGR6ae15b0d2f47: Remove deps from setup.py
Summary

They are taken care of within spec file in production or in
requirements.txt in devel. For some reason (that I don't think is worth
hunting down), these cause problems when the trigger was installed from
rpm, it failed with 'daemon' not being found (when I removed it from
jobtriggers.egg-info/requires.txt, the error disappeared).

Test Plan

See 'Summary'

Diff Detail

Repository
rTRGR taskotron-trigger
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkrizek retitled this revision from to Remove deps from setup.py.Apr 6 2016, 1:23 PM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added a reviewer: tflink.
tflink accepted this revision.Apr 6 2016, 1:39 PM
This revision is now accepted and ready to land.Apr 6 2016, 1:39 PM
Closed by commit rTRGR6ae15b0d2f47: Remove deps from setup.py (authored by mkrizek). · Explain WhyApr 7 2016, 8:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Msetup.py (3 lines)

Diff 2056

View Options

setup.py

Show All 28 Lines26 'moksha.consumer': (
29 'composecompletedjobtrigger = jobtriggers.compose_complete_msg:ComposeCompletedJobTrigger', 29​ 'composecompletedjobtrigger = jobtriggers.compose_complete_msg:ComposeCompletedJobTrigger',
30 ), 30​ ),
31 }, 31​ },
32 include_package_data=True, 32​ include_package_data=True,
33 install_requires=[ 33​ install_requires=[
34 'moksha.hub', 34​ 'moksha.hub',
35 'fedmsg', 35​ 'fedmsg',
36 'requests', 36​ 'requests',
37 'daemon', ​
38 'psutil', ​
39 'Pygments' ​
40 ], 37​ ],
41 cmdclass={'test': PyTest} 38​ cmdclass={'test': PyTest}
42) 39​)