Differential D79

Patching bodhi_utils so that bodhi client is created using config values. Fixes T152
ClosedPublic
Actions

Authored by tflink on Apr 30 2014, 3:27 PM.

Tags

None

Subscribers

None

Details

Reviewers

kparal
jskladan

Maniphest Tasks

T152: bodhi_utils does not create a bodhi client using config values

Commits

rLTRN614095dd816a: Patching bodhi_utils so that bodhi client is created using config values. Fixes

Summary

simple fix to allow use of non-production bodhi servers with libtaskotron

Test Plan

unit tests pass, testing in local env

Diff Detail

Lint

Lint Skipped

Unit

Unit Tests Skipped

Looks good!

Closed by commit rLTRN614095dd816a (authored by @tflink).

Revision Contents

			Path
M			libtaskotron/bodhi_utils.py (16 lines)

Diff 222

libtaskotron/bodhi_utils.py

1	# -- coding: utf-8 --	1		# -- coding: utf-8 --
2	# Copyright 2010-2014, Red Hat, Inc.	2		# Copyright 2010-2014, Red Hat, Inc.
3	# License: GNU General Public License version 2 or later	3		# License: GNU General Public License version 2 or later
4		4
5	'''Utility functions for dealing with Bodhi'''	5		'''Utility functions for dealing with Bodhi'''
6		6
7	import fedora.client	7		import fedora.client
8		8
9	from .logger import log	9		from .logger import log
10	from . import rpm_utils	10		from . import rpm_utils
11	from . import python_utils	11		from . import python_utils
12	from . import exceptions as exc	12		from . import exceptions as exc
13		13		from . import config
14		14
15	class BodhiUtils(object):	15		class BodhiUtils(object):
16	'''Helper Bodhi methods.	16		'''Helper Bodhi methods.
17		17
18	Note: You can access the standard BodhiClient as self.client.	18		Note: You can access the standard BodhiClient as self.client.
19	'''	19		'''
20		20
21	def __init__(self, client=None):	21		def __init__(self, client=None):
22	'''Create a new BodhiUtils instance.	22		'''Create a new BodhiUtils instance.
23	@param client custom BodhiClient instance. If None, a default	23		@param client custom BodhiClient instance. If None, a default
24	BodhiClient instance is used.	24		BodhiClient instance is used.
25	'''	25		'''
26	self.client = client or fedora.client.bodhi.BodhiClient()	26
		27		taskotron_config = config.get_config()
		28		username = taskotron_config.fas_username
		29		password = taskotron_config.fas_password
		30		bodhi_url = taskotron_config.bodhi_server
		31
		32		if not client:
		33		log.debug('creating bodhi client to %s' % bodhi_url)
		34		self.client = fedora.client.bodhi.BodhiClient(username=username,
		35		password=password,
		36		base_url=bodhi_url)
		37		else:
		38		self.client = client
27		39
28		40
29	def query_update(self, package):	41		def query_update(self, package):
30	'''Get the last Bodhi update matching criteria.	42		'''Get the last Bodhi update matching criteria.
31		43
32	@param package package NVR or package name or update title or	44		@param package package NVR or package name or update title or
33	update ID	45		update ID
34	Note: Only NVR allowed, not NEVR. See	46		Note: Only NVR allowed, not NEVR. See
▲ Show 20 Lines • Show All 94 Lines • Show Last 20 Lines