Differential D787

shutdown before uploading disk images
ClosedPublic
Actions

Authored by adamwill on Mar 21 2016, 8:12 PM.

Details

Reviewers
garretraziel
jskladan
Commits
rOPENQATESTSbf8c82710732: shutdown before uploading disk images
Summary

I believe the failures in the Server DVD chained Base tests are
happening because the VM is not cleanly shut down before the disk
image is uploaded. This adds a shutdown step to all tests that
upload a disk image (so, for now, just default_install). To keep
things simple it just runs 'shutdown' from a root console, rather
than using graphical desktop shutdown methods, as the aim is only
to make the disk state clean, not to test shutdown exactly.

I've tested this on staging; a Server DVD test run with this
change produced a full set of passed tests, as opposed to all
the Base tests failing because the system didn't boot properly.
Workstation and KDE tests seem to work fine also.

For the record, SUSE does much the same thing as this commit.

Test Plan

Do a full test run and make sure everything that worked
before still does. Check that all default_install tests have a
_console_shutdown step added, and it works, and all chained tests
work (or fail for some unrelated reason, but make sure this
doesn't break them).

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to shutdown before uploading disk images.Mar 21 2016, 8:12 PM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
garretraziel accepted this revision.Mar 22 2016, 9:34 AM

Tested it and works without problem.

This revision is now accepted and ready to land.Mar 22 2016, 9:34 AM
Closed by commit rOPENQATESTSbf8c82710732: shutdown before uploading disk images (authored by adamwill). · Explain WhyMar 22 2016, 2:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mmain.pm (4 lines)
AMtests/_console_shutdown.pm (32 lines)

Diff 2015

View Options

main.pm

Show First 20 Lines • Show All 186 Lines • ▼ Show 20 Line(s)186 if (get_var('PARTITIONING')) {
187 my $loc = "tests/disk_".get_var('PARTITIONING')."_postinstall.pm"; 187​ my $loc = "tests/disk_".get_var('PARTITIONING')."_postinstall.pm";
188 $storagepost = $loc if (-e $loc); 188​ $storagepost = $loc if (-e $loc);
189 } 189​ }
190 autotest::loadtest $storagepost if ($storagepost); 190​ autotest::loadtest $storagepost if ($storagepost);
191 191​
192 if (get_var("UEFI")) { 192​ if (get_var("UEFI")) {
193 autotest::loadtest "tests/uefi_postinstall.pm"; 193​ autotest::loadtest "tests/uefi_postinstall.pm";
194 } 194​ }
195​ # we should shut down before uploading disk images
196​ if (get_var("STORE_HDD_1") || get_var("PUBLISH_HDD_1")) {
197​ autotest::loadtest "tests/_console_shutdown.pm";
198​ }
195} 199​}
196 200​
197 201​
198 202​
1991; 203​1;
200 204​
201# vim: set sw=4 et: 205​# vim: set sw=4 et:
View Options

tests/_console_shutdown.pm

  • This file was added.
1​use base "installedtest";
2​use strict;
3​use testapi;
4​
5​sub run {
6​ my $self = shift;
7​ # this shutdown code is only to make sure the guest disk is clean
8​ # before uploading an image of it, we're really not "testing"
9​ # shutdown here. So to keep things simple and reliable, we do not
10​ # use the desktops' graphical shutdown methods, we just go to a
11​ # console and run 'poweroff'. We can write separate tests for
12​ # properly testing shutdown/reboot/log out from desktops.
13​ $self->root_console(tty=>3, check=>0);
14​ script_run("poweroff", 0);
15​ assert_shutdown;
16​}
17​
18​# this is not 'fatal' or 'important' as all wiki test cases are passed
19​# even if shutdown fails. we should have a separate test for shutdown/
20​# logout/reboot stuff, might need some refactoring.
21​sub test_flags {
22​ # without anything - rollback to 'lastgood' snapshot if failed
23​ # 'norollback' - don't rollback if failed
24​ # 'fatal' - whole test suite is in danger if this fails
25​ # 'milestone' - after this test succeeds, update 'lastgood'
26​ # 'important' - if this fails, set the overall state to 'fail'
27​ return {'norollback' => 1};
28​}
29​
30​1;
31​
32​# vim: set sw=4 et: