| mkrizek |
We forgot to mock os.mkdir which created empty dir "dirname" in cwd when
running the test suite.
test suite works and dirname is not created
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | testing/test_remote_exec.py (8 lines) |
| Commit | Tree | Parents | Author | Summary | Date |
|---|---|---|---|---|---|
| 45d45181f5a3 | 46da955cd988 | 06ead2c40e21 | Kamil Páral | test_remote_exec: don't create dirs in cwd (Show More…) | Mar 15 2016, 10:48 AM |
| 1 | # -*- coding: utf-8 -*- | 1 | # -*- coding: utf-8 -*- | ||
|---|---|---|---|---|---|
| 2 | # Copyright 2009-2015, Red Hat, Inc. | 2 | # Copyright 2009-2015, Red Hat, Inc. | ||
| 3 | # License: GPL-2.0+ <http://spdx.org/licenses/GPL-2.0+> | 3 | # License: GPL-2.0+ <http://spdx.org/licenses/GPL-2.0+> | ||
| 4 | # See the LICENSE file for more details on Licensing | 4 | # See the LICENSE file for more details on Licensing | ||
| 5 | 5 | | |||
| 6 | '''Unit tests for libtaskotron/remote_exec.py''' | 6 | '''Unit tests for libtaskotron/remote_exec.py''' | ||
| 7 | 7 | | |||
| 8 | import errno | 8 | import errno | ||
| 9 | import socket | 9 | import socket | ||
| 10 | import os | ||||
| 10 | 11 | | |||
| 11 | import pytest | 12 | import pytest | ||
| 12 | import paramiko | 13 | import paramiko | ||
| 13 | from munch import Munch | 14 | from munch import Munch | ||
| 14 | import mock | 15 | import mock | ||
| 15 | 16 | | |||
| 16 | from libtaskotron import remote_exec | 17 | from libtaskotron import remote_exec | ||
| 17 | from libtaskotron.exceptions import TaskotronRemoteError, TaskotronRemoteProcessError | 18 | from libtaskotron.exceptions import TaskotronRemoteError, TaskotronRemoteProcessError | ||
| ▲ Show 20 Lines • Show All 118 Lines • ▼ Show 20 Line(s) | 133 | def open_sftp(self, *args, **kwargs): | |||
| 136 | return self._sftp | 137 | return self._sftp | ||
| 137 | 138 | | |||
| 138 | def exec_command(self, cmd, **kwargs): | 139 | def exec_command(self, cmd, **kwargs): | ||
| 139 | ch = Munch(channel=StubChannel(cmd), read=lambda: '') | 140 | ch = Munch(channel=StubChannel(cmd), read=lambda: '') | ||
| 140 | 141 | | |||
| 141 | return ch, ch, ch | 142 | return ch, ch, ch | ||
| 142 | 143 | | |||
| 143 | 144 | | |||
| 145 | @pytest.mark.usefixtures('setup') | ||||
| 144 | class TestRemoteExec(object): | 146 | class TestRemoteExec(object): | ||
| 145 | def setup_method(self, method): | 147 | | ||
| 148 | @pytest.fixture | ||||
| 149 | def setup(self, monkeypatch): | ||||
| 146 | '''Run this before every test invocation''' | 150 | '''Run this before every test invocation''' | ||
| 147 | self.ref_host_ip = '192.168.122.22' | 151 | self.ref_host_ip = '192.168.122.22' | ||
| 148 | paramiko.SSHClient = StubSSHClient | 152 | paramiko.SSHClient = StubSSHClient | ||
| 149 | self.remote = remote_exec.ParamikoWrapper(self.ref_host_ip, 22, 'root', 'keyfilename') | 153 | self.remote = remote_exec.ParamikoWrapper(self.ref_host_ip, 22, 'root', 'keyfilename') | ||
| 150 | self.remote.connect() | 154 | self.remote.connect() | ||
| 155 | mock_mkdir = mock.Mock() | ||||
| 156 | monkeypatch.setattr(os, 'mkdir', mock_mkdir) | ||||
| 151 | 157 | | |||
| 152 | def teardown_method(self, method): | 158 | def teardown_method(self, method): | ||
| 153 | self.remote.close() | 159 | self.remote.close() | ||
| 154 | 160 | | |||
| 155 | def test_remote_isdir(self): | 161 | def test_remote_isdir(self): | ||
| 156 | assert self.remote._remote_isdir(STUB_DIR) is True | 162 | assert self.remote._remote_isdir(STUB_DIR) is True | ||
| 157 | 163 | | |||
| 158 | def test_remote_isdir_not(self): | 164 | def test_remote_isdir_not(self): | ||
| ▲ Show 20 Lines • Show All 104 Lines • Show Last 20 Lines | |||||