This is a proof of concept created based on the T731 discussion
Details
- Reviewers
kparal tflink - Group Reviewers
libtaskotron - Maniphest Tasks
- T731: Support image type specification in libtaskotron formulas
- Commits
- rLTRN0a5d43327c3e: Image type specification for disposable minions in libtaskotron formulae
Tested locally
Diff Detail
- Repository
- rLTRN libtaskotron
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
It looks good to me as a PoC. I'd like to see more test coverage, though.
libtaskotron/taskformula.py | ||
---|---|---|
14 | I'm not sure I see a better way to do this right now but it'd be nice to start removing the fedora-isms from core at some point |
libtaskotron/taskformula.py | ||
---|---|---|
127–129 | I'm writing tests, and it just occured to me, that this is not what we want, if the default behaviour is to be "infer from item/type/arch". Will remove/move to the right place in future iteration of the diff. |
I'm not sure I see a better way to do this right now but it'd be nice to start removing the fedora-isms from core at some point