Base-image selection proof of concept
ClosedPublic

Authored by jskladan on Mar 14 2016, 5:00 PM.

Details

Summary

This is a proof of concept created based on the T731 discussion

Test Plan

Tested locally

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jskladan retitled this revision from to Base-image selection proof of concept.Mar 14 2016, 5:00 PM
jskladan updated this object.
jskladan edited the test plan for this revision. (Show Details)
jskladan added a reviewer: libtaskotron.

It looks good to me as a PoC. I'd like to see more test coverage, though.

libtaskotron/taskformula.py
14

I'm not sure I see a better way to do this right now but it'd be nice to start removing the fedora-isms from core at some point

jskladan updated this revision to Diff 2019.Mar 22 2016, 3:50 PM
  • Changed according to discussion
jskladan added inline comments.Mar 22 2016, 7:07 PM
libtaskotron/taskformula.py
127–129

I'm writing tests, and it just occured to me, that this is not what we want, if the default behaviour is to be "infer from item/type/arch". Will remove/move to the right place in future iteration of the diff.

jskladan updated this revision to Diff 2020.Mar 22 2016, 7:34 PM
  • Changed according to discussion
  • pep8
  • Added tests
tflink accepted this revision.Mar 23 2016, 8:49 PM
tflink added a reviewer: tflink.

LGTM, works as expected when testing locally

This revision is now accepted and ready to land.Mar 23 2016, 8:49 PM
kparal accepted this revision.Mar 31 2016, 7:52 AM
kparal added a reviewer: kparal.
kparal added inline comments.
libtaskotron/taskformula.py
128

I'd probably use TaskotronValueError for this.

147

This will not work for xchat-2.8.8-21.fc20.1 which is valid. Lets use rpm_utils.get_dist_tag() and maintain the code at one place.

A similar thing can probably be done for distro.

jskladan updated this revision to Diff 2051.Apr 4 2016, 9:10 AM
  • Changed according to discussion
  • pep8
  • Added tests
  • pep8
  • Changed according to review
This revision was automatically updated to reflect the committed changes.