Differential D777

minion: improve logging when execution fails
ClosedPublic
Actions

Authored by kparal on Mar 14 2016, 12:34 PM.

Details

Reviewers
mkrizek
Commits
rLTRN06ead2c40e21: minion: improve logging when execution fails
Summary

tiny logging change, but improves readability when something went wrong. It's clearer that the minion image is getting shut down prematurely and the error occurred before that, not after that.

Before:

[libtaskotron] 16:41:33 INFO    Running task on a disposable client using libvirt...
[libtaskotron] 16:41:33 INFO    Creating VM for task
[libtaskotron] 16:41:33 INFO    Shutting down the minion...
[libtaskotron] 16:41:33 ERROR   Was expecting to find instance taskotron-20160311_164132_907710 but it does not already exist

After:

[libtaskotron] 11:39:02 INFO    Running task on a disposable client using libvirt...
[libtaskotron] 11:39:02 INFO    Creating VM for task
[libtaskotron] 11:39:02 WARNING Task execution was interrupted by an error, doing emergency cleanup.
[libtaskotron] 11:39:02 INFO    Shutting down the minion...
[libtaskotron] 11:39:02 ERROR   Was expecting to find instance taskotron-20160314_113902_585744 but it does not already exist
Test Plan

ran test suite, tried manually with a bug

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to minion: improve logging when execution fails.Mar 14 2016, 12:34 PM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added a reviewer: mkrizek.
mkrizek accepted this revision.Mar 14 2016, 12:58 PM
This revision is now accepted and ready to land.Mar 14 2016, 12:58 PM
Closed by commit rLTRN06ead2c40e21: minion: improve logging when execution fails (authored by kparal). · Explain WhyMar 14 2016, 1:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mlibtaskotron/minion.py (3 lines)

Diff 1987

View Options

libtaskotron/minion.py

Show First 20 Lines • Show All 194 Lines • ▼ Show 20 Line(s)181 try:
195 195​
196 with remote_exec.ParamikoWrapper(self.machine, self.port, self.user, 196​ with remote_exec.ParamikoWrapper(self.machine, self.port, self.user,
197 self.ssh_privkey, stdio_filename) as self.ssh: 197​ self.ssh_privkey, stdio_filename) as self.ssh:
198 self._prepare_task() 198​ self._prepare_task()
199 self._run() 199​ self._run()
200 self._get_output() 200​ self._get_output()
201 execution_ok = True 201​ execution_ok = True
202 finally: 202​ finally:
203​ if not execution_ok:
204​ log.warn('Task execution was interrupted by an error, doing emergency cleanup.')
205​
203 if self.arg_data['no_destroy']: 206​ if self.arg_data['no_destroy']:
204 log.info('--no-destroy mode was set from command line, not tearing VM ' 207​ log.info('--no-destroy mode was set from command line, not tearing VM '
205 'down for task %s: %s@%s:%s', self.arg_data['uuid'], self.user, 208​ 'down for task %s: %s@%s:%s', self.arg_data['uuid'], self.user,
206 self.machine, self.port) 209​ self.machine, self.port)
207 else: 210​ else:
208 try: 211​ try:
209 log.info('Shutting down the minion...') 212​ log.info('Shutting down the minion...')
210 task_vm.teardown() 213​ task_vm.teardown()
Show All 11 Lines