| tflink | |
| mkrizek |
Added CRASHED result and the Alembic migration that
covers its addition
Tested with local postgres instance
| No Linters Available |
| No Unit Test Coverage |
| Buildable 478 | |
| Build 478: arc lint + arc unit |
| Path | Packages | |||
|---|---|---|---|---|
| M | .gitignore (1 line) | |||
| A | M | alembic/versions/2ffd1e7256d0_added_crashed_result.py (52 lines) | ||
| M | resultsdb/models/results.py (2 lines) |
| Commit | Tree | Parents | Author | Summary | Date |
|---|---|---|---|---|---|
| 1bcc69c6172a | 4656fcb12bc9 | ea3e26a81d3c | Josef Skladanka | . | Mar 9 2016, 8:44 AM |
| ea3e26a81d3c | b55bbc0dcda9 | edfb371d310e | Josef Skladanka | Added alembic migration script | Mar 9 2016, 8:43 AM |
| edfb371d310e | e610eebccd3b | abfb3e3de5b6 | Josef Skladanka | Added .cache to gitignore | Mar 9 2016, 8:33 AM |
| abfb3e3de5b6 | cf69d9d02686 | 648e9bcdc131 | Josef Skladanka | Added CRASHED as possible result value | Mar 9 2016, 8:27 AM |
| 1 | *.pyc | 1 | *.pyc | ||
|---|---|---|---|---|---|
| 2 | *.pyo | 2 | *.pyo | ||
| 3 | *.swp | 3 | *.swp | ||
| 4 | *__pycache__* | 4 | *__pycache__* | ||
| 5 | .ropeproject/ | 5 | .ropeproject/ | ||
| 6 | conf/settings.py | 6 | conf/settings.py | ||
| 7 | *.sqlite | 7 | *.sqlite | ||
| 8 | *.sass-cache | 8 | *.sass-cache | ||
| 9 | *build/ | 9 | *build/ | ||
| 10 | *dist/ | 10 | *dist/ | ||
| 11 | *.egg* | 11 | *.egg* | ||
| 12 | /env*/ | 12 | /env*/ | ||
| 13 | .coverage | 13 | .coverage | ||
| 14 | .cache | ||||
| 14 | htmlcov/ | 15 | htmlcov/ | ||
| 1 | """Added CRASHED result | ||||
|---|---|---|---|---|---|
| 2 | | ||||
| 3 | Revision ID: 2ffd1e7256d0 | ||||
| 4 | Revises: 978007ecd2b | ||||
| 5 | Create Date: 2016-03-09 09:36:07.460088 | ||||
| 6 | | ||||
| 7 | """ | ||||
| 8 | | ||||
| 9 | # revision identifiers, used by Alembic. | ||||
| 10 | revision = '2ffd1e7256d0' | ||||
| 11 | down_revision = '978007ecd2b' | ||||
| 12 | branch_labels = None | ||||
| 13 | depends_on = None | ||||
| 14 | | ||||
| 15 | from alembic import op | ||||
| 16 | import sqlalchemy as sa | ||||
| 17 | | ||||
| 18 | old_values = ('PASSED', 'INFO', 'FAILED', 'ERROR', 'WAIVED', 'NEEDS_INSPECTION', 'ABORTED') | ||||
| 19 | new_values = ('PASSED', 'INFO', 'FAILED', 'ERROR', 'WAIVED', 'NEEDS_INSPECTION', 'ABORTED', 'CRASHED') | ||||
| 20 | | ||||
| 21 | old_enum = sa.Enum(*old_values, name='resultoutcome') | ||||
| 22 | tmp_enum = sa.Enum(*new_values, name='resultoutcome_tmp') | ||||
| 23 | new_enum = sa.Enum(*new_values, name='resultoutcome') | ||||
| 24 | | ||||
| 25 | | ||||
| 26 | def upgrade(): | ||||
| 27 | # this migration is postgresql specific and fails on sqlite | ||||
| 28 | if op.get_bind().engine.url.drivername.startswith("postgresql"): | ||||
| 29 | tmp_enum.create(op.get_bind(), checkfirst=False) | ||||
| 30 | op.execute('ALTER TABLE result ALTER COLUMN outcome TYPE resultoutcome_tmp ' | ||||
| 31 | ' USING outcome::text::resultoutcome_tmp') | ||||
| 32 | old_enum.drop(op.get_bind(), checkfirst=False) | ||||
| 33 | new_enum.create(op.get_bind(), checkfirst=False) | ||||
| 34 | op.execute('ALTER TABLE result ALTER COLUMN outcome TYPE resultoutcome ' | ||||
| 35 | ' USING outcome::text::resultoutcome') | ||||
| 36 | tmp_enum.drop(op.get_bind(), checkfirst=False) | ||||
| 37 | | ||||
| 38 | | ||||
| 39 | def downgrade(): | ||||
| 40 | # this migration is postgresql specific and fails on sqlite | ||||
| 41 | if op.get_bind().engine.url.drivername.startswith("postgresql"): | ||||
| 42 | op.execute("UPDATE result SET outcome='ERROR' WHERE outcome='CRASHED'") | ||||
| 43 | | ||||
| 44 | tmp_enum.create(op.get_bind(), checkfirst=False) | ||||
| 45 | op.execute('ALTER TABLE result ALTER COLUMN outcome TYPE resultoutcome_tmp ' | ||||
| 46 | ' USING outcome::text::resultoutcome_tmp') | ||||
| 47 | new_enum.drop(op.get_bind(), checkfirst=False) | ||||
| 48 | old_enum.create(op.get_bind(), checkfirst=False) | ||||
| 49 | op.execute('ALTER TABLE result ALTER COLUMN outcome TYPE resultoutcome ' | ||||
| 50 | ' USING outcome::text::resultoutcome') | ||||
| 51 | tmp_enum.drop(op.get_bind(), checkfirst=False) | ||||
| 52 | | ||||
| Show All 22 Lines | |||||
| 23 | from resultsdb.serializers import DBSerialize | 23 | from resultsdb.serializers import DBSerialize | ||
| 24 | 24 | | |||
| 25 | 25 | | |||
| 26 | __all__ = ['Testcase', 'Job', 'Result', 'ResultData', 'JOB_STATUS', 'RESULT_OUTCOME'] | 26 | __all__ = ['Testcase', 'Job', 'Result', 'ResultData', 'JOB_STATUS', 'RESULT_OUTCOME'] | ||
| 27 | 27 | | |||
| 28 | 28 | | |||
| 29 | 29 | | |||
| 30 | JOB_STATUS = ('SCHEDULED', 'RUNNING', 'COMPLETED', 'ABORTED', 'CRASHED', 'NEEDS_INSPECTION') | 30 | JOB_STATUS = ('SCHEDULED', 'RUNNING', 'COMPLETED', 'ABORTED', 'CRASHED', 'NEEDS_INSPECTION') | ||
| 31 | RESULT_OUTCOME = ('PASSED', 'INFO', 'FAILED', 'ERROR', 'WAIVED', 'NEEDS_INSPECTION', 'ABORTED') | 31 | RESULT_OUTCOME = ('PASSED', 'INFO', 'FAILED', 'ERROR', 'WAIVED', 'NEEDS_INSPECTION', 'ABORTED', 'CRASHED') | ||
| 32 | 32 | | |||
| 33 | 33 | | |||
| 34 | # !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | 34 | # !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| 35 | # | 35 | # | ||
| 36 | # DO NOT FORGET TO UPDATE SERIALIZERS AFTER CHANGING STRUCTURE | 36 | # DO NOT FORGET TO UPDATE SERIALIZERS AFTER CHANGING STRUCTURE | ||
| 37 | # | 37 | # | ||
| 38 | # !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | 38 | # !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| 39 | 39 | | |||
| ▲ Show 20 Lines • Show All 83 Lines • Show Last 20 Lines | |||||