Differential D768

anaconda crash reporting: update needles, click Report again
ClosedPublic
Actions

Authored by adamwill on Mar 7 2016, 10:38 PM.

Details

Reviewers
garretraziel
jskladan
Commits
rOPENQATESTS0305c5fcd060: anaconda crash reporting: update needles, click Report again
Summary

First off, this revises the anaconda crash handling needles a
bit. We ditch gtk3195 and update anaconda_error to reflect
current F24/Rawhide. We keep the old anaconda_error around for
now as anaconda_error-23, to handle crashes in the F23 two-week
Atomic nightlies. We also add an 'early' variant, which is for
when (I think) the installer crashes very early, before it's
loaded in GTK+ settings; when that happens, the dialog uses a
different font. The screenshot comes from a recent Rawhide test
that crashed.

We also restore the anaconda post_fail_hook code to click
the Report button when a crash happens. This was erroneously
removed in D637. Before the Report button is clicked, the
anaconda-tb file exists but the libreport stuff in /var/tmp
does not. By removing this, we lost the libreport bits from
the uploaded files, which makes it harder to report crashes. So
let's add it back.

Finally we fix the actual tarring and uploading of /var/tmp;
also in D637 this got broken because it was being tarred up in
whatever directory the commands happened to be running in, but
we were still trying to upload it from /var/tmp.

https://openqa.stg.fedoraproject.org/tests/8444 was run with
these changes, and has /var/tmp correctly uploaded.

Test Plan

Run some test that crashes, make sure the crash
handling all works correctly.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to anaconda crash reporting: update needles, click Report again.Mar 7 2016, 10:38 PM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
garretraziel accepted this revision.Mar 8 2016, 9:49 AM

Yeah, not clicking on "Report" button was my fault - I thought that all necessary things get created without need for clicking on "Report" button.

This revision is now accepted and ready to land.Mar 8 2016, 9:49 AM
Closed by commit rOPENQATESTS0305c5fcd060: anaconda crash reporting: update needles, click Report again (authored by adamwill). · Explain WhyMar 8 2016, 4:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 1970

View Options

lib/anacondatest.pm

1package anacondatest; 1​package anacondatest;
2use base 'fedorabase'; 2​use base 'fedorabase';
3 3​
4# base class for all Anaconda (installation) tests 4​# base class for all Anaconda (installation) tests
5 5​
6# should be used in tests where Anaconda is running - when it makes sense 6​# should be used in tests where Anaconda is running - when it makes sense
7# to upload Anaconda logs when something fails 7​# to upload Anaconda logs when something fails
8 8​
9use testapi; 9​use testapi;
10 10​
11sub post_fail_hook { 11​sub post_fail_hook {
12 my $self = shift; 12​ my $self = shift;
13 13​
14 # if error dialog is shown, it created traceback file 14​ # if error dialog is shown, click "report" - it then creates directory structure for ABRT
15 my $has_traceback = 0; 15​ my $has_traceback = 0;
16 if (check_screen "anaconda_error", 10) { 16​ if (check_screen "anaconda_error", 10) {
17​ assert_and_click "anaconda_error_report";
17 $has_traceback = 1; 18​ $has_traceback = 1;
18 } 19​ }
19 20​
20 $self->root_console(check=>0); 21​ $self->root_console(check=>0);
21 if (check_screen "root_console", 10) { 22​ if (check_screen "root_console", 10) {
22 upload_logs "/tmp/X.log"; 23​ upload_logs "/tmp/X.log";
23 upload_logs "/tmp/anaconda.log"; 24​ upload_logs "/tmp/anaconda.log";
24 upload_logs "/tmp/packaging.log"; 25​ upload_logs "/tmp/packaging.log";
25 upload_logs "/tmp/storage.log"; 26​ upload_logs "/tmp/storage.log";
26 upload_logs "/tmp/syslog"; 27​ upload_logs "/tmp/syslog";
27 upload_logs "/tmp/program.log"; 28​ upload_logs "/tmp/program.log";
28 upload_logs "/tmp/dnf.log"; 29​ upload_logs "/tmp/dnf.log";
29 upload_logs "/tmp/dnf.librepo.log"; 30​ upload_logs "/tmp/dnf.librepo.log";
30 upload_logs "/tmp/dnf.rpm.log"; 31​ upload_logs "/tmp/dnf.rpm.log";
31 32​
32 if ($has_traceback) { 33​ if ($has_traceback) {
33 # Upload Anaconda traceback logs 34​ # Upload Anaconda traceback logs
34 script_run "tar czf /tmp/anaconda_tb.tar.gz /tmp/anaconda-tb-*"; 35​ script_run "tar czf /tmp/anaconda_tb.tar.gz /tmp/anaconda-tb-*";
35 upload_logs "/tmp/anaconda_tb.tar.gz"; 36​ upload_logs "/tmp/anaconda_tb.tar.gz";
36 } 37​ }
37 38​
38 # Upload all ABRT logs 39​ # Upload all ABRT logs
39 script_run "tar czf var_tmp.tar.gz /var/tmp"; 40​ script_run "tar czf /var/tmp/var_tmp.tar.gz /var/tmp";
40 upload_logs "/var/tmp/var_tmp.tar.gz"; 41​ upload_logs "/var/tmp/var_tmp.tar.gz";
41 42​
42 # Upload /var/log 43​ # Upload /var/log
43 script_run "tar czf /tmp/var_log.tar.gz /var/log"; 44​ script_run "tar czf /tmp/var_log.tar.gz /var/log";
44 upload_logs "/tmp/var_log.tar.gz"; 45​ upload_logs "/tmp/var_log.tar.gz";
45 46​
46 # Upload anaconda core dump, if there is one 47​ # Upload anaconda core dump, if there is one
47 script_run "ls /tmp/anaconda.core.* && tar czf /tmp/anaconda.core.tar.gz /tmp/anaconda.core.*"; 48​ script_run "ls /tmp/anaconda.core.* && tar czf /tmp/anaconda.core.tar.gz /tmp/anaconda.core.*";
▲ Show 20 Lines • Show All 99 Lines • Show Last 20 Lines
View Options

needles/anaconda_error-23.json

  • This file was moved from needles/anaconda_error-gtk3195.json.
1{ 1​{
2 "tags": [ ​
3 "ENV-DISTRI-fedora", ​
4 "ENV-FLAVOR-server", ​
5 "anaconda_error" ​
6 ], ​
7 "properties": [], ​
8 "area": [ 2​ "area": [
9 { 3​ {
10 "xpos": 275, 4​ "xpos": 275,
11 "height": 19, 5​ "ypos": 319,
12 "ypos": 322, ​
13 "width": 217, 6​ "width": 217,
7​ "height": 19,
14 "type": "match" 8​ "type": "match"
15 } 9​ }
16 ] 10​ ],
11​ "tags": [
12​ "ENV-DISTRI-fedora",
13​ "ENV-FLAVOR-server",
14​ "anaconda_error"
15​ ],
16​ "properties": []
17} 17​}
18No newline at end of file ​
View Options

needles/anaconda_error-23.png

  • This file was copied from needles/anaconda_error.png.
The contents of this file were not changed.
View Options

needles/anaconda_error-early.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 19,
5​ "type": "match",
6​ "width": 262,
7​ "xpos": 275,
8​ "ypos": 324
9​ }
10​ ],
11​ "properties": [],
12​ "tags": [
13​ "ENV-DISTRI-fedora",
14​ "ENV-FLAVOR-server",
15​ "anaconda_error"
16​ ]
17​}
18​No newline at end of file
View Options

needles/anaconda_error-early.png

  • This binary file was added.
View Options

needles/anaconda_error-gtk3195.json

  • This file was moved to needles/anaconda_error-23.json.
View Options

needles/anaconda_error-gtk3195.png

  • This binary file was deleted.
View Options

needles/anaconda_error.png

  • This binary file was copied to needles/anaconda_error-23.png, needles/anaconda_error_report-23.png.
View Options

needles/anaconda_error_report-23.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 20,
5​ "type": "match",
6​ "width": 100,
7​ "xpos": 570,
8​ "ypos": 430
9​ }
10​ ],
11​ "tags": [
12​ "ENV-DISTRI-fedora",
13​ "anaconda_error_report"
14​ ]
15​}
16​No newline at end of file
View Options

needles/anaconda_error_report-23.png

  • This file was copied from needles/anaconda_error.png.
The contents of this file were not changed.
View Options

needles/anaconda_error_report-early.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 25,
5​ "type": "match",
6​ "width": 100,
7​ "xpos": 565,
8​ "ypos": 425
9​ }
10​ ],
11​ "tags": [
12​ "ENV-DISTRI-fedora",
13​ "anaconda_error_report"
14​ ]
15​}
16​No newline at end of file
View Options

needles/anaconda_error_report-early.png

  • This binary file was added.
View Options

needles/anaconda_error_report.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 25,
5​ "type": "match",
6​ "width": 100,
7​ "xpos": 570,
8​ "ypos": 425
9​ }
10​ ],
11​ "tags": [
12​ "ENV-DISTRI-fedora",
13​ "anaconda_error_report"
14​ ]
15​}
View Options

needles/anaconda_error_report.png

  • This binary file was added.