Pungi 4 conversion: handle Pungi-derived BUILD and FLAVOR
ClosedPublic

Authored by adamwill on Feb 24 2016, 2:03 AM.

Details

Summary

With the arrival of Pungi 4, the scheduler is no longer using
fedfind-provided BUILD and FLAVOR values, but ones derived from
Pungi properties. BUILD is now simply the Pungi compose_id.
FLAVOR is produced by joining the Pungi variant, type, and
format with '-' characters as the separators.

For the one place where we also used to parse the 'milestone'
from fedfind, there is a placeholder get_milestone subroutine
which currently returns an empty string, as I don't yet have a
good handle on how to draw the kinds of distinctions fedfind
mapped to 'milestone' from Pungi metadata.

Goes with D753 for openqa_fedora_tools.

Test Plan

As for D753. Make sure all tests actually behave as
intended.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to Pungi 4 conversion: handle Pungi-derived BUILD and FLAVOR.Feb 24 2016, 2:03 AM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
garretraziel accepted this revision.Feb 24 2016, 9:05 AM

LGTM.

VARIABLES.md
81–88

? for not forgetting changing those.

This revision is now accepted and ready to land.Feb 24 2016, 9:05 AM
jskladan accepted this revision.Feb 24 2016, 9:20 AM

Fine, I guess :)

adamwill added inline comments.Feb 24 2016, 4:04 PM
VARIABLES.md
81–88

YW, but we should actually probably move a lot of this upstream, since it's not particularly Fedora-specific, and have a shorter downstream doc specifying the Fedora conventions for relevant settings...

there are some other docs that I didn't update yet, I will send diffs for those later.

This revision was automatically updated to reflect the committed changes.