Differential D750

Change testcase.name to text
ClosedPublic
Actions

Authored by jskladan on Feb 19 2016, 10:18 AM.

Details

Reviewers
tflink
mkrizek
Group Reviewers
resultsdb
Maniphest Tasks
T706: Change testcase.name to text from varchar(255)
Commits
rRSDB648e9bcdc131: Change testcase.name to text
Summary

First step to testcase namespacing - changing name from varchar(255) to text.
The alembic migration has one slight problem - sqlite does not support ALTER COLUMN, and so the upgrade fails with SQLite. Works with postgres though (tested).
Are we OK with it failing on SQLITE (maybe with documentation saying "if you are on sqlite, please remove the database and initialize it again", or should I try to add some workaround?
I do not think it's worth it (the time spent on working around sqlite), but I'm open to ideas.

Test Plan

tested the migration with postgres

Diff Detail

Repository
rRSDB resultsdb
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jskladan retitled this revision from to Change testcase.name to text.Feb 19 2016, 10:18 AM
jskladan updated this object.
jskladan edited the test plan for this revision. (Show Details)
jskladan added a reviewer: resultsdb.
mkrizek accepted this revision.Feb 19 2016, 1:44 PM
mkrizek added a reviewer: mkrizek.
mkrizek added a subscriber: mkrizek.

Other than small nit, looks good to me.

alembic/versions/978007ecd2b_changed_testcase_name_to_text.py
29

Probably left here by mistake?

This revision is now accepted and ready to land.Feb 19 2016, 1:44 PM
tflink accepted this revision.Feb 19 2016, 2:29 PM
tflink added a reviewer: tflink.
Closed by commit rRSDB648e9bcdc131: Change testcase.name to text (authored by Josef Skladanka <jskladan@redhat.com>). · Explain WhyFeb 22 2016, 10:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 1928

View Options

alembic/env.py

Show All 33 Lines29def run_migrations_offline():
34 here as well. By skipping the Engine creation 34​ here as well. By skipping the Engine creation
35 we don't even need a DBAPI to be available. 35​ we don't even need a DBAPI to be available.
36 36​
37 Calls to context.execute() here emit the given string to the 37​ Calls to context.execute() here emit the given string to the
38 script output. 38​ script output.
39 39​
40 """ 40​ """
41 url = config.get_main_option("sqlalchemy.url") 41​ url = config.get_main_option("sqlalchemy.url")
42 context.configure(url=url) 42​ context.configure(url=url, compare_type=True)
43 43​
44 with context.begin_transaction(): 44​ with context.begin_transaction():
45 context.run_migrations() 45​ context.run_migrations()
46 46​
47def run_migrations_online(): 47​def run_migrations_online():
48 """Run migrations in 'online' mode. 48​ """Run migrations in 'online' mode.
49 49​
50 In this scenario we need to create an Engine 50​ In this scenario we need to create an Engine
Show All 30 Lines
View Options

alembic/versions/978007ecd2b_changed_testcase_name_to_text.py

  • This file was added.
1​"""Changed testcase.name to text
2​
3​Revision ID: 978007ecd2b
4​Revises: 4bf1390f06d1
5​Create Date: 2016-02-18 21:41:04.273020
6​
7​"""
8​
9​# revision identifiers, used by Alembic.
10​revision = '978007ecd2b'
11​down_revision = '4bf1390f06d1'
12​branch_labels = None
13​depends_on = None
14​
15​from alembic import op
16​import sqlalchemy as sa
17​
18​
19​def upgrade():
20​ ### commands auto generated by Alembic - please adjust! ###
21​ op.alter_column('testcase', 'name', type_=sa.Text)
22​ op.create_index('testcase_idx_name', 'testcase', ['name'], unique=False, postgresql_ops={'name': 'text_pattern_ops'})
23​ ### end Alembic commands ###
24​
25​
26​def downgrade():
27​ ### commands auto generated by Alembic - please adjust! ###
28​ op.alter_column('testcase', 'name', type_=sa.String(255))
29​ op.drop_index('testcase_idx_name', table_name='testcase')
mkrizekUnsubmitted
Not Done

Probably left here by mistake?

30​ ### end Alembic commands ###
View Options

resultsdb/models/results.py

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Line(s)52 def __init__(self, status = 'SCHEDULED', ref_url = None, name = None, uuid = None):
54 self.ref_url = ref_url 54​ self.ref_url = ref_url
55 self.name = name 55​ self.name = name
56 self.uuid = uuid 56​ self.uuid = uuid
57 57​
58 58​
59class Testcase(db.Model, DBSerialize): 59​class Testcase(db.Model, DBSerialize):
60 60​
61 id = db.Column(db.Integer, primary_key = True) 61​ id = db.Column(db.Integer, primary_key = True)
62 name = db.Column(db.String(255), unique = True) 62​ name = db.Column(db.Text, unique = True)
63 url = db.Column(db.Text) 63​ url = db.Column(db.Text)
64 64​
65​ __table_args__ = (
66​ db.Index('testcase_idx_name', 'name',
67​ postgresql_ops={'name': 'text_pattern_ops'},
68​ ),
69​ )
70​
65 def __init__(self, name, url): 71​ def __init__(self, name, url):
66 self.url = url 72​ self.url = url
67 self.name = name 73​ self.name = name
68 74​
69 75​
70class Result(db.Model, DBSerialize): 76​class Result(db.Model, DBSerialize):
71 77​
72 id = db.Column(db.Integer, primary_key = True) 78​ id = db.Column(db.Integer, primary_key = True)
▲ Show 20 Lines • Show All 44 Lines • Show Last 20 Lines