categorize needles into directories
ClosedPublic

Authored by garretraziel on Feb 15 2016, 1:27 PM.

Details

Summary

Since openQA can load needles from directory recursivelly, this
diff categorizes needles. BUT turns out that while openQA can handle
needles in nested dirs, os-autoinst cannot, see https://github.com/os-autoinst/os-autoinst/issues/426.
So while this is nice, it doesn't actually work right now. We have to
wait until this gets implemented and then we can test this and merge
this.

I will put this DR to Phabricator not to lost this. If you don't want
dangling DR review request, remove yourself from reviewers.

Test Plan

None, does not work, no review necessary just yet.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
garretraziel retitled this revision from to categorize needles into directories.Feb 15 2016, 1:27 PM
garretraziel updated this object.
garretraziel edited the test plan for this revision. (Show Details)
garretraziel added reviewers: adamwill, jskladan.

The changes enabling this behaviour are in the upstream repos now:
https://github.com/os-autoinst/openQA/pull/613
https://github.com/os-autoinst/os-autoinst/pull/452

Do we have any idea how long it takes from that point to us having the code deployed?

If the changes are easily backportable I can have it deployed tomorrow morning, it's just a case of backporting the patches, kicking out new package builds and updating the servers. Do you want me to do that?

...it's just a case of backporting the patches...

I can even provide patches for our current packages, as I've been developing it on top of that. Yeah, I could not find a sane way to run openqa/os-autoinst from git, so I've been in fact "forward-porting" the changes :D

Then by all means just sling the patches at me somehow or other and I'll bump the package.

I've had the updated openQA/os-autoinst running on stg all week and it seems fine, so I'm applying it to prod now. The update will go stable tomorrow.

I'm fine with this change in principle, it will probably need some rediffing now though.

jskladan added a subscriber: jskladan.
Closed by commit rOPENQATESTSad044c0b3f9f: Organize needles to directories (step 1/2) (authored by Josef Skladanka <jskladan@redhat.com>). · Explain WhyMay 13 2016, 12:10 PM
Closed by commit rOPENQATESTS0d488890ba44: Organize needles to directories (step 2/2) (authored by Josef Skladanka <jskladan@redhat.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.

This is going to be a PITA for creating new needles, because I think the web UI will always create them in the top level directory, and we'll have to move them manually before commit :(

This is going to be a PITA for creating new needles, because I think the web UI will always create them in the top level directory, and we'll have to move them manually before commit :(

Yeah, that's unfortunate. OTOH, I find current structure to be much more readable.