| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | libtaskotron/ext/fedora/rpm_utils.py (14 lines) | |||
| M | libtaskotron/os_utils.py (4 lines) |
| Commit | Tree | Parents | Author | Summary | Date |
|---|---|---|---|---|---|
| 82d2d7bcc08e | e6fa95d676fb | 50550d42edff | Kamil Páral | fix unicode errors when logging into a file (Show More…) | Feb 9 2016, 11:38 AM |
| Show First 20 Lines • Show All 142 Lines • ▼ Show 20 Line(s) | 108 | def install(pkgs): | |||
|---|---|---|---|---|---|
| 143 | 143 | | |||
| 144 | while True: # we need to call the command twice, if the first run with --cacheonly fails | 144 | while True: # we need to call the command twice, if the first run with --cacheonly fails | ||
| 145 | log.debug('Running: %s', ' '.join([pipes.quote(c) for c in cmd])) | 145 | log.debug('Running: %s', ' '.join([pipes.quote(c) for c in cmd])) | ||
| 146 | 146 | | |||
| 147 | try: | 147 | try: | ||
| 148 | output = subprocess.check_output(cmd, stderr=subprocess.STDOUT) | 148 | output = subprocess.check_output(cmd, stderr=subprocess.STDOUT) | ||
| 149 | except subprocess.CalledProcessError as e: | 149 | except subprocess.CalledProcessError as e: | ||
| 150 | if '--cacheonly' in cmd: # maybe just outdated cache | 150 | if '--cacheonly' in cmd: # maybe just outdated cache | ||
| 151 | log.debug('✘ Package installation failed, DNF output was:\n%s', e.output.rstrip()) | 151 | log.debug(u'✘ Package installation failed, DNF output was:\n%s', e.output.rstrip()) | ||
| 152 | log.debug("Trying again with forced metadata refresh...") | 152 | log.debug("Trying again with forced metadata refresh...") | ||
| 153 | cmd = list(cmd) # make a copy to allow unit tests to intercept both calls easily | 153 | cmd = list(cmd) # make a copy to allow unit tests to intercept both calls easily | ||
| 154 | cmd.remove('--cacheonly') | 154 | cmd.remove('--cacheonly') | ||
| 155 | cmd.append('--refresh') | 155 | cmd.append('--refresh') | ||
| 156 | continue | 156 | continue | ||
| 157 | 157 | | |||
| 158 | log.error('✘ Package installation failed. We tried to install following packages:\n%s' | 158 | log.error(u'✘ Package installation failed. We tried to install following packages:\n%s' | ||
| 159 | '\nDNF returned exit code %d and output:\n%s', pkglist, e.returncode, | 159 | '\nDNF returned exit code %d and output:\n%s', pkglist, e.returncode, | ||
| 160 | e.output.rstrip()) | 160 | e.output.rstrip()) | ||
| 161 | raise exc.TaskotronError("Unable to install packages: %s" % pkglist) | 161 | raise exc.TaskotronError("Unable to install packages: %s" % pkglist) | ||
| 162 | else: | 162 | else: | ||
| 163 | log.debug('✔ Package installation completed successfully. DNF output was:\n%s', | 163 | log.debug(u'✔ Package installation completed successfully. DNF output was:\n%s', | ||
| 164 | output.rstrip()) | 164 | output.rstrip()) | ||
| 165 | return | 165 | return | ||
| 166 | 166 | | |||
| 167 | # safeguard against infinite loop, we should never reach this code | 167 | # safeguard against infinite loop, we should never reach this code | ||
| 168 | log.critical("Infinite loop detected in 'install()'") | 168 | log.critical("Infinite loop detected in 'install()'") | ||
| 169 | assert False, "Infinite loop detected in 'install()'" | 169 | assert False, "Infinite loop detected in 'install()'" | ||
| 170 | return | 170 | return | ||
| 171 | 171 | | |||
| Show All 24 Lines | 195 | if not os_utils.is_root() and os_utils.has_sudo(): | |||
| 196 | cmd = ['sudo', '--non-interactive'] + cmd | 196 | cmd = ['sudo', '--non-interactive'] + cmd | ||
| 197 | 197 | | |||
| 198 | log.info('Checking installed state of %d packages...', len(pkgs)) | 198 | log.info('Checking installed state of %d packages...', len(pkgs)) | ||
| 199 | log.debug('Running: %s', ' '.join([pipes.quote(c) for c in cmd])) | 199 | log.debug('Running: %s', ' '.join([pipes.quote(c) for c in cmd])) | ||
| 200 | 200 | | |||
| 201 | try: | 201 | try: | ||
| 202 | subprocess.check_output(cmd, stderr=subprocess.STDOUT) | 202 | subprocess.check_output(cmd, stderr=subprocess.STDOUT) | ||
| 203 | except subprocess.CalledProcessError as e: | 203 | except subprocess.CalledProcessError as e: | ||
| 204 | log.debug('✘ Some of specified packages are not installed. DNF returned exit code %d and ' | 204 | log.debug(u'✘ Some of specified packages are not installed. DNF returned exit code %d and ' | ||
| 205 | 'output:\n%s', e.returncode, e.output.rstrip()) | 205 | 'output:\n%s', e.returncode, e.output.rstrip()) | ||
| 206 | return False | 206 | return False | ||
| 207 | else: | 207 | else: | ||
| 208 | log.debug('✔ All specified packages are installed') | 208 | log.debug(u'✔ All specified packages are installed') | ||
| 209 | return True | 209 | return True | ||
| 210 | 210 | | |||
| 211 | 211 | | |||
| 212 | def dnf_cache_available(): | 212 | def dnf_cache_available(): | ||
| 213 | '''Determine whether DNF cache is available. | 213 | '''Determine whether DNF cache is available. | ||
| 214 | 214 | | |||
| 215 | If it is, we can run read-only actions solely from the cache, and try to use it even for | 215 | If it is, we can run read-only actions solely from the cache, and try to use it even for | ||
| 216 | ``install`` action (provided the repos haven't changed much). This way we avoid contacting | 216 | ``install`` action (provided the repos haven't changed much). This way we avoid contacting | ||
| Show All 10 Lines | |||||
| 227 | 227 | | |||
| 228 | if not os_utils.is_root() and os_utils.has_sudo(): | 228 | if not os_utils.is_root() and os_utils.has_sudo(): | ||
| 229 | cmd = ['sudo', '--non-interactive'] + cmd | 229 | cmd = ['sudo', '--non-interactive'] + cmd | ||
| 230 | 230 | | |||
| 231 | log.debug('Deciding whether DNF cache is available. Running: %s', ' '.join(cmd)) | 231 | log.debug('Deciding whether DNF cache is available. Running: %s', ' '.join(cmd)) | ||
| 232 | try: | 232 | try: | ||
| 233 | subprocess.check_output(cmd, stderr=subprocess.STDOUT) | 233 | subprocess.check_output(cmd, stderr=subprocess.STDOUT) | ||
| 234 | except subprocess.CalledProcessError as e: | 234 | except subprocess.CalledProcessError as e: | ||
| 235 | log.debug('✘ DNF cache is not available. Received exit code %d and output:\n%s', | 235 | log.debug(u'✘ DNF cache is not available. Received exit code %d and output:\n%s', | ||
| 236 | e.returncode, e.output.rstrip()) | 236 | e.returncode, e.output.rstrip()) | ||
| 237 | return False | 237 | return False | ||
| 238 | else: | 238 | else: | ||
| 239 | log.debug('✔ DNF cache is available.') | 239 | log.debug(u'✔ DNF cache is available.') | ||
| 240 | return True | 240 | return True | ||
| 241 | 241 | | |||
| 242 | 242 | | |||
| 243 | def get_dist_tag(rpmstr): | 243 | def get_dist_tag(rpmstr): | ||
| 244 | '''Parse disttag from an RPM package version string. | 244 | '''Parse disttag from an RPM package version string. | ||
| 245 | 245 | | |||
| 246 | :param str rpmstr: string to be manipulated in a format of N(E)VR | 246 | :param str rpmstr: string to be manipulated in a format of N(E)VR | ||
| 247 | (``foo-1.2-3.fc20`` or ``bar-4:1.2-3.fc20``) or N(E)VRA | 247 | (``foo-1.2-3.fc20`` or ``bar-4:1.2-3.fc20``) or N(E)VRA | ||
| Show All 13 Lines | |||||
| Show All 32 Lines | 23 | def has_sudo(): | |||
|---|---|---|---|---|---|
| 33 | # seen as an impolite thing to do (esp. when we're not granted the sudo access, we would still | 33 | # seen as an impolite thing to do (esp. when we're not granted the sudo access, we would still | ||
| 34 | # reset the cache with every run) and it might obstruct some use cases. Not implemented ATM. | 34 | # reset the cache with every run) and it might obstruct some use cases. Not implemented ATM. | ||
| 35 | cmd = ['sudo', '--validate', '--non-interactive'] | 35 | cmd = ['sudo', '--validate', '--non-interactive'] | ||
| 36 | log.debug('Deciding whether we have a password-less sudo access. Running: %s', ' '.join(cmd)) | 36 | log.debug('Deciding whether we have a password-less sudo access. Running: %s', ' '.join(cmd)) | ||
| 37 | 37 | | |||
| 38 | try: | 38 | try: | ||
| 39 | subprocess.check_output(cmd, stderr=subprocess.STDOUT) | 39 | subprocess.check_output(cmd, stderr=subprocess.STDOUT) | ||
| 40 | except subprocess.CalledProcessError as e: | 40 | except subprocess.CalledProcessError as e: | ||
| 41 | log.debug("✘ Sudo access is not available. Received exit code %d and output:\n%s", | 41 | log.debug(u"✘ Sudo access is not available. Received exit code %d and output:\n%s", | ||
| 42 | e.returncode, e.output.rstrip()) | 42 | e.returncode, e.output.rstrip()) | ||
| 43 | return False | 43 | return False | ||
| 44 | else: | 44 | else: | ||
| 45 | log.debug('✔ Sudo access is available') | 45 | log.debug(u'✔ Sudo access is available') | ||
| 46 | return True | 46 | return True | ||