Fix some warnings that are shown during test loading
ClosedPublic
Actions

Authored by garretraziel on Feb 9 2016, 9:14 AM.

Details

Reviewers

adamwill
jskladan

Commits

rOPENQATESTS944484a091e7: fix some warnings that are shown during test loading

Summary

When going through logs I found out that test loading
shows some warnings. This corrects them.

Test Plan

Try to schedule all tests again

Diff Detail

Repository

rOPENQATESTS os-autoinst-distri-fedora

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

garretraziel retitled this revision from to Fix some warnings that are shown during test loading.Feb 9 2016, 9:14 AM

garretraziel updated this object.

garretraziel edited the test plan for this revision. (Show Details)

garretraziel added reviewers: adamwill, jskladan.

Herald added a subscriber: tflink. · View Herald TranscriptFeb 9 2016, 9:14 AM

lib/fedoradistribution.pm
17–19	maybe a small comment to describe what's going on? I guess that's something standard perl, just that I'd like to be informed :)

This revision is now accepted and ready to land.Feb 9 2016, 1:44 PM

this seems fine, I've seen the same warnings but always been too lazy to change it all. Didn't test, I'm on vacation. :P

lib/fedoradistribution.pm
17–19	It's maybe a bit too basic to comment, it'd be like commenting `from foo import bar` in Python...`qw` is quotewords, it creates an array (list) from some strings, you could just as well type `("send_key", "type_string", "wait_idle", "assert_screen")` but perl folks seem to like `qw` although the convenience benefit seems marginal. In perl you almost always see it done this way (or as `qw/foo bar moo/`, because in perl there's always two ways to skin a cat...), not with the array syntax.

lib/fedoradistribution.pm
17–19	Still, I will document why is this needed (because importing whole testapi creates circural dependency for some reason).

Closed by commit rOPENQATESTS944484a091e7: fix some warnings that are shown during test loading (authored by garretraziel). · Explain WhyFeb 10 2016, 8:46 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

			Path	Packages
M			lib/fedoradistribution.pm (8 lines)
M			main.pm (34 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1901	41adcd8		Feb 9 2016, 9:14 AM	★	★
Diff 2	1908	596772f	Commit rOPENQATESTS944484a091e745b13229c77273cc7c091c561589	Feb 10 2016, 8:42 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
611de1102b72	6a2c17c57320	41adcd87d468	Jan Sedlák	fix Perl warnings in tests	Feb 9 2016, 9:12 AM

Diff 1908

View Options

lib/fedoradistribution.pm

1	package fedoradistribution;	1		package fedoradistribution;
2	use base 'distribution';	2		use base 'distribution';
3		3
4	use testapi;
5
6	# Fedora distribution class	4		# Fedora distribution class
7		5
8	# Distro-specific functions, that are actually part of the API	6		# Distro-specific functions, that are actually part of the API
9	# (and it's completely up to us to implement them) should be here	7		# (and it's completely up to us to implement them) should be here
10		8
11	# functions that can be reimplemented:	9		# functions that can be reimplemented:
12	# ensure_installed	10		# ensure_installed
13	# x11_start_program	11		# x11_start_program
14	# become_root	12		# become_root
15	# script_run	13		# script_run
16	# script_sudo	14		# script_sudo
17	# type_password	15		# type_password
18		16
19	use testapi qw(send_key type_string);	17		# importing whole testapi creates circular dependency, so import inly
		18		# necessary functions from testapi
		19		use testapi qw(send_key type_string wait_idle assert_screen);
			jskladanUnsubmitted Not Done maybe a small comment to describe what's going on? I guess that's something standard perl, just that I'd like to be informed :)
			adamwillUnsubmitted Not Done It's maybe a bit too basic to comment, it'd be like commenting `from foo import bar` in Python...`qw` is quotewords, it creates an array (list) from some strings, you could just as well type `("send_key", "type_string", "wait_idle", "assert_screen")` but perl folks seem to like `qw` although the convenience benefit seems marginal. In perl you almost always see it done this way (or as `qw/foo bar moo/`, because in perl there's always two ways to skin a cat...), not with the array syntax.
			garretrazielAuthorUnsubmitted Not Done Still, I will document why is this needed (because importing whole testapi creates circural dependency for some reason).
20		20
21	sub init() {	21		sub init() {
22	my ($self) = @_;	22		my ($self) = @_;
23		23
24	$self->SUPER::init();	24		$self->SUPER::init();
25	}	25		}
26		26
27	sub x11_start_program($$$) {	27		sub x11_start_program {
28	my ($self, $program, $timeout, $options) = @_;	28		my ($self, $program, $timeout, $options) = @_;
29	send_key "alt-f2";	29		send_key "alt-f2";
30	assert_screen "desktop_runner";	30		assert_screen "desktop_runner";
31	type_string $program;	31		type_string $program;
32	wait_idle 5; # because of KDE dialog - SUSE guys are doing the same!	32		wait_idle 5; # because of KDE dialog - SUSE guys are doing the same!
33	send_key "ret", 1;	33		send_key "ret", 1;
34	}	34		}
35		35
Show All 9 Lines