Differential D723

Do not crash when a check does not provide result
ClosedPublic
Actions

Authored by mkrizek on Jan 14 2016, 3:14 PM.

Details

Reviewers
kparal
tflink
jskladan
Commits
rLTRNf6c3a4fb2b56: Do not crash when a check does not provide result
Summary
[libtaskotron] 14:21:18 CRITICAL Traceback (most recent call last):
  File "runtask.py", line 10, in <module>
    main.main()
  File "/home/mkrizek/devel/libtaskotron/libtaskotron/main.py", line 151, in main
    overlord.start()
  File "/home/mkrizek/devel/libtaskotron/libtaskotron/overlord.py", line 95, in start
    runner.execute()
  File "/home/mkrizek/devel/libtaskotron/libtaskotron/executor.py", line 56, in execute
    self._run()
  File "/home/mkrizek/devel/libtaskotron/libtaskotron/executor.py", line 93, in _run
    self._do_actions()
  File "/home/mkrizek/devel/libtaskotron/libtaskotron/executor.py", line 131, in _do_actions
    self._do_single_action(action)
  File "/home/mkrizek/devel/libtaskotron/libtaskotron/executor.py", line 152, in _do_single_action
    self.arg_data)
  File "/home/mkrizek/devel/libtaskotron/libtaskotron/directives/resultsdb_directive.py", line 193, in process
    check_details = check.import_YAML(input_data['results'])
  File "/home/mkrizek/devel/libtaskotron/libtaskotron/check.py", line 332, in import_YAML
    data = yaml.safe_load(source)
  File "/home/mkrizek/devel/libtaskotron/env_taskotron/lib/python2.7/site-packages/yaml/__init__.py", line 93, in safe_load
    return load(stream, SafeLoader)
  File "/home/mkrizek/devel/libtaskotron/env_taskotron/lib/python2.7/site-packages/yaml/__init__.py", line 69, in load
    loader = Loader(stream)
  File "/home/mkrizek/devel/libtaskotron/env_taskotron/lib/python2.7/site-packages/yaml/loader.py", line 24, in __init__
    Reader.__init__(self, stream)
  File "/home/mkrizek/devel/libtaskotron/env_taskotron/lib/python2.7/site-packages/yaml/reader.py", line 85, in __init__
    self.determine_encoding()
  File "/home/mkrizek/devel/libtaskotron/env_taskotron/lib/python2.7/site-packages/yaml/reader.py", line 124, in determine_encoding
    self.update_raw()
  File "/home/mkrizek/devel/libtaskotron/env_taskotron/lib/python2.7/site-packages/yaml/reader.py", line 178, in update_raw
    data = self.stream.read(size)
AttributeError: 'NoneType' object has no attribute 'read'
Test Plan

Run a check that does not provide check detail - like the example in Writing tasks section in docs.

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkrizek retitled this revision from to Do not crash when a check does not provide result.Jan 14 2016, 3:14 PM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added reviewers: tflink, kparal, jskladan.
tflink accepted this revision.Jan 14 2016, 3:21 PM
This revision is now accepted and ready to land.Jan 14 2016, 3:21 PM
mkrizek updated this revision to Diff 1858.Jan 14 2016, 3:45 PM

Add unittest

tflink added a comment.Jan 14 2016, 3:51 PM

Thanks for adding the test. Still looks good to me

/me puts "look at test coverage" on his TODO list for the not-so-distant future

Closed by commit rLTRNf6c3a4fb2b56: Do not crash when a check does not provide result (authored by mkrizek). · Explain WhyJan 18 2016, 12:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mlibtaskotron/check.py (3 lines)
Mtesting/test_check.py (5 lines)

Diff 1862

View Options

libtaskotron/check.py

Show First 20 Lines • Show All 322 Lines • ▼ Show 20 Line(s)
323 323​
324def import_YAML(source): 324​def import_YAML(source):
325 '''Parses YAML and returns a list of :class:`CheckDetails <CheckDetail>`. 325​ '''Parses YAML and returns a list of :class:`CheckDetails <CheckDetail>`.
326 326​
327 :param str source: YAML-formatted text 327​ :param str source: YAML-formatted text
328 :raise TaskotronValueError: if YAML syntax is incorrect 328​ :raise TaskotronValueError: if YAML syntax is incorrect
329 ''' 329​ '''
330 330​
331​ if not source:
332​ raise exc.TaskotronValueError('Failed to parse YAML contents: empty input')
333​
331 try: 334​ try:
332 data = yaml.safe_load(source) 335​ data = yaml.safe_load(source)
333 except yaml.scanner.ScannerError as e: 336​ except yaml.scanner.ScannerError as e:
334 raise exc.TaskotronValueError('Failed to parse YAML contents: %s' % e) 337​ raise exc.TaskotronValueError('Failed to parse YAML contents: %s' % e)
335 338​
336 # check basic structure of the loaded object" 339​ # check basic structure of the loaded object"
337 if type(data) is not dict: 340​ if type(data) is not dict:
338 raise exc.TaskotronValueError("Invalid type of the YAML root element, %s instead of dict" % 341​ raise exc.TaskotronValueError("Invalid type of the YAML root element, %s instead of dict" %
Show All 34 Lines
View Options

testing/test_check.py

Show First 20 Lines • Show All 356 Lines • ▼ Show 20 Line(s)347 def test_import_exported(self):
357 assert cd.outcome == self.cd.outcome 357​ assert cd.outcome == self.cd.outcome
358 assert cd.note == self.cd.note 358​ assert cd.note == self.cd.note
359 assert cd.report_type == self.cd.report_type 359​ assert cd.report_type == self.cd.report_type
360 assert cd.keyvals == self.keyvals 360​ assert cd.keyvals == self.keyvals
361 assert cd.checkname == self.checkname 361​ assert cd.checkname == self.checkname
362 assert cd.artifact == self.artifact 362​ assert cd.artifact == self.artifact
363 assert cd._internal == self._internal 363​ assert cd._internal == self._internal
364 364​
365​ def test_no_yaml(self):
366​ yaml_output = None
367​ with pytest.raises(exc.TaskotronValueError):
368​ check.import_YAML(yaml_output)
369​
365 def test_invalid_yaml(self): 370​ def test_invalid_yaml(self):
366 yaml_output = "key:value\nkey: value" 371​ yaml_output = "key:value\nkey: value"
367 with pytest.raises(exc.TaskotronValueError): 372​ with pytest.raises(exc.TaskotronValueError):
368 check.import_YAML(yaml_output) 373​ check.import_YAML(yaml_output)
369 374​
370 def test_invalid_yaml_root_element_type(self): 375​ def test_invalid_yaml_root_element_type(self):
371 yaml_output = "[]" 376​ yaml_output = "[]"
372 with pytest.raises(exc.TaskotronValueError): 377​ with pytest.raises(exc.TaskotronValueError):
Show All 20 Lines