Differential D702

schedule: openQA settings for 'current' and 'previous' release
ClosedPublic
Actions

Authored by adamwill on Dec 18 2015, 3:45 PM.

Details

Reviewers
garretraziel
jskladan
Commits
rOPENQA5b79dc457212: schedule: openQA settings for 'current' and 'previous' release
Summary

This causes the scheduler to try and discover the 'current' and
'previous' releases at the time it's run and pass these in as
openQA settings 'CURRREL' and 'PREVREL' respectively. These are
intended for use by the upgrade tests so they do not have to
hardcode the expected release numbers in the disk image names,
and of course we may come up with other uses in future.

Test Plan

Schedule the upgrade tests and make sure CURRREL and
PREVREL are set correctly, and if you apply the matching diff
for openqa_fedora and reload templates, the correct hard disk
image filenames are used.

Diff Detail

Repository
rOPENQA fedora_openqa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to schedule: openQA settings for 'current' and 'previous' release.Dec 18 2015, 3:45 PM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
garretraziel accepted this revision.Dec 21 2015, 10:06 AM

Sure, looks OK.

This revision is now accepted and ready to land.Dec 21 2015, 10:06 AM
adamwill added a comment.Dec 21 2015, 6:05 PM

Thanks! How about D703? They kinda go together.

garretraziel added a comment.Dec 22 2015, 7:42 AM
In D702#13452, @adamwill wrote:

Thanks! How about D703? They kinda go together.

I forgot to post it :-D.

Revision Contents

PathPackages
Mfedora_openqa_schedule/schedule.py (15 lines)

Diff 1823

View Options

fedora_openqa_schedule/schedule.py

Show All 24 Lines
25 25​
26# Standard libraries 26​# Standard libraries
27import json 27​import json
28import logging 28​import logging
29import os.path 29​import os.path
30import re 30​import re
31 31​
32# External dependencies 32​# External dependencies
33​import fedfind.helpers
33import fedfind.release 34​import fedfind.release
34from openqa_client.client import OpenQA_Client 35​from openqa_client.client import OpenQA_Client
35from six.moves import configparser 36​from six.moves import configparser
36from six.moves.urllib.request import urlopen 37​from six.moves.urllib.request import urlopen
37 38​
38# Internal dependencies 39​# Internal dependencies
39from fedora_openqa_schedule.config import CONFIG 40​from fedora_openqa_schedule.config import CONFIG
40 41​
▲ Show 20 Lines • Show All 76 Lines • ▼ Show 20 Line(s)115def run_openqa_jobs(isoname, flavor, arch, build, force=False):
117 BUILD and is parsed back into the 'relval report-auto' arguments 118​ BUILD and is parsed back into the 'relval report-auto' arguments
118 by report_job_results.py; it is expected to be in the form of a 119​ by report_job_results.py; it is expected to be in the form of a
119 3-tuple on which join('_') has been run, and the three elements 120​ 3-tuple on which join('_') has been run, and the three elements
120 will be passed as release, compose and milestone. Returns list of 121​ will be passed as release, compose and milestone. Returns list of
121 job IDs. If force is False, jobs will only be scheduled if there 122​ job IDs. If force is False, jobs will only be scheduled if there
122 are no existing, non-cancelled jobs for the same ISO and flavor. 123​ are no existing, non-cancelled jobs for the same ISO and flavor.
123 """ 124​ """
124 logger.info("sending jobs to openQA") 125​ logger.info("sending jobs to openQA")
126​ # find current and previous releases; these are used to determine
127​ # the hard disk image file names for the upgrade tests
128​ try:
129​ currrel = str(fedfind.helpers.get_current_release())
130​ prevrel = str(int(currrel) - 1)
131​ except ValueError:
132​ # we don't really want to bail entirely if fedfind failed for
133​ # some reason, let's just run the other tests and set a value
134​ # that shows what went wrong for the upgrade tests
135​ currrel = prevrel = "FEDFINDERROR"
125 136​
126 # starts OpenQA jobs 137​ # starts OpenQA jobs
127 params = { 138​ params = {
128 'ISO': isoname, 139​ 'ISO': isoname,
129 'DISTRI': 'fedora', 140​ 'DISTRI': 'fedora',
130 'VERSION': build.split('_')[0], 141​ 'VERSION': build.split('_')[0],
131 'FLAVOR': flavor, 142​ 'FLAVOR': flavor,
132 'ARCH': arch, 143​ 'ARCH': arch,
133 'BUILD': build 144​ 'BUILD': build,
145​ 'CURRREL': currrel,
146​ 'PREVREL': prevrel,
134 } 147​ }
135 client = OpenQA_Client() 148​ client = OpenQA_Client()
136 if not force: 149​ if not force:
137 # Check if we have any existing non-cancelled jobs for this 150​ # Check if we have any existing non-cancelled jobs for this
138 # ISO and flavor (checking flavor is important otherwise we'd 151​ # ISO and flavor (checking flavor is important otherwise we'd
139 # bail on doing the per-ISO jobs for the ISO we use for the 152​ # bail on doing the per-ISO jobs for the ISO we use for the
140 # 'universal' tests). 153​ # 'universal' tests).
141 jobs = client.openqa_request('GET', 'jobs', params={'iso': isoname})['jobs'] 154​ jobs = client.openqa_request('GET', 'jobs', params={'iso': isoname})['jobs']
▲ Show 20 Lines • Show All 189 Lines • Show Last 20 Lines