add a base_selinux test (follow-on from default_install)
ClosedPublic
Actions

Authored by adamwill on Dec 17 2015, 5:17 AM.

Details

Reviewers

garretraziel
jskladan

Commits

rOPENQATESTS85c57b47e428: add a base_selinux test (follow-on from default_install)

Summary

so here's our first attempt to use the 'carry on from a previous
test' stuff! This adds a base_selinux test that uses a disk
image from a previous default_install run, and adds jobtemplates
to run base_selinux for appropriate products: generic_boot
(for nightly tests), server_dvd, and workstation_live. Note that
you'll want to either update to the newest openQA package I just
built in COPR or create /var/lib/openqa/share/factory/tmp owned
by geekotest; openQA tries to use that directory as MOJO_TMPDIR
but in 4.2, if the directory doesn't exist, it doesn't create it,
and we wind up with the default MOJO_TMPDIR which is /tmp; when
the disk image is uploaded it creates a huge temp file in /tmp
and may well exhaust the available space as it's a tmpfs. I've
backported a recent upstream commit that tries to create the
directory if it doesn't exist, in 4.2-10.

It seems like openQA is smart enough to figure out the
dependencies correctly, so the 'base_selinux' test for each
product depends on the 'default_install' test for the same
product (not any of the other default_install runs) and will
use the hard disk image it produces.

Test Plan

Do a full test run and make sure base_selinux tests
appear for appropriate products, depend on the correct default_
install test, the default_install test uploads the hard disk
image correctly, and the base_selinux test runs correctly. And
of course that nothing else broke in the process...

Diff Detail

Repository

rOPENQATESTS os-autoinst-distri-fedora

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

adamwill retitled this revision from to add a base_selinux test (follow-on from default_install).Dec 17 2015, 5:17 AM

adamwill updated this object.

adamwill edited the test plan for this revision. (Show Details)

adamwill added reviewers: jskladan, garretraziel.

Herald added a subscriber: tflink. · View Herald TranscriptDec 17 2015, 5:17 AM

adamwill mentioned this in D700: report base_selinux results (add $PAYLOAD$ as another env choice).Dec 17 2015, 5:22 AM

jskladan accepted this revision.Dec 17 2015, 7:41 AM

This revision is now accepted and ready to land.Dec 17 2015, 7:41 AM

I can't review this - after upgrading to version 4.2-10, openQA doesn't work. It stops completely responding after a while - it stops updating window or log and it also doesn't respond to canceling this job. I will try to investigate further.

It looks like it's problem with disk uploading. Test actually freezes during saving HDD (at the end of default_install test), then it shows something along the lines of "hdd_1 upload failed" - during HDD uploading, my computer is REALLY unresponsive, so I couldn't really copy that message, test failed (but it shows as if all steps passed in WebUI) and got copied to new job and for some reason, old autoinst-log.txt gets deleted every time this happens.

In /var/log/openqa, there is: [Thu Dec 17 14:38:25 2015] [error] Worker 5678 has no heartbeat, restarting. I will try to investigate further. Either way, if this works for you, code looks OK, so feel free to merge this.

That's quite similar to what I saw with the /tmp problem - check if there's any huge files in /tmp and it's at 100% capacity, check if /var/lib/openqa/factory/tmp exists...

I tested on openqa.happyassassin.net and it seemed OK after I created the required dir manually, but I'll check this out on staging before I merge it to develop and send it to prod.

adamwill mentioned this in rOPENQAcdb5d63f4af6: report base_selinux results (add $PAYLOAD$ as another env choice).Dec 17 2015, 8:37 PM

Closed by commit rOPENQATESTS85c57b47e428: add a base_selinux test (follow-on from default_install) (authored by adamwill). · Explain WhyDec 17 2015, 8:46 PM

This revision was automatically updated to reflect the committed changes.

adamwill mentioned this in rOPENQAd4b4581bde08: report base_selinux results (add $PAYLOAD$ as another env choice).

I tested it out on staging and it worked fine, so I've landed it and sent it to both staging and production properly. It worked fine on prod too. Your problem might be that you need to restart openqa-webui.service? I had to do that manually on prod after the package update to make it work right.

Yes, it was caused by missing tmp/. Problem was little less apparent - I updated openQA and restarted all its services, but I am using bindfs to mount directory from my home to /var/lib/openqa/share/factory (so I could run downloader as normal user and also so I wouldn't have all files downloaded to my root partition) and it didn't automatically create tmp directory on it and used /tmp instead. Anyway, it works OK.

Revision Contents

			Path	Packages
M			templates (43 lines)
A	M		tests/base_selinux.pm (25 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1805	76756a9		Dec 17 2015, 5:17 AM	★	★
Diff 2	1809	d06f775	Commit rOPENQATESTS85c57b47e428ff181900d08af24922fe9d75e2fd	Dec 17 2015, 8:46 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
20c6e2027fb5	1d7e0950a47c	76756a9005de	Adam Williamson	add a base_selinux test (follow-on from default_install) (Show More…)	Dec 17 2015, 5:09 AM

Diff 1809

View Options

templates

Show First 20 Lines • Show All 101 Lines • ▼ Show 20 Line(s)		100	product => {
102	distri => "fedora",	102		distri => "fedora",
103	flavor => "cloud_atomic_canned",	103		flavor => "cloud_atomic_canned",
104	version => "*",	104		version => "*",
105	},	105		},
106	test_suite => { name => "default_install" },	106		test_suite => { name => "default_install" },
107	},	107		},
108	{	108		{
109	machine => { name => "64bit" },	109		machine => { name => "64bit" },
		110		prio => 40,
		111		product => {
		112		arch => "x86_64",
		113		distri => "fedora",
		114		flavor => "generic_boot",
		115		version => "*",
		116		},
		117		test_suite => { name => "base_selinux" },
		118		},
		119		{
		120		machine => { name => "64bit" },
		121		prio => 40,
		122		product => {
		123		arch => "x86_64",
		124		distri => "fedora",
		125		flavor => "workstation_live",
		126		version => "*",
		127		},
		128		test_suite => { name => "base_selinux" },
		129		},
		130		{
		131		machine => { name => "64bit" },
		132		prio => 40,
		133		product => {
		134		arch => "x86_64",
		135		distri => "fedora",
		136		flavor => "server_dvd",
		137		version => "*",
		138		},
		139		test_suite => { name => "base_selinux" },
		140		},
		141		{
		142		machine => { name => "64bit" },
110	prio => 30,	143		prio => 30,
111	product => {	144		product => {
112	arch => "x86_64",	145		arch => "x86_64",
113	distri => "fedora",	146		distri => "fedora",
114	flavor => "universal",	147		flavor => "universal",
115	version => "*",	148		version => "*",
116	},	149		},
117	test_suite => { name => "package_set_minimal" },	150		test_suite => { name => "package_set_minimal" },
▲ Show 20 Lines • Show All 757 Lines • ▼ Show 20 Line(s)		899	{
875	version => "*",	908		version => "*",
876	}	909		}
877	],	910		],
878	TestSuites => [	911		TestSuites => [
879	{	912		{
880	name => "default_install",	913		name => "default_install",
881	settings => [	914		settings => [
882	{ key => "PACKAGE_SET", value => "default" },	915		{ key => "PACKAGE_SET", value => "default" },
		916		{ key => "STORE_HDD_1", value => "disk_%FLAVOR%_%MACHINE%.qcow2" },
883	],	917		],
884	},	918		},
885	{	919		{
886	name => "package_set_minimal",	920		name => "package_set_minimal",
887	settings => [	921		settings => [
888	{ key => "PACKAGE_SET", value => "minimal" },	922		{ key => "PACKAGE_SET", value => "minimal" },
889	],	923		],
890	},	924		},
▲ Show 20 Lines • Show All 231 Lines • ▼ Show 20 Line(s)
1122	},	1156		},
1123	{	1157		{
1124	name => "package_set_kde",	1158		name => "package_set_kde",
1125	settings => [	1159		settings => [
1126	{ key => "DESKTOP", value => "kde" },	1160		{ key => "DESKTOP", value => "kde" },
1127	{ key => "PACKAGE_SET", value => "kde" },	1161		{ key => "PACKAGE_SET", value => "kde" },
1128	],	1162		],
1129	},	1163		},
		1164		{
		1165		name => "base_selinux",
		1166		settings => [
		1167		{ key => "ENTRYPOINT", value => "base_selinux" },
		1168		{ key => "START_AFTER_TEST", value => "default_install" },
		1169		{ key => "BOOTFROM", value => "c" },
		1170		{ key => "HDD_1", value => "disk_%FLAVOR%_%MACHINE%.qcow2" },
		1171		],
		1172		},
1130	],	1173		],
1131	}	1174		}