templates: drop 'variables', move 'prio' to JobTemplates
ClosedPublic

Authored by adamwill on Dec 15 2015, 11:20 PM.

Details

Summary

this is following a couple of upstream changes I noticeed while
playing with dump_templates. Upstream has completely got rid of
the 'variables' keys from all dicts, and when you run dump_
templates the output does not contain any 'variables' keys, so
it seems reasonable to ditch these entirely (I think it was some
old thing that got subsumed into 'settings'). Also, when you
run dump_templates the 'prio' values come out in JobTemplates,
not in TestSuites; if you look at load_templates there's a bit
marked "we have to migrate the prio from the TestSuite to the
JobTemplate" which does exactly what it sounds like, so it
seems a good idea to move these instead of relying on that to
always be there.

While I had to re-do all the priorities anyway I tried to clean
them up a bit. The idea is roughly this:

10 - 19: most-critical sanity tests (i.e. default_install)
20 - 29: Alpha tests
30 - 39: Beta tests
40 - 49: Final tests
50+ : Optional tests

within each group I ordered 64-bit first, UEFI second, and
32-bit last (usually just as x0 / x1 / x2).

Test Plan

Check that the file is valid and loads correctly,
and that everything works more or less the same except the
order of tests run is a bit different.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to templates: drop 'variables', move 'prio' to JobTemplates.Dec 15 2015, 11:20 PM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
adamwill updated this revision to Diff 1794.Dec 15 2015, 11:30 PM

keep the keys in alphabetical order...

jskladan accepted this revision.Dec 16 2015, 12:38 PM

Awesome, thanks!

This revision is now accepted and ready to land.Dec 16 2015, 12:38 PM
garretraziel accepted this revision.Dec 16 2015, 1:00 PM

Sure, this looks good. I'll just have to adjust D693 before merging it :-).

Setting reasonable priorities was something I was thinking about for a long time. There is just one thing missing - we should change fedora-openqa-schedule in a way that it will report test as soon as it passes - that way, having correct priorities will make more sense.

This revision was automatically updated to reflect the committed changes.