removing deprecated method in cli create_instance and small fix for image find
ClosedPublic
Actions

Authored by tflink on Dec 8 2015, 7:31 PM.

Details

Reviewers

Commits

Summary

switched out deprecated method in create_instance and fixed a small format issue in image.py

Test Plan

tested image list, instance create/stop/destroy locally, everything works

Repository

rTCLOUD testcloud

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

tflink retitled this revision from to removing deprecated method in cli create_instance and small fix for image find.Dec 8 2015, 7:31 PM

tflink updated this object.

tflink edited the test plan for this revision. (Show Details)

tflink added a reviewer: mkrizek.

tflink added a subscriber: roshi.

This revision is now accepted and ready to land.Dec 8 2015, 7:35 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			testcloud/cli.py (2 lines)
M			testcloud/image.py (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1768	860dee8		Dec 8 2015, 7:31 PM	★	★
Diff 2	1769	860dee8	Commit rTCLOUD7295b34dfdbbd5529545b86b4946c89a196e3a7a	Dec 8 2015, 7:38 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
14f374012cbb	aaf4b22d6cf1	f7a537994b5f	Tim Flink	fixing small issue with format args in find_image	Dec 8 2015, 7:29 PM
f7a537994b5f	5fd4f2e28aa6	860dee8887ea	Tim Flink	removing deprecated method in cli create_instance (Show More…)	Dec 8 2015, 7:24 PM

Show First 20 Lines • Show All 87 Lines • ▼ Show 20 Line(s)		80	else:
88		88
89	# prepare instance	89		# prepare instance
90	tc_instance.prepare()	90		tc_instance.prepare()
91		91
92	# create instance domain	92		# create instance domain
93	tc_instance.spawn_vm()	93		tc_instance.spawn_vm()
94		94
95	# start created domain	95		# start created domain
96	tc_instance.boot(args.timeout)	96		tc_instance.start(args.timeout)
97		97
98	# find vm ip	98		# find vm ip
99	vm_ip = find_vm_ip(args.name)	99		vm_ip = find_vm_ip(args.name)
100		100
101	# Write ip to file	101		# Write ip to file
102	tc_instance.create_ip_file(vm_ip)	102		tc_instance.create_ip_file(vm_ip)
103	print("The IP of vm {}: {}".format(args.name, vm_ip))	103		print("The IP of vm {}: {}".format(args.name, vm_ip))
104		104
▲ Show 20 Lines • Show All 233 Lines • Show Last 20 Lines

Show All 25 Lines
26		26
27		27
28	def list_images():	28	def list_images():
29	"""List the images currently downloaded and available on the system	29	"""List the images currently downloaded and available on the system
30		30
31	:returns: list of images currently available	31	:returns: list of images currently available
32	"""	32	"""
33		33
34	image_dir = '{}/{}'.format(config_data.STORE_DIR)	34	image_dir = config_data.STORE_DIR
35	images = os.listdir(image_dir)	35	images = os.listdir(image_dir)
36		36
37	return images	37	return images
38		38
39		39
40	def find_image(name, uri=None):	40	def find_image(name, uri=None):
41	"""Find an image matching a given name and optionally, a uri	41	"""Find an image matching a given name and optionally, a uri
42		42
▲ Show 20 Lines • Show All 172 Lines • Show Last 20 Lines