check if testsuite in TESTSUITES
ClosedPublic

Authored by adamwill on Dec 5 2015, 6:50 PM.

Details

Summary

The current code assumes every openqa test will have an entry
in TESTSUITES and breaks if it doesn't. All tests *should* have
entries, but it's susceptible to going wrong (as the tests
are in a different git repo so we have to sync the commits
carefully) and it is at least possible we might add tests to
openQA that don't match anything in the matrices, at least right
away. So instead of blowing up the report process with a
KeyError if the testsuite isn't there, just log a warning and
continue.

NOTE: this actually goes with D679: I want to add the N-1 upgrade tests now, but they aren't in the matrices yet and won't be until at least after we discuss it at Monday's meeting. So it seemed smarter to add this check than to add an empty entry to TESTSUITES, especially since I've seen this blow up before.
Test Plan

Set things up so there's an openQA test without a
TESTSUITES entry, run a report, and check that instead of
crashing, the reporter logs a warning and continues.

Diff Detail

Repository
rOPENQA fedora_openqa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to check if testsuite in TESTSUITES.Dec 5 2015, 6:50 PM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
garretraziel accepted this revision.Dec 7 2015, 2:00 PM

Looks OK

This revision is now accepted and ready to land.Dec 7 2015, 2:00 PM
This revision was automatically updated to reflect the committed changes.