Use datagrepper to fetch jobs
ClosedPublic

Authored by mkrizek on Nov 30 2015, 2:19 PM.

Details

Test Plan

Ran fedmsg-hub, fedmsgs came all the way to the StreamTrigger.
Ran python cli.py -s 1448496000 -e 1448534412 (supports also -d). Worked.
Ran python cli.py -f jobs.csv (supports also -d). Worked.

Diff Detail

Repository
rTRGR taskotron-trigger
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkrizek retitled this revision from to Cleanups.Nov 30 2015, 2:19 PM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added a reviewer: tflink.
mkrizek updated this revision to Diff 1728.Nov 30 2015, 2:27 PM
  • Cleanup
  • Use datagrepper to fetch jobs instead of jobs.csv
mkrizek retitled this revision from Cleanups to Use datagrepper to fetch jobs instead of jobs.csv.Nov 30 2015, 2:28 PM
mkrizek edited the test plan for this revision. (Show Details)
tflink requested changes to this revision.Nov 30 2015, 3:18 PM

I don't see any issues in the code but I'd like to see datagrepper support in addition to csv files and maintaining the ability to log jobs to csv. It's an easy way to see what's going on at the trigger level and when fedmsgs have triggered job scheduling

This revision now requires changes to proceed.Nov 30 2015, 3:18 PM
mkrizek updated this revision to Diff 1735.Dec 1 2015, 1:59 PM

Use jobs file as well

mkrizek retitled this revision from Use datagrepper to fetch jobs instead of jobs.csv to Use datagrepper to fetch jobs.Dec 2 2015, 9:18 AM
mkrizek edited the test plan for this revision. (Show Details)
mkrizek updated this revision to Diff 1748.Dec 4 2015, 6:07 PM

Fix tests

tflink accepted this revision.Dec 7 2015, 6:31 PM
This revision is now accepted and ready to land.Dec 7 2015, 6:31 PM
This revision was automatically updated to reflect the committed changes.