Differential D662

Copy all config files on a minion
ClosedPublic
Actions

Authored by mkrizek on Nov 24 2015, 2:34 PM.

Details

Reviewers
lbrabec
kparal
tflink
jskladan
Maniphest Tasks
T654: depcheck is using outside-of-Fedora-infra repos which causes timeouts and crashes
Commits
rLTRNc5cc4fc63d2c: Copy all config files on a minion
Summary

This doesn't try to look explicitly for each our config file (taskotron.yaml and yumrepoinfo.conf at the moment) but rather copies the whole config directory. Since there are more possibilities where the files might be stored, we copy all dirs starting with the one with the least priority and then overwrite with those with higher priority. This is rather naive solution but scales better if we decide to add additional config files in the future. Thoughts?

Test Plan

Config files were copied and overwritten according to the priority.

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkrizek retitled this revision from to Copy all config files on a minion.Nov 24 2015, 2:34 PM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added reviewers: tflink, kparal, jskladan, lbrabec.
jskladan accepted this revision.Nov 24 2015, 2:47 PM
This revision is now accepted and ready to land.Nov 24 2015, 2:47 PM
tflink accepted this revision.Nov 24 2015, 4:45 PM
Closed by commit rLTRNc5cc4fc63d2c: Copy all config files on a minion (authored by mkrizek). · Explain WhyNov 25 2015, 9:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mlibtaskotron/minion.py (7 lines)

Diff 1718

View Options

libtaskotron/minion.py

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Line(s)49 def _prepare_task(self):
54 # FIXME remove this once the vm code is done 54​ # FIXME remove this once the vm code is done
55 self.ssh.cmd('curl -o /etc/yum.repos.d/tflink-taskotron-fedora-f23.repo ' 55​ self.ssh.cmd('curl -o /etc/yum.repos.d/tflink-taskotron-fedora-f23.repo '
56 'http://copr-fe.cloud.fedoraproject.org/coprs/tflink/taskotron/' 56​ 'http://copr-fe.cloud.fedoraproject.org/coprs/tflink/taskotron/'
57 'repo/fedora-23/tflink-taskotron-fedora-23.repo') 57​ 'repo/fedora-23/tflink-taskotron-fedora-23.repo')
58 # FIXME this should only need libtaskotron-core T651 58​ # FIXME this should only need libtaskotron-core T651
59 # libtaskotron-fedora should be installed as a check dep 59​ # libtaskotron-fedora should be installed as a check dep
60 self.ssh.install_pkgs('libtaskotron-core, libtaskotron-fedora') 60​ self.ssh.install_pkgs('libtaskotron-core, libtaskotron-fedora')
61 61​
62 # configure libtaskotron 62​ # Copy config files. Go through CONF_DIRS in reversed order to preserve priority.
63 if config.get_config().config_filename: 63​ for config_dir in reversed(config.CONF_DIRS):
64 self.ssh.put_file(config.get_config().config_filename, '/etc/taskotron/taskotron.yaml') 64​ if os.path.exists(config_dir):
65​ self.ssh.put_dir(config_dir, '/etc/taskotron/')
65 66​
66 # create needed dirs 67​ # create needed dirs
67 self.ssh.mkdir(self.taskdir) 68​ self.ssh.mkdir(self.taskdir)
68 69​
69 # patch remote libtaskotron if needed (for dev, shouldn't be used in production) 70​ # patch remote libtaskotron if needed (for dev, shouldn't be used in production)
70 if self.arg_data['patch'] is not None: 71​ if self.arg_data['patch'] is not None:
71 self.ssh.put_file(os.path.abspath(self.arg_data['patch']), '%s/%s' % ( 72​ self.ssh.put_file(os.path.abspath(self.arg_data['patch']), '%s/%s' % (
72 self.taskdir, self.arg_data['patch'])) 73​ self.taskdir, self.arg_data['patch']))
▲ Show 20 Lines • Show All 113 Lines • Show Last 20 Lines