Differential D657

Remove unused dependencies
ClosedPublic
Actions

Authored by mkrizek on Nov 20 2015, 11:26 AM.

Details

Reviewers
lbrabec
kparal
tflink
jskladan
Maniphest Tasks
T653: small fixes for libtaskotron spec file
Commits
rLTRNda8d427950c6: Remove unused dependencies
Test Plan

doit chainbuild

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkrizek retitled this revision from to Remove unused dependencies.Nov 20 2015, 11:26 AM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added reviewers: tflink, kparal, jskladan, lbrabec.
tflink accepted this revision.Nov 21 2015, 12:15 AM

This change is fine by me but it looks like I forgot to move koji and mash to be build deps of libtaskotron-fedora. Not that it makes a huge difference given the way this package is built but it'd fit better conceptually - can you move those when you make this change?

Also, please bump the revision and update the changelog if that was genuinely fortgotten

This revision is now accepted and ready to land.Nov 21 2015, 12:15 AM
Closed by commit rLTRNda8d427950c6: Remove unused dependencies (authored by mkrizek). · Explain WhyNov 22 2015, 9:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mlibtaskotron.spec (12 lines)
Mreadme.rst (2 lines)

Diff 1710

View Options

libtaskotron.spec

1# sitelib for noarch packages, sitearch for others (remove the unneeded one) 1​# sitelib for noarch packages, sitearch for others (remove the unneeded one)
2%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} 2​%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")}
3%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} 3​%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
4 4​
5Name: libtaskotron 5​Name: libtaskotron
6Version: 0.4.5 6​Version: 0.4.5
7Release: 1%{?dist} 7​Release: 2%{?dist}
8Summary: Taskotron Support Library 8​Summary: Taskotron Support Library
9 9​
10License: GPLv3 10​License: GPLv3
11URL: https://bitbucket.org/fedoraqa/libtaskotron 11​URL: https://bitbucket.org/fedoraqa/libtaskotron
12Source0: http://qadevel.fedoraproject.org/releases/%{name}/%{name}-%{version}.tar.gz 12​Source0: http://qadevel.fedoraproject.org/releases/%{name}/%{name}-%{version}.tar.gz
13 13​
14BuildArch: noarch 14​BuildArch: noarch
15 15​
16# sorted alphabetically 16​# sorted alphabetically
17Requires: libtaskotron-config = %{version}-%{release} 17​Requires: libtaskotron-config = %{version}-%{release}
18Requires: libtaskotron-core = %{version}-%{release} 18​Requires: libtaskotron-core = %{version}-%{release}
19Requires: libtaskotron-fedora = %{version}-%{release} 19​Requires: libtaskotron-fedora = %{version}-%{release}
20Requires: libtaskotron-disposable = %{version}-%{release} 20​Requires: libtaskotron-disposable = %{version}-%{release}
21 21​
22%description 22​%description
23Libtaskotron is a support library for running taskotron tasks. The top level libtaskotron package is a meta-package which will install all sub-packages 23​Libtaskotron is a support library for running taskotron tasks. The top level libtaskotron package is a meta-package which will install all sub-packages
24 24​
25%package -n libtaskotron-core 25​%package -n libtaskotron-core
26Summary: The minimal, core parts of libtaskotron 26​Summary: The minimal, core parts of libtaskotron
27 27​
28Requires: libtaskotron-config = %{version}-%{release} 28​Requires: libtaskotron-config = %{version}-%{release}
29Requires: pyOpenSSL ​
30Requires: python-pycurl ​
31Requires: python-setuptools 29​Requires: python-setuptools
32Requires: python-urlgrabber 30​Requires: python-urlgrabber
33Requires: PyYAML >= 3.11 31​Requires: PyYAML >= 3.11
34Requires: resultsdb_api >= 1.2.1 32​Requires: resultsdb_api >= 1.2.1
35BuildRequires: koji ​
36BuildRequires: mash ​
37BuildRequires: pytest >= 2.6.4 33​BuildRequires: pytest >= 2.6.4
38BuildRequires: python-devel 34​BuildRequires: python-devel
39BuildRequires: python-dingus >= 0.3.4 35​BuildRequires: python-dingus >= 0.3.4
40BuildRequires: python-mock >= 1.0.1 36​BuildRequires: python-mock >= 1.0.1
41BuildRequires: python-setuptools 37​BuildRequires: python-setuptools
42BuildRequires: python-urlgrabber 38​BuildRequires: python-urlgrabber
43BuildRequires: PyYAML >= 3.11 39​BuildRequires: PyYAML >= 3.11
44BuildRequires: resultsdb_api >= 1.2.1 40​BuildRequires: resultsdb_api >= 1.2.1
Show All 15 Lines
60Requires: dnf >= 0.6.4 56​Requires: dnf >= 0.6.4
61Requires: koji 57​Requires: koji
62Requires: libtaskotron-core = %{version}-%{release} 58​Requires: libtaskotron-core = %{version}-%{release}
63Requires: mash 59​Requires: mash
64Requires: python-fedora >= 0.5.5 60​Requires: python-fedora >= 0.5.5
65Requires: python-hawkey >= 0.4.13-1 61​Requires: python-hawkey >= 0.4.13-1
66Requires: python-munch >= 2.0.2 62​Requires: python-munch >= 2.0.2
67Requires: rpm-python 63​Requires: rpm-python
64​BuildRequires: koji
65​BuildRequires: mash
68BuildRequires: python-fedora >= 0.5.5 66​BuildRequires: python-fedora >= 0.5.5
69BuildRequires: python-hawkey >= 0.4.13-1 67​BuildRequires: python-hawkey >= 0.4.13-1
70BuildRequires: python-munch >= 2.0.2 68​BuildRequires: python-munch >= 2.0.2
71 69​
72%description -n libtaskotron-fedora 70​%description -n libtaskotron-fedora
73Module for libtaskotron which contains all functionality which is fedora-only 71​Module for libtaskotron which contains all functionality which is fedora-only
74 72​
75%package -n libtaskotron-disposable 73​%package -n libtaskotron-disposable
▲ Show 20 Lines • Show All 72 Lines • ▼ Show 20 Line(s)
148%dir %{python_sitelib}/libtaskotron/ext/fedora 146​%dir %{python_sitelib}/libtaskotron/ext/fedora
149%{python_sitelib}/libtaskotron/ext/fedora/* 147​%{python_sitelib}/libtaskotron/ext/fedora/*
150 148​
151%files -n libtaskotron-disposable 149​%files -n libtaskotron-disposable
152%dir %{python_sitelib}/libtaskotron/ext/disposable 150​%dir %{python_sitelib}/libtaskotron/ext/disposable
153%{python_sitelib}/libtaskotron/ext/disposable/* 151​%{python_sitelib}/libtaskotron/ext/disposable/*
154 152​
155%changelog 153​%changelog
154​* Fri Nov 20 2015 Martin Krizek <mkrizek@redhat.com> - 0.4.5-2
155​- Require the exact same version of subpackages
156​- Remove unused deps
157​
156* Thu Nov 19 2015 Martin Krizek <mkrizek@redhat.com> - 0.4.5-1 158​* Thu Nov 19 2015 Martin Krizek <mkrizek@redhat.com> - 0.4.5-1
157- Do not fail when copying a task from cwd (D656) 159​- Do not fail when copying a task from cwd (D656)
158- We need -core not -disposable on disposable clients (D652) 160​- We need -core not -disposable on disposable clients (D652)
159- Don't require -disposable in -core (D652) 161​- Don't require -disposable in -core (D652)
160 162​
161* Thu Nov 12 2015 Martin Krizek <mkrizek@redhat.com> - 0.4.4-1 163​* Thu Nov 12 2015 Martin Krizek <mkrizek@redhat.com> - 0.4.4-1
162- add %files for libtaskotron meta-package so it's actually built 164​- add %files for libtaskotron meta-package so it's actually built
163- make imageurl configurable 165​- make imageurl configurable
▲ Show 20 Lines • Show All 149 Lines • Show Last 20 Lines
View Options

readme.rst

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Line(s)42Once the copr repo is available, install the necessary packages::
43 43​
44 sudo yum install \ 44​ sudo yum install \
45 createrepo \ 45​ createrepo \
46 gcc \ 46​ gcc \
47 git \ 47​ git \
48 koji \ 48​ koji \
49 libtaskotron-config \ 49​ libtaskotron-config \
50 mash \ 50​ mash \
51 pyOpenSSL \ ​
52 python-doit \ 51​ python-doit \
53 python-hawkey \ 52​ python-hawkey \
54 python-pip \ 53​ python-pip \
55 python-pycurl \ ​
56 python-rpmfluff \ 54​ python-rpmfluff \
57 python-urlgrabber \ 55​ python-urlgrabber \
58 python-virtualenv \ 56​ python-virtualenv \
59 rpm-build \ 57​ rpm-build \
60 rpm-python 58​ rpm-python
61 59​
62If you have not yet cloned the repository, do it now:: 60​If you have not yet cloned the repository, do it now::
63 61​
▲ Show 20 Lines • Show All 150 Lines • Show Last 20 Lines