Use bare host as taskotron client with multiple buildslaves
ClosedPublic

Authored by mkrizek on Nov 11 2015, 3:10 PM.

Details

Reviewers
tflink
Test Plan

Will be tested once playbooks are run.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
mkrizek retitled this revision from to Use bare host as taskotron client with multiple buildslaves.Nov 11 2015, 3:10 PM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added a reviewer: tflink.
mkrizek added a project: infrastructure.
tflink requested changes to this revision.Nov 11 2015, 5:35 PM

looks good for the most part, one concern about ssh keys, though

roles/taskotron/taskotron-client/templates/settings.py.testcloud.j2
30

Doesn't this need to be filled out for ssh access?

This revision now requires changes to proceed.Nov 11 2015, 5:35 PM
mkrizek added inline comments.Nov 11 2015, 11:08 PM
roles/taskotron/taskotron-client/templates/settings.py.testcloud.j2
30

Wow, I wonder what happened here with the diff. Yeah, it's supposed to be "ssh-authorized-keys: {{ buildslave_pubkey }}".

mkrizek updated this revision to Diff 1681.Nov 12 2015, 11:46 AM

Fixing botched diff. Sorry about that.

tflink accepted this revision.Nov 19 2015, 1:04 AM

Hasn't this been pushed to the infra repo already? Either way, LGTM

This revision is now accepted and ready to land.Nov 19 2015, 1:04 AM
mkrizek closed this revision.Nov 19 2015, 8:10 AM