Differential D636

Login as user in console every time
ClosedPublic
Actions

Authored by jskladan on Nov 3 2015, 1:01 PM.

Details

Reviewers
adamwill
garretraziel
Maniphest Tasks
T639: Remove QA:Testcase_Anaconda_user_creation from all test that don't really test it
Commits
rOPENQATESTS2e1dc5877b33: Login as user in console every time
Summary

Instead of removing the QA:Testcase_Anaconda_user_creation from all
the testsuites, make OpenQA login in console (as user) each time.

Test Plan

none

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jskladan retitled this revision from to Login as user in console every time.Nov 3 2015, 1:01 PM
jskladan updated this object.
jskladan edited the test plan for this revision. (Show Details)
jskladan added reviewers: garretraziel, adamwill.
garretraziel accepted this revision.Nov 3 2015, 1:47 PM

Yup, works OK.

This revision is now accepted and ready to land.Nov 3 2015, 1:47 PM
adamwill accepted this revision.Nov 3 2015, 4:02 PM

sure, I guess.

Closed by commit rOPENQATESTS2e1dc5877b33: Login as user in console every time (authored by Josef Skladanka <jskladan@redhat.com>). · Explain WhyNov 4 2015, 9:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mtests/_console_wait_login.pm (4 lines)

Diff 1662

View Options

tests/_console_wait_login.pm

1use base "fedorabase"; 1​use base "fedorabase";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6 my $self = shift; 6​ my $self = shift;
7 7​
8 # If KICKSTART is set, then the wait_time needs to 8​ # If KICKSTART is set, then the wait_time needs to
9 # consider the install time 9​ # consider the install time
10 my $wait_time = get_var("KICKSTART") ? 1800 : 300; 10​ my $wait_time = get_var("KICKSTART") ? 1800 : 300;
11 11​
12 # Reboot and wait for the text login 12​ # Reboot and wait for the text login
13 assert_screen "text_console_login", $wait_time; 13​ assert_screen "text_console_login", $wait_time;
14 14​
15 if (get_var("USER_LOGIN") && get_var("USER_PASSWORD")) { 15​ $self->console_login(user=>get_var("USER_LOGIN", "test"), password=>get_var("USER_PASSWORD", "weakpassword"));
16 $self->console_login(user=>get_var("USER_LOGIN"), password=>get_var("USER_PASSWORD")); ​
17 } ​
18 if (get_var("ROOT_PASSWORD")) { 16​ if (get_var("ROOT_PASSWORD")) {
19 $self->console_login(user=>"root", password=>get_var("ROOT_PASSWORD")); 17​ $self->console_login(user=>"root", password=>get_var("ROOT_PASSWORD"));
20 } 18​ }
21} 19​}
22 20​
23sub test_flags { 21​sub test_flags {
24 # without anything - rollback to 'lastgood' snapshot if failed 22​ # without anything - rollback to 'lastgood' snapshot if failed
25 # 'fatal' - whole test suite is in danger if this fails 23​ # 'fatal' - whole test suite is in danger if this fails
26 # 'milestone' - after this test succeeds, update 'lastgood' 24​ # 'milestone' - after this test succeeds, update 'lastgood'
27 # 'important' - if this fails, set the overall state to 'fail' 25​ # 'important' - if this fails, set the overall state to 'fail'
28 return { fatal => 1, milestone => 1 }; 26​ return { fatal => 1, milestone => 1 };
29} 27​}
30 28​
311; 29​1;
32 30​
33# vim: set sw=4 et: 31​# vim: set sw=4 et: