Differential D620

use lowercase $VERSION for upgrade version check
ClosedPublic
Actions

Authored by adamwill on Oct 15 2015, 11:55 PM.

Details

Reviewers
garretraziel
jskladan
Commits
rOPENQATESTS2f1216c3b0a0: use lowercase $VERSION for upgrade version check
Summary

For Rawhide, the text in os-release-fedora is 'rawhide' not
'Rawhide', so lc the $VERSION value when checking. For other
releases it's digits, so the lc won't change anything - lc('23')
is '23'.

Test Plan

Run the Rawhide upgrade tests, they should succeed.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to use lowercase $VERSION for upgrade version check.Oct 15 2015, 11:55 PM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
garretraziel accepted this revision.Oct 16 2015, 11:35 AM

Yup, works OK.

This revision is now accepted and ready to land.Oct 16 2015, 11:35 AM
Closed by commit rOPENQATESTS2f1216c3b0a0: use lowercase $VERSION for upgrade version check (authored by adamwill). · Explain WhyOct 17 2015, 6:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 1624

View Options

tests/upgrade_postinstall_desktop.pm

Show All 13 Lines6sub run {
14 send_key "ret"; 14​ send_key "ret";
15 assert_screen "graphical_login_input"; 15​ assert_screen "graphical_login_input";
16 type_string $password; 16​ type_string $password;
17 send_key "ret"; 17​ send_key "ret";
18 # wait until desktop appears 18​ # wait until desktop appears
19 assert_screen "graphical_desktop_clean", 30; 19​ assert_screen "graphical_desktop_clean", 30;
20 # check an upgrade actually happened (and we can log into a console) 20​ # check an upgrade actually happened (and we can log into a console)
21 $self->root_console(tty=>3); 21​ $self->root_console(tty=>3);
22 $self->check_release(get_var('VERSION')); 22​ $self->check_release(lc(get_var('VERSION')));
23} 23​}
24 24​
25 25​
26sub test_flags { 26​sub test_flags {
27 # without anything - rollback to 'lastgood' snapshot if failed 27​ # without anything - rollback to 'lastgood' snapshot if failed
28 # 'fatal' - whole test suite is in danger if this fails 28​ # 'fatal' - whole test suite is in danger if this fails
29 # 'milestone' - after this test succeeds, update 'lastgood' 29​ # 'milestone' - after this test succeeds, update 'lastgood'
30 # 'important' - if this fails, set the overall state to 'fail' 30​ # 'important' - if this fails, set the overall state to 'fail'
31 return { fatal => 1 }; 31​ return { fatal => 1 };
32} 32​}
33 33​
341; 34​1;
35 35​
36# vim: set sw=4 et: 36​# vim: set sw=4 et:
View Options

tests/upgrade_postinstall_minimal.pm

1use base "installedtest"; 1​use base "installedtest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5 5​
6sub run { 6​sub run {
7 my $self = shift; 7​ my $self = shift;
8 8​
9 # try to login, check whether target release is installed 9​ # try to login, check whether target release is installed
10 $self->boot_to_login_screen(); 10​ $self->boot_to_login_screen();
11 $self->root_console(tty=>3); 11​ $self->root_console(tty=>3);
12 $self->check_release(get_var('VERSION')); 12​ $self->check_release(lc(get_var('VERSION')));
13} 13​}
14 14​
15 15​
16sub test_flags { 16​sub test_flags {
17 # without anything - rollback to 'lastgood' snapshot if failed 17​ # without anything - rollback to 'lastgood' snapshot if failed
18 # 'fatal' - whole test suite is in danger if this fails 18​ # 'fatal' - whole test suite is in danger if this fails
19 # 'milestone' - after this test succeeds, update 'lastgood' 19​ # 'milestone' - after this test succeeds, update 'lastgood'
20 # 'important' - if this fails, set the overall state to 'fail' 20​ # 'important' - if this fails, set the overall state to 'fail'
21 return { fatal => 1 }; 21​ return { fatal => 1 };
22} 22​}
23 23​
241; 24​1;
25 25​
26# vim: set sw=4 et: 26​# vim: set sw=4 et: