Merge disposable-develop into develop
ClosedPublic

Authored by mkrizek on Oct 13 2015, 7:25 AM.

Details

Test Plan

N/A

Diff Detail

Repository
rLTRN libtaskotron
Branch
disposable-develop
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 276
Build 276: arc lint + arc unit
mkrizek retitled this revision from to Merge disposable-develop into develop.Oct 13 2015, 7:25 AM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added reviewers: tflink, kparal, jskladan, lbrabec.
This revision is now accepted and ready to land.Oct 13 2015, 9:52 AM
lbrabec accepted this revision.Oct 13 2015, 12:13 PM

Besides the comment, it seems to be okay...

libtaskotron.spec
112–129

This probably shouldn't replace change log of disposable branch, but interleave it according to date? I'm not sure about the versions, though.

kparal accepted this revision.Oct 14 2015, 11:21 AM

Macro panda: Well, that was unexpected. Happy panda says ACK.

docs/source/conf.py
54–56

Let's bump to 0.4.0.

libtaskotron.spec
6

Bump

112–129

Let's add a single entry - "merge disposable branch to add option to execute the task in a throwaway client" - with today's date.

libtaskotron/__init__.py
7

Bump

libtaskotron/minion.py
20

I would say on its own instead of separately, correct my English if I'm wrong.

readme.rst
91

Please change the tests to tasks.

tflink accepted this revision.Oct 14 2015, 11:51 AM

Minor nits but overall, looks good

docs/source/conf.py
54–56

yeah, that was my intention when we released this stuff. whether we do that now or right before we merge into master - either way is fine by me

libtaskotron.spec
112–129

the rpm changelog from the 0.3.10x packages isn't really important and I kinda figured it would be thrown away - definitely less important than what's already in develop.

libtaskotron/executor.py
47

superfluous newline for single line docstring

libtaskotron/minion.py
47

superfluous newline

mkrizek closed this revision.Oct 14 2015, 12:54 PM