Fix db schema so it works on sqlite and postgres
ClosedPublic
Actions

Authored by mkrizek on Apr 18 2014, 1:29 PM.

Details

Reviewers

tflink
jskladan

Maniphest Tasks

Commits

Summary

Fixes T134

Test Plan

Works for me, functional tests will follow in another review request

Lint

Lint Skipped

Unit

Unit Tests Skipped

Looks good to me. Glad to hear that the simple fix was enough in this case

Closed by commit rRSDBba16b5c0e56c (authored by @mkrizek).

			Path
M			resultsdb/models/results.py (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	166	2477266		Apr 18 2014, 1:29 PM	★	★
Diff 2	179	2477266	Commit rRSDBba16b5c0e56c2a03c23f6f8d9268593f7704ee38	Apr 18 2014, 1:30 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
68510168c4ab	bcb7b3e924c0	2477266fdddc	Martin Krizek	Fix db schema so it works on sqlite and postgres (Show More…)	Apr 18 2014, 1:22 PM

	Status	Author	Revision
	Closed	mkrizek	D62 Add API functional tests
	Closed	mkrizek	D61 Fix db schema so it works on sqlite and postgres

Show All 35 Lines
36	# DO NOT FORGET TO UPDATE SERIALIZERS AFTER CHANGING STRUCTURE	36	# DO NOT FORGET TO UPDATE SERIALIZERS AFTER CHANGING STRUCTURE
37	#	37	#
38	# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!	38	# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
39		39
40	class Job(db.Model, DBSerialize):	40	class Job(db.Model, DBSerialize):
41		41
42	id = db.Column(db.Integer, primary_key = True)	42	id = db.Column(db.Integer, primary_key = True)
43	status = db.Column(db.Enum(*JOB_STATUS, name='jobstatus'))	43	status = db.Column(db.Enum(*JOB_STATUS, name='jobstatus'))
44	start_time = db.Column(db.DateTime, default = 0)	44	start_time = db.Column(db.DateTime)
45	end_time = db.Column(db.DateTime, default = 0)	45	end_time = db.Column(db.DateTime)
46	ref_url = db.Column(db.Text)	46	ref_url = db.Column(db.Text)
47	name = db.Column(db.Text)	47	name = db.Column(db.Text)
48		48
49	results = db.relation('Result', backref = 'job') #, lazy = False)	49	results = db.relation('Result', backref = 'job') #, lazy = False)
50		50
51	def __init__(self, status = 'SCHEDULED', ref_url = None, name = None):	51	def __init__(self, status = 'SCHEDULED', ref_url = None, name = None):
52	self.status = status	52	self.status = status
53	self.ref_url = ref_url	53	self.ref_url = ref_url
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines