Differential D592

fix KDE x11_start_program needle, add Gnome needle
ClosedPublic
Actions

Authored by garretraziel on Sep 16 2015, 1:55 PM.

Details

Reviewers
adamwill
jskladan
Commits
rOPENQATESTS533dd806e2f2: fix KDE x11_start_program needle, add Gnome needle
Summary

This fixes x11_start_program on KDE. alt-f2 dialog
showed up too late (sleep 3 wasn't enough), so I changed it to
assert_screen and added KDE and Gnome run command dialogs.

ENV-LANGUAGE was also badly set, so I changed that.

Test Plan

run KDE and Gnome live tests.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
garretraziel retitled this revision from to fix KDE x11_start_program needle, add Gnome needle.Sep 16 2015, 1:55 PM
garretraziel updated this object.
garretraziel edited the test plan for this revision. (Show Details)
garretraziel added reviewers: adamwill, jskladan.
adamwill accepted this revision.Sep 16 2015, 5:24 PM

sure, looks fine. I guess you could remove or edit the TODO now, since we've taken screenshots for two desktops now ;)

(the point of the TODO was that the sleep was only ever meant to be a quick hack, and taking screenshots was the 'right' way to do it).

This revision is now accepted and ready to land.Sep 16 2015, 5:24 PM
Closed by commit rOPENQATESTS533dd806e2f2: fix KDE x11_start_program needle, add Gnome needle (authored by garretraziel). · Explain WhySep 17 2015, 7:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 1544

View Options

lib/fedoradistribution.pm

Show All 20 Lines
21sub init() { 21​sub init() {
22 my ($self) = @_; 22​ my ($self) = @_;
23 23​
24 $self->SUPER::init(); 24​ $self->SUPER::init();
25} 25​}
26 26​
27sub x11_start_program($$$) { 27​sub x11_start_program($$$) {
28 my ($self, $program, $timeout, $options) = @_; 28​ my ($self, $program, $timeout, $options) = @_;
29 # TODO: take screenshots of every goddamn 'run command' dialog in ​
30 # every goddamn desktop and keep them updated forever ​
31 send_key "alt-f2"; 29​ send_key "alt-f2";
32 sleep 3; 30​ assert_screen "desktop_runner";
33 type_string $program; 31​ type_string $program;
34 wait_idle 5; # because of KDE dialog - SUSE guys are doing the same! 32​ wait_idle 5; # because of KDE dialog - SUSE guys are doing the same!
35 send_key "ret", 1; 33​ send_key "ret", 1;
36} 34​}
37 35​
381; 36​1;
39# vim: set sw=4 et: 37​# vim: set sw=4 et:
View Options

needles/gnome_desktop_runner.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "xpos": 356,
5​ "ypos": 356,
6​ "width": 74,
7​ "height": 37,
8​ "type": "match"
9​ }
10​ ],
11​ "properties": [],
12​ "tags": [
13​ "ENV-DESKTOP-gnome",
14​ "ENV-FLAVOR-workstation_live",
15​ "ENV-LANGUAGE-ALL",
16​ "desktop_runner"
17​ ]
18​}
19​No newline at end of file
View Options

needles/gnome_desktop_runner.png

  • This binary file was added.
View Options

needles/graphical_login_sddm.json

1{ 1​{
2 "tags": [ 2​ "tags": [
3 "graphical_login", 3​ "graphical_login",
4 "ENV-DESKTOP-kde", 4​ "ENV-DESKTOP-kde",
5 "ENV-DISTRI-fedora", 5​ "ENV-LANGUAGE-ENGLISH",
6 "ENV-INSTLANG-en_US", ​
7 "ENV-FLAVOR-kde_live" 6​ "ENV-FLAVOR-kde_live"
8 ], 7​ ],
9 "properties": [], 8​ "properties": [],
10 "area": [ 9​ "area": [
11 { 10​ {
12 "xpos": 7, 11​ "xpos": 7,
13 "ypos": 7, 12​ "ypos": 7,
14 "width": 54, 13​ "width": 54,
Show All 13 Lines
View Options

needles/kde_desktop_runner.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "xpos": 307,
5​ "ypos": 3,
6​ "width": 93,
7​ "height": 29,
8​ "type": "match"
9​ }
10​ ],
11​ "tags": [
12​ "desktop_runner",
13​ "ENV-DESKTOP-kde",
14​ "ENV-LANGUAGE-ALL",
15​ "ENV-FLAVOR-kde_live"
16​ ],
17​ "properties": []
18​}
View Options

needles/kde_desktop_runner.png

  • This binary file was added.