revise language tag handling to be easier to use (T617)
ClosedPublic
Actions

Authored by adamwill on Sep 16 2015, 12:55 AM.

Details

Reviewers

garretraziel
jskladan

Commits

rOPENQATESTSb97c019ae92f: revise language tag handling to be easier to use (T617)

Summary

T617 makes some good points about the language tags; this is my
suggestion for an improvement. It requires a bit of cleverness
in unregister_prefix_tags(), but the upshot is that you don't
need to know to set any special tags when creating needles, a
needle with no language-related tags will be considered as valid
for all languages. You have to explicitly add LANGUAGE- tag(s)
to a needle for the language filtering to 'kick in' in any way.
If a needle has at least one LANGUAGE- tag, it will be filtered
unless it has the appropriate tag for the job's specified
language (default is still 'english').

With this approach, only needles which we specifically want to
*only* match their tagged language(s) need the tags, so we can
drop all those -ALL tags.

We're using LANGUAGE- instead of ENV-LANGUAGE- now because the
ENV- tag names denote tags that are treated slightly specially
by openQA, and this is not one. We cannot cleanly use
ENV-INSTLANG because openQA has a hardwired default of 'en_US'
for that.

Test Plan

Check both English and French tests still work as
intended.

Diff Detail

Repository

rOPENQATESTS os-autoinst-distri-fedora

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

adamwill retitled this revision from to revise language tag handling to be easier to use (T617).Sep 16 2015, 12:55 AM

adamwill updated this object.

adamwill edited the test plan for this revision. (Show Details)

adamwill added reviewers: jskladan, garretraziel.

Herald added a subscriber: tflink. · View Herald TranscriptSep 16 2015, 12:55 AM

We really don't need to upper-case the language in the tag name.

jskladan mentioned this in T617: Change the way language-specific needles are handled.Sep 16 2015, 11:36 AM

Add a username check as discussed in T617.

I've tested it and it works. And since it isn't problem with this diff to have no "LANGUAGE" tag, I am OK with merging this. We could use this as it is for a while and then rethink if we had any problems with it.

This revision is now accepted and ready to land.Sep 29 2015, 11:53 AM

Closed by commit rOPENQATESTSb97c019ae92f: revise language tag handling to be easier to use (T617) (authored by adamwill). · Explain WhySep 29 2015, 10:52 PM

This revision was automatically updated to reflect the committed changes.

Very Large Diff

This diff is very large and affects 119 files. You may load each file individually or Show All Files Inline

Revision Contents

			Path
M			README.md (10 lines)
M			main.pm (47 lines)
M			needles/anaconda_error.json (1 line)
M			needles/anaconda_install_destination_delete_all_btn.json (2 lines)
M			needles/anaconda_install_destination_encrypt_data.json (2 lines)
M			needles/anaconda_install_destination_encrypt_data_french.json (2 lines)
M			needles/anaconda_install_destination_pony.json (1 line)
M			needles/anaconda_install_destination_pony_selected.json (1 line)
M			needles/anaconda_install_destination_reclaim_space_btn.json (2 lines)
M			needles/anaconda_install_destination_reclaim_space_delete_btn.json (2 lines)
M			needles/anaconda_install_destination_reclaim_space_first_partition.json (1 line)
M			needles/anaconda_install_destination_reclaim_space_first_partition_ntfs.json (1 line)
M			needles/anaconda_install_destination_reclaim_space_second_partition.json (1 line)
M			needles/anaconda_install_destination_reclaim_space_shrink_btn.json (2 lines)
M			needles/anaconda_install_destination_reclaim_space_shrink_slider.json (1 line)
M			needles/anaconda_install_destination_save_passphrase.json (2 lines)
M			needles/anaconda_install_destination_save_passphrase_french.json (2 lines)
M			needles/anaconda_install_destination_select_disk_1.json (1 line)
M			needles/anaconda_install_destination_select_disk_2.json (1 line)
M			needles/anaconda_install_done.json (2 lines)
M			needles/anaconda_install_done_french.json (2 lines)
M			needles/anaconda_install_root_password.json (3 lines)
M			needles/anaconda_install_root_password_screen.json (2 lines)
M			needles/anaconda_install_root_password_screen_french.json (2 lines)
M			needles/anaconda_install_root_password_screen_olddpi.json (2 lines)
M			needles/anaconda_install_source_check_repo_added.json (1 line)
M			needles/anaconda_install_source_check_repo_added_eurlatgr.json (1 line)
M			needles/anaconda_install_source_check_repo_added_inst_repo.json (1 line)
M			needles/anaconda_install_source_http_selected.json (1 line)
M			needles/anaconda_install_source_https_selected.json (1 line)
M			needles/anaconda_install_source_on_the_network.json (2 lines)
M			needles/anaconda_install_source_repo_select_mirrorlist.json (2 lines)
A	M		needles/anaconda_install_user_created_french.json (15 lines)
A	M	(bin)	needles/anaconda_install_user_created_french.png
M			needles/anaconda_install_user_creation.json (1 line)
M			needles/anaconda_install_user_creation_make_admin.json (2 lines)
M			needles/anaconda_install_user_creation_make_admin_french.json (2 lines)
M			needles/anaconda_install_user_creation_screen.json (2 lines)
M			needles/anaconda_install_user_creation_screen_french.json (2 lines)
M			needles/anaconda_install_user_creation_screen_olddpi.json (2 lines)
M			needles/anaconda_main_hub_begin_installation.json (2 lines)
M			needles/anaconda_main_hub_begin_installation_french.json (2 lines)
M			needles/anaconda_main_hub_install_destination.json (3 lines)
M			needles/anaconda_main_hub_install_destination_already_done.json (1 line)
M			needles/anaconda_main_hub_installation_source.json (2 lines)
M			needles/anaconda_main_hub_live.json (1 line)
M			needles/anaconda_main_hub_nonlive.json (1 line)
M			needles/anaconda_main_hub_select_packages.json (1 line)
M			needles/anaconda_manual_partitioning.json (2 lines)
M			needles/anaconda_minimal_highlighted.json (2 lines)
M			needles/anaconda_minimal_highlighted_french.json (2 lines)
M			needles/anaconda_minimal_selected.json (2 lines)
M			needles/anaconda_minimal_selected_french.json (2 lines)
M			needles/anaconda_part_accept_changes.json (2 lines)
M			needles/anaconda_part_add_mountpoint.json (2 lines)
M			needles/anaconda_part_automatic.json (2 lines)
M			needles/anaconda_part_delete.json (1 line)
M			needles/anaconda_part_desired_capacity.json (2 lines)
M			needles/anaconda_part_device_type.json (2 lines)
M			needles/anaconda_part_device_type_raid.json (1 line)
M			needles/anaconda_part_fs_ext3.json (1 line)
M			needles/anaconda_part_fs_ext4_preselected.json (1 line)
M			needles/anaconda_part_fs_xfs_preselected.json (1 line)
M			needles/anaconda_part_list_box_boot.json (1 line)
M			needles/anaconda_part_list_box_button.json (1 line)
M			needles/anaconda_part_list_box_root.json (1 line)
M			needles/anaconda_part_list_box_swap.json (1 line)
M			needles/anaconda_part_plus_button.json (1 line)
M			needles/anaconda_part_scheme.json (1 line)
M			needles/anaconda_part_scheme_btrfs.json (1 line)
M			needles/anaconda_part_scheme_lvm.json (1 line)
M			needles/anaconda_part_scheme_lvmthin.json (2 lines)
M			needles/anaconda_part_scheme_standard.json (2 lines)
M			needles/anaconda_part_select_root.json (1 line)
M			needles/anaconda_part_select_root_already_selected.json (1 line)
M			needles/anaconda_part_select_swap.json (1 line)
M			needles/anaconda_part_update_settings.json (2 lines)
M			needles/anaconda_rawhide_accept_fate.json (2 lines)
M			needles/anaconda_rawhide_accept_fate_french.json (2 lines)
M			needles/anaconda_report_btn.json (1 line)
M			needles/anaconda_select_install_lang.json (1 line)
M			needles/anaconda_select_install_lang_continue.json (2 lines)
M			needles/anaconda_select_install_lang_continue_french.json (2 lines)
M			needles/anaconda_select_install_lang_english_filtered.json (4 lines)
M			needles/anaconda_select_install_lang_english_selected.json (2 lines)
M			needles/anaconda_select_install_lang_french_filtered.json (2 lines)
M			needles/anaconda_select_install_lang_french_selected.json (2 lines)
M			needles/anaconda_select_install_lang_input.json (1 line)
M			needles/anaconda_spoke_done.json (2 lines)
M			needles/anaconda_spoke_done_french.json (2 lines)
M			needles/anaconda_spoke_done_olddpi.json (2 lines)
M			needles/anaconda_user_creation_password_input.json (2 lines)
M			needles/anaconda_user_creation_password_input_french.json (2 lines)
M			needles/boot_enter_passphrase.json (1 line)
M			needles/boot_enter_passphrase2.json (1 line)
M			needles/bootloader_bios_live.json (1 line)
M			needles/bootloader_bios_offline.json (1 line)
M			needles/bootloader_uefi.json (1 line)
M			needles/console_command_success.json (1 line)
M			needles/console_command_success2.json (1 line)
M			needles/console_password_required.json (1 line)
M			needles/console_password_required2.json (1 line)
M			needles/console_raid_used.json (1 line)
M			needles/console_two_disks_mounted_lvm.json (1 line)
M			needles/gnome_desktop_clean.json (2 lines)
M			needles/gnome_desktop_runner.json (3 lines)
M			needles/graphical_login_gdm.json (2 lines)
M			needles/graphical_login_gdm_input.json (2 lines)
M			needles/graphical_login_sddm.json (2 lines)
M			needles/kde_desktop_runner.json (1 line)
M			needles/kde_live_anaconda_icon.json (1 line)
M			needles/provided_disk_intact.json (1 line)
M			needles/provided_second_partition_intact.json (1 line)
M			needles/root_logged_in.json (1 line)
M			needles/root_logged_in_biosfont.json (1 line)
M			needles/text_console_login.json (1 line)
M			needles/user_logged_in.json (1 line)
M			needles/workstation_live_initial.json (3 lines)
M			tests/_do_install_and_reboot.pm (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1523	f0f4482		Sep 16 2015, 12:55 AM	★	★
Diff 2	1524	f0f4482	We really don't need to upper-case the language in the tag name.	Sep 16 2015, 1:05 AM	★	★
Diff 3	1556	f0f4482	Add a username check as discussed in T617.	Sep 24 2015, 2:19 AM	★	★
Diff 4	1568	d4ddfe1	Commit rOPENQATESTSb97c019ae92f062119d3540f875b0d172e533c20	Sep 29 2015, 10:52 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
32eeaec651a2	74859e33102f	f0f4482976c4	Adam Williamson	revise language tag handling to be easier to use (T617) (Show More…)	Sep 16 2015, 12:04 AM

revise language tag handling to be easier to use (T617)ClosedPublicActions

Details

Diff Detail

Very Large Diff

Revision Contents

Diff 1568

README.md

main.pm

needles/anaconda_error.json

needles/anaconda_install_destination_delete_all_btn.json

needles/anaconda_install_destination_encrypt_data.json

needles/anaconda_install_destination_encrypt_data_french.json

needles/anaconda_install_destination_pony.json

needles/anaconda_install_destination_pony_selected.json

needles/anaconda_install_destination_reclaim_space_btn.json

needles/anaconda_install_destination_reclaim_space_delete_btn.json

needles/anaconda_install_destination_reclaim_space_first_partition.json

needles/anaconda_install_destination_reclaim_space_first_partition_ntfs.json

needles/anaconda_install_destination_reclaim_space_second_partition.json

needles/anaconda_install_destination_reclaim_space_shrink_btn.json

needles/anaconda_install_destination_reclaim_space_shrink_slider.json

needles/anaconda_install_destination_save_passphrase.json

needles/anaconda_install_destination_save_passphrase_french.json

needles/anaconda_install_destination_select_disk_1.json

needles/anaconda_install_destination_select_disk_2.json

needles/anaconda_install_done.json

needles/anaconda_install_done_french.json

needles/anaconda_install_root_password.json

needles/anaconda_install_root_password_screen.json

needles/anaconda_install_root_password_screen_french.json

needles/anaconda_install_root_password_screen_olddpi.json

needles/anaconda_install_source_check_repo_added.json

needles/anaconda_install_source_check_repo_added_eurlatgr.json

needles/anaconda_install_source_check_repo_added_inst_repo.json

needles/anaconda_install_source_http_selected.json

needles/anaconda_install_source_https_selected.json

needles/anaconda_install_source_on_the_network.json

needles/anaconda_install_source_repo_select_mirrorlist.json

needles/anaconda_install_user_created_french.json

needles/anaconda_install_user_created_french.png

needles/anaconda_install_user_creation.json

needles/anaconda_install_user_creation_make_admin.json

needles/anaconda_install_user_creation_make_admin_french.json

needles/anaconda_install_user_creation_screen.json

needles/anaconda_install_user_creation_screen_french.json

needles/anaconda_install_user_creation_screen_olddpi.json

needles/anaconda_main_hub_begin_installation.json

needles/anaconda_main_hub_begin_installation_french.json

needles/anaconda_main_hub_install_destination.json

needles/anaconda_main_hub_install_destination_already_done.json

needles/anaconda_main_hub_installation_source.json

needles/anaconda_main_hub_live.json

needles/anaconda_main_hub_nonlive.json

needles/anaconda_main_hub_select_packages.json

needles/anaconda_manual_partitioning.json

needles/anaconda_minimal_highlighted.json

needles/anaconda_minimal_highlighted_french.json

needles/anaconda_minimal_selected.json

needles/anaconda_minimal_selected_french.json

needles/anaconda_part_accept_changes.json

needles/anaconda_part_add_mountpoint.json

needles/anaconda_part_automatic.json

needles/anaconda_part_delete.json

needles/anaconda_part_desired_capacity.json

needles/anaconda_part_device_type.json

needles/anaconda_part_device_type_raid.json

needles/anaconda_part_fs_ext3.json

needles/anaconda_part_fs_ext4_preselected.json

needles/anaconda_part_fs_xfs_preselected.json

needles/anaconda_part_list_box_boot.json

needles/anaconda_part_list_box_button.json

needles/anaconda_part_list_box_root.json

needles/anaconda_part_list_box_swap.json

needles/anaconda_part_plus_button.json

needles/anaconda_part_scheme.json

needles/anaconda_part_scheme_btrfs.json

needles/anaconda_part_scheme_lvm.json

needles/anaconda_part_scheme_lvmthin.json

needles/anaconda_part_scheme_standard.json

needles/anaconda_part_select_root.json

revise language tag handling to be easier to use (T617)
ClosedPublic
Actions