Differential D585

Use dnf instead of yum to install packages via ssh
ClosedPublic
Actions

Authored by mkrizek on Sep 15 2015, 9:10 PM.

Details

Reviewers
lbrabec
kparal
tflink
jskladan
Commits
rLTRN7a59bf995c86: Use dnf instead of yum to install packages via ssh
Summary

For future, since we have dnf in dependencies anyway.

Test Plan

Ran rpmlint with --ssh. Worked for me.

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkrizek retitled this revision from to Use dnf instead of yum to install packages via ssh.Sep 15 2015, 9:10 PM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added reviewers: tflink, kparal, jskladan, lbrabec.
tflink accepted this revision.Sep 15 2015, 9:44 PM

This works for the short term but I think we'll want to abstract this away a bit. If we start supporting more than just Fedora, dnf by itself isn't going to work

This revision is now accepted and ready to land.Sep 15 2015, 9:44 PM
kparal accepted this revision.Sep 16 2015, 10:05 AM
Closed by commit rLTRN7a59bf995c86: Use dnf instead of yum to install packages via ssh (authored by mkrizek). · Explain WhySep 16 2015, 11:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 1527

View Options

libtaskotron/remote_exec.py

Show First 20 Lines • Show All 145 Lines • ▼ Show 20 Line(s)122 def cmd(self, cmd):
146 retcode = channel.recv_exit_status() 146​ retcode = channel.recv_exit_status()
147 147​
148 if retcode != 0 and retcode != exitcode_directive.FAILURE: 148​ if retcode != 0 and retcode != exitcode_directive.FAILURE:
149 raise exc.TaskotronRemoteError('Command "%s" on %s@%s exited with code %s' % 149​ raise exc.TaskotronRemoteError('Command "%s" on %s@%s exited with code %s' %
150 (cmd, self.username, self.hostname, retcode)) 150​ (cmd, self.username, self.hostname, retcode))
151 return retcode 151​ return retcode
152 152​
153 def install_pkgs(self, pkgs): 153​ def install_pkgs(self, pkgs):
154 '''Install packages via yum. 154​ '''Install packages via dnf.
155 155​
156 :param list pkgs: A list or a string separated by commas of packages to be installed 156​ :param list pkgs: A list or a string separated by commas of packages to be installed
157 157​
158 :raise TaskotronRemoteError: If the command has non-zero return code 158​ :raise TaskotronRemoteError: If the command has non-zero return code
159 ''' 159​ '''
160 160​
161 if isinstance(pkgs, basestring): 161​ if isinstance(pkgs, basestring):
162 pkgs = pkgs.split(',') 162​ pkgs = pkgs.split(',')
163 163​
164 log.debug('Installing packages on remote host: %s', ','.join(pkgs)) 164​ log.debug('Installing packages on remote host: %s', ','.join(pkgs))
165 self.cmd('yum -y install %s' % ' '.join(pkgs)) 165​ self.cmd('dnf -y install %s' % ' '.join(pkgs))
166 166​
167 def write_file(self, remote_path, data, overwrite=True): 167​ def write_file(self, remote_path, data, overwrite=True):
168 '''Write data to a remote file. 168​ '''Write data to a remote file.
169 169​
170 :param str remote_path: A path to the remote file 170​ :param str remote_path: A path to the remote file
171 :param str data: Data to be written 171​ :param str data: Data to be written
172 :param bool overwrite: Whether to overwrite remote path. Default is True. 172​ :param bool overwrite: Whether to overwrite remote path. Default is True.
173 173​
▲ Show 20 Lines • Show All 138 Lines • Show Last 20 Lines
View Options

testing/test_remote_exec.py

Show First 20 Lines • Show All 221 Lines • ▼ Show 20 Line(s)137class TestRemoteExec(object):
222 222​
223 def test_cmd_failure(self): 223​ def test_cmd_failure(self):
224 with pytest.raises(TaskotronRemoteError): 224​ with pytest.raises(TaskotronRemoteError):
225 self.remote.cmd(STUB_CMD_FALSE) 225​ self.remote.cmd(STUB_CMD_FALSE)
226 226​
227 def test_install_pkgs_str(self): 227​ def test_install_pkgs_str(self):
228 self.remote.cmd = Dingus() 228​ self.remote.cmd = Dingus()
229 self.remote.install_pkgs('libtaskotron,rpmlint') 229​ self.remote.install_pkgs('libtaskotron,rpmlint')
230 assert self.remote.cmd.calls()[0][1][0] == 'yum -y install libtaskotron rpmlint' 230​ assert self.remote.cmd.calls()[0][1][0] == 'dnf -y install libtaskotron rpmlint'
231 231​
232 def test_install_pkgs_list(self): 232​ def test_install_pkgs_list(self):
233 self.remote.cmd = Dingus() 233​ self.remote.cmd = Dingus()
234 self.remote.install_pkgs(['libtaskotron', 'rpmlint']) 234​ self.remote.install_pkgs(['libtaskotron', 'rpmlint'])
235 assert self.remote.cmd.calls()[0][1][0] == 'yum -y install libtaskotron rpmlint' 235​ assert self.remote.cmd.calls()[0][1][0] == 'dnf -y install libtaskotron rpmlint'
236 236​
237 def test_mkdir(self): 237​ def test_mkdir(self):
238 ref_dirname = 'dirname' 238​ ref_dirname = 'dirname'
239 self.remote.cmd = Dingus() 239​ self.remote.cmd = Dingus()
240 self.remote.mkdir(ref_dirname) 240​ self.remote.mkdir(ref_dirname)
241 assert self.remote.cmd.calls()[0][1][0] == 'mkdir -p -m 777 %s' % ref_dirname 241​ assert self.remote.cmd.calls()[0][1][0] == 'mkdir -p -m 777 %s' % ref_dirname
242 242​
243 def test_mkdir_mode(self): 243​ def test_mkdir_mode(self):
244 ref_dirname = 'dirname' 244​ ref_dirname = 'dirname'
245 ref_mode = 644 245​ ref_mode = 644
246 self.remote.cmd = Dingus() 246​ self.remote.cmd = Dingus()
247 self.remote.mkdir(ref_dirname, ref_mode) 247​ self.remote.mkdir(ref_dirname, ref_mode)
248 assert self.remote.cmd.calls()[0][1][0] == 'mkdir -p -m %d %s' % (ref_mode, ref_dirname) 248​ assert self.remote.cmd.calls()[0][1][0] == 'mkdir -p -m %d %s' % (ref_mode, ref_dirname)