Differential D579

needle clean up: no ENV-OFW, remove unused needles
ClosedPublic
Actions

Authored by adamwill on Sep 15 2015, 1:50 AM.

Details

Reviewers
garretraziel
jskladan
Commits
rOPENQATESTSf0f4482976c4: needle clean up: no ENV-OFW, remove unused needles
Summary

This removes a couple of unused needles. password_required
needles were dupes of console_password_required, and no tests
actually use password_required. tmp_failed_proc just isn't
used by anything at all (I think it was at some point used in
fedup tests).

This also drops the ENV-OFW-1 tag from all needles, which I
think got in because someone based a needle on a SUSE needle
which has that tag, then it spread. It's of no use or meaning
in Fedora.

Test Plan

Check all tests still run as normal.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to needle clean up: no ENV-OFW, remove unused needles.Sep 15 2015, 1:50 AM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: garretraziel, jskladan.
jskladan accepted this revision.Sep 15 2015, 8:04 AM
This revision is now accepted and ready to land.Sep 15 2015, 8:04 AM
Closed by commit rOPENQATESTSf0f4482976c4: needle clean up: no ENV-OFW, remove unused needles (authored by adamwill). · Explain WhySep 15 2015, 11:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mneedles/anaconda_install_destination_encrypt_data.json (1 line)
Mneedles/anaconda_install_destination_encrypt_data_french.json (1 line)
Mneedles/anaconda_install_destination_reclaim_space_delete_btn.json (1 line)
Mneedles/anaconda_install_destination_reclaim_space_first_partition.json (1 line)
Mneedles/anaconda_install_destination_reclaim_space_second_partition.json (1 line)
Mneedles/anaconda_install_destination_save_passphrase.json (1 line)
Mneedles/anaconda_install_destination_save_passphrase_french.json (1 line)
Mneedles/anaconda_install_source_check_repo_added.json (1 line)
Mneedles/anaconda_install_source_check_repo_added_eurlatgr.json (1 line)
Mneedles/anaconda_install_source_check_repo_added_inst_repo.json (1 line)
Mneedles/anaconda_install_source_on_the_network.json (1 line)
Mneedles/anaconda_install_source_repo_select_mirrorlist.json (1 line)
Mneedles/anaconda_main_hub_install_destination_already_done.json (1 line)
Mneedles/anaconda_main_hub_installation_source.json (1 line)
Mneedles/anaconda_main_hub_select_packages.json (1 line)
Mneedles/anaconda_select_install_lang_english_selected.json (1 line)
Mneedles/anaconda_select_install_lang_french_selected.json (1 line)
Mneedles/boot_enter_passphrase.json (1 line)
Mneedles/boot_enter_passphrase2.json (1 line)
DMneedles/password_required.json (18 lines)
DM(bin)needles/password_required.png
DMneedles/password_required2.json (18 lines)
DM(bin)needles/password_required2.png
Mneedles/provided_second_partition_intact.json (1 line)
DMneedles/tmp_failed_proc.json (18 lines)
DM(bin)needles/tmp_failed_proc.png

Diff 1522

View Options

needles/anaconda_install_destination_encrypt_data.json

1{ 1​{
2 "tags": [ 2​ "tags": [
3 "anaconda_install_destination_encrypt_data", 3​ "anaconda_install_destination_encrypt_data",
4 "ENV-DISTRI-fedora", 4​ "ENV-DISTRI-fedora",
5 "ENV-LANGUAGE-ENGLISH", 5​ "ENV-LANGUAGE-ENGLISH",
6 "ENV-OFW-1", ​
7 "ENV-FLAVOR-server" 6​ "ENV-FLAVOR-server"
8 ], 7​ ],
9 "area": [ 8​ "area": [
10 { 9​ {
11 "xpos": 20, 10​ "xpos": 20,
12 "ypos": 603, 11​ "ypos": 603,
13 "width": 121, 12​ "width": 121,
14 "height": 21, 13​ "height": 21,
15 "type": "match" 14​ "type": "match"
16 } 15​ }
17 ] 16​ ]
18} 17​}
19No newline at end of file 18​No newline at end of file
View Options

needles/anaconda_install_destination_encrypt_data_french.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "height": 21, 4​ "height": 21,
5 "type": "match", 5​ "type": "match",
6 "width": 152, 6​ "width": 152,
7 "xpos": 19, 7​ "xpos": 19,
8 "ypos": 623 8​ "ypos": 623
9 } 9​ }
10 ], 10​ ],
11 "tags": [ 11​ "tags": [
12 "anaconda_install_destination_encrypt_data", 12​ "anaconda_install_destination_encrypt_data",
13 "ENV-DISTRI-fedora", 13​ "ENV-DISTRI-fedora",
14 "ENV-LANGUAGE-FRENCH", 14​ "ENV-LANGUAGE-FRENCH",
15 "ENV-OFW-1", ​
16 "ENV-FLAVOR-server" 15​ "ENV-FLAVOR-server"
17 ] 16​ ]
18} 17​}
19No newline at end of file 18​No newline at end of file
View Options

needles/anaconda_install_destination_reclaim_space_delete_btn.json

1{ 1​{
2 "tags": [ 2​ "tags": [
3 "anaconda_install_destination_reclaim_space_delete_btn", 3​ "anaconda_install_destination_reclaim_space_delete_btn",
4 "ENV-DISTRI-fedora", 4​ "ENV-DISTRI-fedora",
5 "ENV-LANGUAGE-ENGLISH", 5​ "ENV-LANGUAGE-ENGLISH",
6 "ENV-OFW-1", ​
7 "ENV-FLAVOR-server" 6​ "ENV-FLAVOR-server"
8 ], 7​ ],
9 "area": [ 8​ "area": [
10 { 9​ {
11 "xpos": 108, 10​ "xpos": 108,
12 "ypos": 517, 11​ "ypos": 517,
13 "width": 46, 12​ "width": 46,
14 "height": 21, 13​ "height": 21,
15 "type": "match" 14​ "type": "match"
16 } 15​ }
17 ] 16​ ]
18} 17​}
19No newline at end of file 18​No newline at end of file
View Options

needles/anaconda_install_destination_reclaim_space_first_partition.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "xpos": 15, 4​ "xpos": 15,
5 "ypos": 278, 5​ "ypos": 278,
6 "width": 70, 6​ "width": 70,
7 "height": 24, 7​ "height": 24,
8 "type": "match" 8​ "type": "match"
9 } 9​ }
10 ], 10​ ],
11 "tags": [ 11​ "tags": [
12 "anaconda_install_destination_reclaim_space_first_partition", 12​ "anaconda_install_destination_reclaim_space_first_partition",
13 "ENV-DISTRI-fedora", 13​ "ENV-DISTRI-fedora",
14 "ENV-LANGUAGE-ALL", 14​ "ENV-LANGUAGE-ALL",
15 "ENV-OFW-1", ​
16 "ENV-FLAVOR-server" 15​ "ENV-FLAVOR-server"
17 ] 16​ ]
18} 17​}
View Options

needles/anaconda_install_destination_reclaim_space_second_partition.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "xpos": 11, 4​ "xpos": 11,
5 "ypos": 301, 5​ "ypos": 301,
6 "width": 75, 6​ "width": 75,
7 "height": 25, 7​ "height": 25,
8 "type": "match" 8​ "type": "match"
9 } 9​ }
10 ], 10​ ],
11 "tags": [ 11​ "tags": [
12 "anaconda_install_destination_reclaim_space_second_partition", 12​ "anaconda_install_destination_reclaim_space_second_partition",
13 "ENV-DISTRI-fedora", 13​ "ENV-DISTRI-fedora",
14 "ENV-LANGUAGE-ALL", 14​ "ENV-LANGUAGE-ALL",
15 "ENV-OFW-1", ​
16 "ENV-FLAVOR-server" 15​ "ENV-FLAVOR-server"
17 ] 16​ ]
18} 17​}
View Options

needles/anaconda_install_destination_save_passphrase.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "xpos": 663, 4​ "xpos": 663,
5 "ypos": 515, 5​ "ypos": 515,
6 "width": 147, 6​ "width": 147,
7 "height": 42, 7​ "height": 42,
8 "type": "match" 8​ "type": "match"
9 } 9​ }
10 ], 10​ ],
11 "tags": [ 11​ "tags": [
12 "anaconda_install_destination_save_passphrase", 12​ "anaconda_install_destination_save_passphrase",
13 "ENV-DISTRI-fedora", 13​ "ENV-DISTRI-fedora",
14 "ENV-LANGUAGE-ENGLISH", 14​ "ENV-LANGUAGE-ENGLISH",
15 "ENV-OFW-1", ​
16 "ENV-FLAVOR-server" 15​ "ENV-FLAVOR-server"
17 ] 16​ ]
18} 17​}
19No newline at end of file 18​No newline at end of file
View Options

needles/anaconda_install_destination_save_passphrase_french.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "height": 37, 4​ "height": 37,
5 "type": "match", 5​ "type": "match",
6 "width": 190, 6​ "width": 190,
7 "xpos": 599, 7​ "xpos": 599,
8 "ypos": 526 8​ "ypos": 526
9 } 9​ }
10 ], 10​ ],
11 "tags": [ 11​ "tags": [
12 "anaconda_install_destination_save_passphrase", 12​ "anaconda_install_destination_save_passphrase",
13 "ENV-DISTRI-fedora", 13​ "ENV-DISTRI-fedora",
14 "ENV-LANGUAGE-FRENCH", 14​ "ENV-LANGUAGE-FRENCH",
15 "ENV-OFW-1", ​
16 "ENV-FLAVOR-server" 15​ "ENV-FLAVOR-server"
17 ] 16​ ]
18} 17​}
View Options

needles/anaconda_install_source_check_repo_added.json

1{ 1​{
2 "tags": [ 2​ "tags": [
3 "anaconda_install_source_check_repo_added", 3​ "anaconda_install_source_check_repo_added",
4 "ENV-DISTRI-fedora", 4​ "ENV-DISTRI-fedora",
5 "ENV-LANGUAGE-ALL", 5​ "ENV-LANGUAGE-ALL",
6 "ENV-OFW-1", ​
7 "ENV-FLAVOR-server" 6​ "ENV-FLAVOR-server"
8 ], 7​ ],
9 "area": [ 8​ "area": [
10 { 9​ {
11 "ypos": 17, 10​ "ypos": 17,
12 "height": 14, 11​ "height": 14,
13 "xpos": 102, 12​ "xpos": 102,
14 "type": "match", 13​ "type": "match",
15 "width": 304 14​ "width": 304
16 } 15​ }
17 ] 16​ ]
18} 17​}
View Options

needles/anaconda_install_source_check_repo_added_eurlatgr.json

1{ 1​{
2 "tags": [ 2​ "tags": [
3 "anaconda_install_source_check_repo_added", 3​ "anaconda_install_source_check_repo_added",
4 "ENV-DISTRI-fedora", 4​ "ENV-DISTRI-fedora",
5 "ENV-LANGUAGE-ALL", 5​ "ENV-LANGUAGE-ALL",
6 "ENV-OFW-1", ​
7 "ENV-FLAVOR-server" 6​ "ENV-FLAVOR-server"
8 ], 7​ ],
9 "area": [ 8​ "area": [
10 { 9​ {
11 "ypos": 17, 10​ "ypos": 17,
12 "height": 14, 11​ "height": 14,
13 "xpos": 102, 12​ "xpos": 102,
14 "type": "match", 13​ "type": "match",
15 "width": 304 14​ "width": 304
16 } 15​ }
17 ] 16​ ]
18} 17​}
View Options

needles/anaconda_install_source_check_repo_added_inst_repo.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "xpos": 229, 4​ "xpos": 229,
5 "ypos": 17, 5​ "ypos": 17,
6 "width": 327, 6​ "width": 327,
7 "height": 15, 7​ "height": 15,
8 "type": "match" 8​ "type": "match"
9 } 9​ }
10 ], 10​ ],
11 "tags": [ 11​ "tags": [
12 "anaconda_install_source_check_repo_added", 12​ "anaconda_install_source_check_repo_added",
13 "ENV-DISTRI-fedora", 13​ "ENV-DISTRI-fedora",
14 "ENV-LANGUAGE-ALL", 14​ "ENV-LANGUAGE-ALL",
15 "ENV-OFW-1", ​
16 "ENV-FLAVOR-server" 15​ "ENV-FLAVOR-server"
17 ] 16​ ]
18} 17​}
View Options

needles/anaconda_install_source_on_the_network.json

1{ 1​{
2 "tags": [ 2​ "tags": [
3 "anaconda_install_source_on_the_network", 3​ "anaconda_install_source_on_the_network",
4 "ENV-DISTRI-fedora", 4​ "ENV-DISTRI-fedora",
5 "ENV-LANGUAGE-ENGLISH", 5​ "ENV-LANGUAGE-ENGLISH",
6 "ENV-OFW-1", ​
7 "ENV-FLAVOR-server" 6​ "ENV-FLAVOR-server"
8 ], 7​ ],
9 "area": [ 8​ "area": [
10 { 9​ {
11 "xpos": 58, 10​ "xpos": 58,
12 "ypos": 128, 11​ "ypos": 128,
13 "width": 108, 12​ "width": 108,
14 "height": 20, 13​ "height": 20,
15 "type": "match" 14​ "type": "match"
16 } 15​ }
17 ] 16​ ]
18} 17​}
19No newline at end of file 18​No newline at end of file
View Options

needles/anaconda_install_source_repo_select_mirrorlist.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "xpos": 178, 4​ "xpos": 178,
5 "ypos": 195, 5​ "ypos": 195,
6 "width": 238, 6​ "width": 238,
7 "height": 26, 7​ "height": 26,
8 "type": "match" 8​ "type": "match"
9 } 9​ }
10 ], 10​ ],
11 "tags": [ 11​ "tags": [
12 "anaconda_install_source_repo_select_mirrorlist", 12​ "anaconda_install_source_repo_select_mirrorlist",
13 "ENV-DISTRI-fedora", 13​ "ENV-DISTRI-fedora",
14 "ENV-LANGUAGE-ENGLISH", 14​ "ENV-LANGUAGE-ENGLISH",
15 "ENV-OFW-1", ​
16 "ENV-FLAVOR-server" 15​ "ENV-FLAVOR-server"
17 ] 16​ ]
18} 17​}
19No newline at end of file 18​No newline at end of file
View Options

needles/anaconda_main_hub_install_destination_already_done.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "height": 79, 4​ "height": 79,
5 "type": "match", 5​ "type": "match",
6 "width": 87, 6​ "width": 87,
7 "xpos": 174, 7​ "xpos": 174,
8 "ypos": 458 8​ "ypos": 458
9 } 9​ }
10 ], 10​ ],
11 "tags": [ 11​ "tags": [
12 "anaconda_main_hub_install_destination", 12​ "anaconda_main_hub_install_destination",
13 "ENV-DISTRI-fedora", 13​ "ENV-DISTRI-fedora",
14 "ENV-LANGUAGE-ALL", 14​ "ENV-LANGUAGE-ALL",
15 "ENV-OFW-1", ​
16 "ENV-FLAVOR-server" 15​ "ENV-FLAVOR-server"
17 ] 16​ ]
18} 17​}
View Options

needles/anaconda_main_hub_installation_source.json

1{ 1​{
2 "tags": [ 2​ "tags": [
3 "anaconda_main_hub_installation_source", 3​ "anaconda_main_hub_installation_source",
4 "ENV-DISTRI-fedora", 4​ "ENV-DISTRI-fedora",
5 "ENV-LANGUAGE-ENGLISH", 5​ "ENV-LANGUAGE-ENGLISH",
6 "ENV-OFW-1", ​
7 "ENV-FLAVOR-server" 6​ "ENV-FLAVOR-server"
8 ], 7​ ],
9 "area": [ 8​ "area": [
10 { 9​ {
11 "xpos": 185, 10​ "xpos": 185,
12 "ypos": 347, 11​ "ypos": 347,
13 "width": 72, 12​ "width": 72,
14 "height": 61, 13​ "height": 61,
Show All 12 Lines
View Options

needles/anaconda_main_hub_select_packages.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "height": 58, 4​ "height": 58,
5 "type": "match", 5​ "type": "match",
6 "width": 23, 6​ "width": 23,
7 "xpos": 627, 7​ "xpos": 627,
8 "ypos": 356 8​ "ypos": 356
9 } 9​ }
10 ], 10​ ],
11 "tags": [ 11​ "tags": [
12 "anaconda_main_hub_select_packages", 12​ "anaconda_main_hub_select_packages",
13 "ENV-DISTRI-fedora", 13​ "ENV-DISTRI-fedora",
14 "ENV-LANGUAGE-ALL", 14​ "ENV-LANGUAGE-ALL",
15 "ENV-OFW-1", ​
16 "ENV-FLAVOR-server" 15​ "ENV-FLAVOR-server"
17 ] 16​ ]
18} 17​}
19No newline at end of file 18​No newline at end of file
View Options

needles/anaconda_select_install_lang_english_selected.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "height": 20, 4​ "height": 20,
5 "type": "match", 5​ "type": "match",
6 "width": 169, 6​ "width": 169,
7 "xpos": 603, 7​ "xpos": 603,
8 "ypos": 205 8​ "ypos": 205
9 } 9​ }
10 ], 10​ ],
11 "tags": [ 11​ "tags": [
12 "anaconda_select_install_lang_selected", 12​ "anaconda_select_install_lang_selected",
13 "anaconda_select_install_lang_filtered", 13​ "anaconda_select_install_lang_filtered",
14 "ENV-DISTRI-fedora", 14​ "ENV-DISTRI-fedora",
15 "ENV-LANGUAGE-ENGLISH", 15​ "ENV-LANGUAGE-ENGLISH",
16 "ENV-OFW-1", ​
17 "ENV-FLAVOR-server" 16​ "ENV-FLAVOR-server"
18 ] 17​ ]
19} 18​}
View Options

needles/anaconda_select_install_lang_french_selected.json

1{ 1​{
2 "area": [ 2​ "area": [
3 { 3​ {
4 "height": 20, 4​ "height": 20,
5 "type": "match", 5​ "type": "match",
6 "width": 124, 6​ "width": 124,
7 "xpos": 603, 7​ "xpos": 603,
8 "ypos": 205 8​ "ypos": 205
9 } 9​ }
10 ], 10​ ],
11 "tags": [ 11​ "tags": [
12 "anaconda_select_install_lang_selected", 12​ "anaconda_select_install_lang_selected",
13 "anaconda_select_install_lang_filtered", 13​ "anaconda_select_install_lang_filtered",
14 "ENV-DISTRI-fedora", 14​ "ENV-DISTRI-fedora",
15 "ENV-LANGUAGE-FRENCH", 15​ "ENV-LANGUAGE-FRENCH",
16 "ENV-OFW-1", ​
17 "ENV-FLAVOR-server" 16​ "ENV-FLAVOR-server"
18 ] 17​ ]
19} 18​}
View Options

needles/boot_enter_passphrase.json

1{ 1​{
2 "tags": [ 2​ "tags": [
3 "boot_enter_passphrase", 3​ "boot_enter_passphrase",
4 "ENV-DISTRI-fedora", 4​ "ENV-DISTRI-fedora",
5 "ENV-LANGUAGE-ALL", 5​ "ENV-LANGUAGE-ALL",
6 "ENV-OFW-1", ​
7 "ENV-FLAVOR-server" 6​ "ENV-FLAVOR-server"
8 ], 7​ ],
9 "area": [ 8​ "area": [
10 { 9​ {
11 "xpos": 0, 10​ "xpos": 0,
12 "ypos": 361, 11​ "ypos": 361,
13 "width": 188, 12​ "width": 188,
14 "height": 31, 13​ "height": 31,
15 "type": "match" 14​ "type": "match"
16 } 15​ }
17 ] 16​ ]
18} 17​}
View Options

needles/boot_enter_passphrase2.json

1{ 1​{
2 "tags": [ 2​ "tags": [
3 "boot_enter_passphrase", 3​ "boot_enter_passphrase",
4 "ENV-DISTRI-fedora", 4​ "ENV-DISTRI-fedora",
5 "ENV-LANGUAGE-ALL", 5​ "ENV-LANGUAGE-ALL",
6 "ENV-OFW-1", ​
7 "ENV-FLAVOR-server" 6​ "ENV-FLAVOR-server"
8 ], 7​ ],
9 "area": [ 8​ "area": [
10 { 9​ {
11 "xpos": 0, 10​ "xpos": 0,
12 "ypos": 361, 11​ "ypos": 361,
13 "width": 188, 12​ "width": 188,
14 "height": 31, 13​ "height": 31,
15 "type": "match" 14​ "type": "match"
16 } 15​ }
17 ] 16​ ]
18} 17​}
View Options

needles/password_required.json

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

needles/password_required.png

  • This binary file was deleted.
View Options

needles/password_required2.json

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

needles/password_required2.png

  • This binary file was deleted.
View Options

needles/provided_second_partition_intact.json

1{ 1​{
2 "tags": [ 2​ "tags": [
3 "provided_second_partition_intact", 3​ "provided_second_partition_intact",
4 "ENV-DISTRI-fedora", 4​ "ENV-DISTRI-fedora",
5 "ENV-LANGUAGE-ALL", 5​ "ENV-LANGUAGE-ALL",
6 "ENV-OFW-1", ​
7 "ENV-FLAVOR-server" 6​ "ENV-FLAVOR-server"
8 ], 7​ ],
9 "area": [ 8​ "area": [
10 { 9​ {
11 "xpos": 0, 10​ "xpos": 0,
12 "ypos": 0, 11​ "ypos": 0,
13 "width": 88, 12​ "width": 88,
14 "height": 95, 13​ "height": 95,
15 "type": "match" 14​ "type": "match"
16 } 15​ }
17 ] 16​ ]
18} 17​}
View Options

needles/tmp_failed_proc.json

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

needles/tmp_failed_proc.png

  • This binary file was deleted.