Differential D575

download KDE live images
ClosedPublic
Actions

Authored by garretraziel on Sep 11 2015, 8:24 AM.

Details

Reviewers
adamwill
jskladan
Commits
rOPENQA94a85d84e027: download KDE live images
Summary

This adds KDE live images downloading.

Test Plan

Try to run scheduler on Beta TC1 (TC4 doesn't have
KDE images) and observer that KDE live gets downloaded.

Diff Detail

Repository
rOPENQA fedora_openqa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
garretraziel retitled this revision from to download KDE live images.Sep 11 2015, 8:24 AM
garretraziel updated this object.
garretraziel edited the test plan for this revision. (Show Details)
garretraziel added reviewers: adamwill, jskladan.
garretraziel added a comment.Sep 11 2015, 8:35 AM

I've also installed pylint plugin to my editor so I had to correct some small PEP8 errors ;-)

adamwill accepted this revision.Sep 11 2015, 2:52 PM

Sure, looks fine. I was actually considering making the payloads configurable (via config file) for cases like happyassassin (where I usually want to skip DVDs and lives to save bandwidth), FWIW.

This revision is now accepted and ready to land.Sep 11 2015, 2:52 PM
adamwill added a comment.Sep 11 2015, 2:54 PM
This comment was removed by adamwill.
garretraziel added a comment.Sep 14 2015, 6:51 AM
In D575#10881, @adamwill wrote:

Sure, looks fine. I was actually considering making the payloads configurable (via config file) for cases like happyassassin (where I usually want to skip DVDs and lives to save bandwidth), FWIW.

I think that this is good idea, let's create ticket for that.

Closed by commit rOPENQA94a85d84e027: download KDE live images (authored by garretraziel). · Explain WhySep 14 2015, 6:55 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mfedora_openqa_schedule/schedule.py (14 lines)

Diff 1503

View Options

fedora_openqa_schedule/schedule.py

Show All 37 Lines
38from fedora_openqa_schedule.config import CONFIG 38​from fedora_openqa_schedule.config import CONFIG
39 39​
40logger = logging.getLogger(__name__) 40​logger = logging.getLogger(__name__)
41 41​
42PERSISTENT = "/var/tmp/openqa_watcher.json" 42​PERSISTENT = "/var/tmp/openqa_watcher.json"
43ARCHES = ('x86_64', 'i386') 43​ARCHES = ('x86_64', 'i386')
44# Default value is '/var/lib/openqa/factory/iso/' 44​# Default value is '/var/lib/openqa/factory/iso/'
45ISO_PATH = CONFIG.get('schedule', 'iso-path') 45​ISO_PATH = CONFIG.get('schedule', 'iso-path')
46​# List of all desktops we want to test
47​DESKTOPS = ('workstation', 'kde')
48​
46 49​
47class TriggerException(Exception): 50​class TriggerException(Exception):
48 pass 51​ pass
49 52​
53​
50class WaitError(Exception): 54​class WaitError(Exception):
51 """Raised when we waited for something too long.""" 55​ """Raised when we waited for something too long."""
52 pass 56​ pass
53 57​
58​
54def read_last(): 59​def read_last():
55 """Read last tested version from file.""" 60​ """Read last tested version from file."""
56 logger.debug("reading latest checked version from %s", PERSISTENT) 61​ logger.debug("reading latest checked version from %s", PERSISTENT)
57 result = {} 62​ result = {}
58 try: 63​ try:
59 f = open(PERSISTENT, "r") 64​ f = open(PERSISTENT, "r")
60 json_raw = f.read() 65​ json_raw = f.read()
61 f.close() 66​ f.close()
Show All 33 Lines98def run_openqa_jobs(isoname, flavor, arch, build, force=False):
95 and a version string. **NOTE**: the version passed to OpenQA as 100​ and a version string. **NOTE**: the version passed to OpenQA as
96 BUILD and is parsed back into the 'relval report-auto' arguments 101​ BUILD and is parsed back into the 'relval report-auto' arguments
97 by report_job_results.py; it is expected to be in the form of a 102​ by report_job_results.py; it is expected to be in the form of a
98 3-tuple on which join('_') has been run, and the three elements 103​ 3-tuple on which join('_') has been run, and the three elements
99 will be passed as release, compose and milestone. Returns list of 104​ will be passed as release, compose and milestone. Returns list of
100 job IDs. If force is False, jobs will only be scheduled if there 105​ job IDs. If force is False, jobs will only be scheduled if there
101 are no existing, non-cancelled jobs for the same ISO and flavor. 106​ are no existing, non-cancelled jobs for the same ISO and flavor.
102 """ 107​ """
103 logger.info("sending jobs on OpenQA") 108​ logger.info("sending jobs to openQA")
104 109​
105 # starts OpenQA jobs 110​ # starts OpenQA jobs
106 params = { 111​ params = {
107 'ISO': isoname, 112​ 'ISO': isoname,
108 'DISTRI': 'fedora', 113​ 'DISTRI': 'fedora',
109 'VERSION': build.split('_')[0], 114​ 'VERSION': build.split('_')[0],
110 'FLAVOR': flavor, 115​ 'FLAVOR': flavor,
111 'ARCH': arch, 116​ 'ARCH': arch,
Show All 34 Lines149 if not wiki:
146 return ([], None) 151​ return ([], None)
147 last_versions, json_parsed = read_last() 152​ last_versions, json_parsed = read_last()
148 currev = wiki.current_event 153​ currev = wiki.current_event
149 logger.info("current event: %s", currev.version) 154​ logger.info("current event: %s", currev.version)
150 runarches = [] 155​ runarches = []
151 for arch in ARCHES: 156​ for arch in ARCHES:
152 last_version = last_versions.get(arch, None) 157​ last_version = last_versions.get(arch, None)
153 if last_version and last_version >= currev.sortname: 158​ if last_version and last_version >= currev.sortname:
154 logger.info("skipped: %s: %s is newer or equal to %s", 159​ logger.info("skipped: %s: %s is newer or equal to %s", arch, last_version, currev.sortname)
155 arch, last_version, currev.sortname) ​
156 else: 160​ else:
157 runarches.append(arch) 161​ runarches.append(arch)
158 logger.debug("%s will be tested in version %s", arch, currev.sortname) 162​ logger.debug("%s will be tested in version %s", arch, currev.sortname)
159 json_parsed[arch] = currev.sortname 163​ json_parsed[arch] = currev.sortname
160 164​
161 jobs = [] 165​ jobs = []
162 166​
163 if not runarches: 167​ if not runarches:
▲ Show 20 Lines • Show All 64 Lines • ▼ Show 20 Line(s)226def jobs_from_fedfind(ff_release, arches=None, force=False):
228 """ 232​ """
229 if not arches: 233​ if not arches:
230 arches = ARCHES 234​ arches = ARCHES
231 # Find currently-testable images for our arches. 235​ # Find currently-testable images for our arches.
232 jobs = [] 236​ jobs = []
233 queries = ( 237​ queries = (
234 fedfind.release.Query('imagetype', ('boot', 'live')), 238​ fedfind.release.Query('imagetype', ('boot', 'live')),
235 fedfind.release.Query('arch', arches), 239​ fedfind.release.Query('arch', arches),
236 fedfind.release.Query('payload', ('server', 'generic', 'workstation'))) 240​ fedfind.release.Query('payload', ('server', 'generic') + DESKTOPS))
237 logger.debug("querying fedfind for images") 241​ logger.debug("querying fedfind for images")
238 images = ff_release.find_images(queries) 242​ images = ff_release.find_images(queries)
239 243​
240 if len(images) == 0: 244​ if len(images) == 0:
241 raise TriggerException("no available images") 245​ raise TriggerException("no available images")
242 246​
243 # Now schedule jobs. First, let's get the BUILD value for openQA. 247​ # Now schedule jobs. First, let's get the BUILD value for openQA.
244 build = '_'.join((ff_release.release, ff_release.milestone, ff_release.compose)) 248​ build = '_'.join((ff_release.release, ff_release.milestone, ff_release.compose))
Show All 19 Lines267 for img in okimgs:
264 if img.imagetype == 'dvd': 268​ if img.imagetype == 'dvd':
265 score = 10 269​ score = 10
266 else: 270​ else:
267 score = 1 271​ score = 1
268 if img.payload == 'generic': 272​ if img.payload == 'generic':
269 score += 5 273​ score += 5
270 elif img.payload == 'server': 274​ elif img.payload == 'server':
271 score += 3 275​ score += 3
272 elif img.payload == 'workstation': 276​ elif img.payload in DESKTOPS:
273 score += 1 277​ score += 1
274 if score > bestscore: 278​ if score > bestscore:
275 bestimg = img 279​ bestimg = img
276 bestscore = score 280​ bestscore = score
277 if not bestimg: 281​ if not bestimg:
278 logger.warn("no universal tests image found for %s", arch) 282​ logger.warn("no universal tests image found for %s", arch)
279 continue 283​ continue
280 logger.info("running universal tests for %s with %s", arch, bestimg.desc) 284​ logger.info("running universal tests for %s with %s", arch, bestimg.desc)
Show All 11 Lines