cleaner search with no item specified
ClosedPublic
Actions

Authored by lbrabec on Sep 9 2015, 7:11 AM.

Details

Reviewers

kparal
jskladan

Maniphest Tasks

T611: empty item search in resultsdb creates weird URLs

Commits

rRSFE76822899e6d6: cleaner search with no item specified

Summary

when there is no item specified, item in url is omitted.

Test Plan

manualy tested

Repository

rRSFE resultsdb_frontend

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

lbrabec retitled this revision from to cleaner search with no item specified.Sep 9 2015, 7:11 AM

lbrabec updated this object.

lbrabec edited the test plan for this revision. (Show Details)

Macro doge: very ack such changes

This revision is now accepted and ready to land.Sep 9 2015, 7:25 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			resultsdb_frontend/static/js/search.js (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1471	49502db		Sep 9 2015, 7:11 AM	★	★
Diff 2	1473	49502db	Commit rRSFE76822899e6d6f4906ca5a9079348ada78194f2a1	Sep 9 2015, 7:27 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
11f6f99fd475	a40d922f6f9b	49502dbbedf3	Lukas Brabec	cleaner search with no item specified (Show More…)	Sep 9 2015, 7:09 AM

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 Line(s)		43	$(".popover #searchform").submit(function(e){
45	var query = $(".popover #query").val();	45		var query = $(".popover #query").val();
46	var testcase = $(".popover #testcase").val();	46		var testcase = $(".popover #testcase").val();
47	var type = $(".popover #type").val();	47		var type = $(".popover #type").val();
48	var url = $(".popover #url").val() + "?";	48		var url = $(".popover #url").val() + "?";
49	var outcome = $(".popover #outcome").val();	49		var outcome = $(".popover #outcome").val();
50		50
51	query = query.replace(/\*/g,"%");	51		query = query.replace(/\*/g,"%");
52		52
		53		if(query){
53	if(query.indexOf("%") != -1){	54		if(query.indexOf("%") != -1){
54	//wildcard match	55		//wildcard match
55	url += "item:like=" + query;	56		url += "item:like=" + query;
56	} else {	57		} else {
57	//substring match	58		//substring match
58	url += "item:like=%" + query + "%";	59		url += "item:like=%" + query + "%";
59	}	60		}
		61		}
60		62
61	if(testcase != 0)	63		if(testcase != 0)
62	url += "&testcase_name="+testcase;	64		url += "&testcase_name="+testcase;
63	if(type != 0)	65		if(type != 0)
64	url += "&type="+type;	66		url += "&type="+type;
65	if(outcome)	67		if(outcome)
66	url += "&outcome="+outcome;	68		url += "&outcome="+outcome;
67		69
Show All 17 Lines