Differential D533

runner: inform about artifactsdir at the end
ClosedPublic
Actions

Authored by kparal on Aug 26 2015, 8:48 AM.

Details

Reviewers
lbrabec
Commits
rLTRN513ee894e62d: runner: inform about artifactsdir at the end
Summary

Originally we informed about artifactsdir at the beginning of the
execution. For tasks with lots of output, it made it very hard to find
the task artifacts after execution was complete. This informes about the
directory at the end of execution as well, so that you can simply look
at the last line.

Test Plan

before:

[libtaskotron] 08:39:41 INFO    Execution finished at: 2015-08-26 08:39:41 UTC

after:

[libtaskotron] 08:43:06 INFO    Execution finished at: 2015-08-26 08:43:06 UTC. Task artifacts were saved in: /var/lib/taskotron/artifacts/20150826_084300_184779

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to runner: inform about artifactsdir at the end.Aug 26 2015, 8:48 AM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added a reviewer: lbrabec.
lbrabec accepted this revision.Aug 26 2015, 8:53 AM

LGTM

This revision is now accepted and ready to land.Aug 26 2015, 8:53 AM
Closed by commit rLTRN513ee894e62d: runner: inform about artifactsdir at the end (authored by kparal). · Explain WhyAug 26 2015, 9:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mlibtaskotron/runner.py (5 lines)

Diff 1395

View Options

libtaskotron/runner.py

Show First 20 Lines • Show All 266 Lines • ▼ Show 20 Line(s)244def main():
267 if not task_data: 267​ if not task_data:
268 raise TaskotronYamlError('Input file should not be empty') 268​ raise TaskotronYamlError('Input file should not be empty')
269 269​
270 # run the task 270​ # run the task
271 task_runner = Runner(task_data, arg_data) 271​ task_runner = Runner(task_data, arg_data)
272 task_runner.run() 272​ task_runner.run()
273 273​
274 # finalization 274​ # finalization
275 log.info('Execution finished at: %s', 275​ log.info('Execution finished at: %s. Task artifacts were saved in: %s',
276 datetime.datetime.utcnow().strftime('%Y-%m-%d %H:%M:%S UTC')) 276​ datetime.datetime.utcnow().strftime('%Y-%m-%d %H:%M:%S UTC'),
277​ task_runner.envdata['artifactsdir'])
277 278​
278 if task_runner.exitcode: 279​ if task_runner.exitcode:
279 log.info("Exiting with exit status %d (this behavior was requested by exitcode directive)" 280​ log.info("Exiting with exit status %d (this behavior was requested by exitcode directive)"
280 % task_runner.exitcode) 281​ % task_runner.exitcode)
281 sys.exit(task_runner.exitcode) 282​ sys.exit(task_runner.exitcode)