Differential D523

fix missing dict key with Bodhi2
ClosedPublic
Actions

Authored by kparal on Aug 21 2015, 1:49 PM.

Details

Reviewers
lbrabec
tflink
jskladan
Maniphest Tasks
T558: Test libtaskotron against bodhi 2.0
Commits
rUPGRe0bf2713c9cb: fix missing dict key with Bodhi2
Summary

The returned dicts changed, adjust for new structure.

Test Plan

tested manually, works now

Diff Detail

Repository
rUPGR task-upgradepath
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to fix missing dict key with Bodhi2.Aug 21 2015, 1:49 PM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added reviewers: jskladan, lbrabec, tflink.
kparal added a task: T558: Test libtaskotron against bodhi 2.0.
tflink accepted this revision.Aug 21 2015, 1:51 PM
This revision is now accepted and ready to land.Aug 21 2015, 1:51 PM
Closed by commit rUPGRe0bf2713c9cb: fix missing dict key with Bodhi2 (authored by kparal). · Explain WhyAug 21 2015, 1:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mupgradepath.py (2 lines)

Diff 1369

View Options

upgradepath.py

Show First 20 Lines • Show All 271 Lines • ▼ Show 20 Line(s)233 def check_pending_request(self, pkgname, tag_tuple):
272 272​
273 # we found our update. this first one should be the most recent one 273​ # we found our update. this first one should be the most recent one
274 # (yuck, not optimal! but we use that approach everywhere anyway) 274​ # (yuck, not optimal! but we use that approach everywhere anyway)
275 update = requests['updates'][0] 275​ update = requests['updates'][0]
276 276​
277 # this update may contain several builds (different packages). we need 277​ # this update may contain several builds (different packages). we need
278 # to find that one that contains our package name 278​ # to find that one that contains our package name
279 builds = [build for build in update['builds'] 279​ builds = [build for build in update['builds']
280 if build['package']['name'] == pkgname] 280​ if rpm_utils.rpmformat(build['nvr'], 'n') == pkgname]
281 # there should be exactly one such build 281​ # there should be exactly one such build
282 assert len(builds) == 1, ('Bodhi update should not contain multiple ' 282​ assert len(builds) == 1, ('Bodhi update should not contain multiple '
283 'builds of the same package: %s' % builds) 283​ 'builds of the same package: %s' % builds)
284 build = builds[0] 284​ build = builds[0]
285 285​
286 # now we need to query Koji to get all relevant information about this 286​ # now we need to query Koji to get all relevant information about this
287 # build (like epoch) 287​ # build (like epoch)
288 koji_build = self.koji.session.getBuild(build['nvr']) 288​ koji_build = self.koji.session.getBuild(build['nvr'])
▲ Show 20 Lines • Show All 404 Lines • Show Last 20 Lines