Differential D521

adjusting sync for change of name in bodhi api data
ClosedPublic
Actions

Authored by tflink on Aug 20 2015, 4:04 PM.

Details

Reviewers
roshi
Maniphest Tasks
T557: Test blockerbugs with new bodhi client libraries
Commits
rBLKRc02dc6f4985c: adjusting sync for change of name in bodhi api data
Summary

bz_id changed to bug_id in the bodhi2 api data, changed sync to make that work

Test Plan

unit tests adjusted and pass, local sync works

Diff Detail

Repository
rBLKR blockerbugs
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tflink retitled this revision from to adjusting sync for change of name in bodhi api data.Aug 20 2015, 4:04 PM
tflink updated this object.
tflink edited the test plan for this revision. (Show Details)
tflink added a reviewer: roshi.
roshi accepted this revision.Aug 20 2015, 8:14 PM

Looks good to me.

This revision is now accepted and ready to land.Aug 20 2015, 8:14 PM
Closed by commit rBLKRc02dc6f4985c: adjusting sync for change of name in bodhi api data (authored by tflink). · Explain WhyAug 20 2015, 8:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 1365

View Options

blockerbugs/util/update_sync.py

Show First 20 Lines • Show All 75 Lines • ▼ Show 20 Line(s)75 else:
76 urlsufix = str(update.updateid) 76​ urlsufix = str(update.updateid)
77 updateinfo['url'] = '%s%s' % (bodhi_baseurl, urlsufix) 77​ updateinfo['url'] = '%s%s' % (bodhi_baseurl, urlsufix)
78 78​
79 updateinfo['date_submitted'] = datetime.strptime(update.date_submitted, 79​ updateinfo['date_submitted'] = datetime.strptime(update.date_submitted,
80 '%Y-%m-%d %H:%M:%S') 80​ '%Y-%m-%d %H:%M:%S')
81 updateinfo['bugs'] = [] 81​ updateinfo['bugs'] = []
82 if len(update.bugs) > 0: 82​ if len(update.bugs) > 0:
83 for buginfo in update.bugs: 83​ for buginfo in update.bugs:
84 updateinfo['bugs'].append(buginfo.bz_id) 84​ updateinfo['bugs'].append(buginfo.bug_id)
85 85​
86 return updateinfo 86​ return updateinfo
87 87​
88 def get_update(self, envr): 88​ def get_update(self, envr):
89 updates = self.bodhi_interface.query(package=envr) 89​ updates = self.bodhi_interface.query(package=envr)
90 return self.extract_information(updates['updates'][0]) 90​ return self.extract_information(updates['updates'][0])
91 91​
92 def is_watched_bug(self, bugnum): 92​ def is_watched_bug(self, bugnum):
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines
View Options

testing/test_updatesync_extract_information.py

Show All 15 Lines8basicupdate = Bunch(
16 notes=u'Fix live install mounting /home and /boot and swap', 16​ notes=u'Fix live install mounting /home and /boot and swap',
17 request=None, stable_karma=3, status=u'testing', 17​ request=None, stable_karma=3, status=u'testing',
18 submitter=u'bcl', 18​ submitter=u'bcl',
19 title=u'anaconda-18.6.8-1.fc18', 19​ title=u'anaconda-18.6.8-1.fc18',
20 type=u'bugfix', 20​ type=u'bugfix',
21 karma=1, 21​ karma=1,
22 unstable_karma=-3, 22​ unstable_karma=-3,
23 updateid=u'FEDORA-2012-13902', 23​ updateid=u'FEDORA-2012-13902',
24 bugs=[Bunch(bz_id=856836, parent=False, security=False, 24​ bugs=[Bunch(bug_id=856836, parent=False, security=False,
25 title=u'/etc/fstab is not written correctly after live install (F18 Alpha RC2+)')], 25​ title=u'/etc/fstab is not written correctly after live install (F18 Alpha RC2+)')],
26 builds=[Bunch(nvr=u'anaconda-18.6.8-1.fc18', 26​ builds=[Bunch(nvr=u'anaconda-18.6.8-1.fc18',
27 package=Bunch( 27​ package=Bunch(
28 committers=[u'anaconda-maint', u'dlehman', u'jkeating', 28​ committers=[u'anaconda-maint', u'dlehman', u'jkeating',
29 u'bcl', u'clumens', u'rvykydal', u'akozumpl', 29​ u'bcl', u'clumens', u'rvykydal', u'akozumpl',
30 u'pjones', 30​ u'pjones',
31 u'katzj', 31​ u'katzj',
32 u'dcantrel'], 32​ u'dcantrel'],
▲ Show 20 Lines • Show All 151 Lines • ▼ Show 20 Line(s)181 def test_extract_date_pushed_pending_testing(self):
184 self.testupdate.date_pushed = None 184​ self.testupdate.date_pushed = None
185 185​
186 updateinfo = self.testsync.extract_information(self.testupdate) 186​ updateinfo = self.testsync.extract_information(self.testupdate)
187 187​
188 assert updateinfo['date_pushed_testing'] == None 188​ assert updateinfo['date_pushed_testing'] == None
189 assert updateinfo['date_pushed_stable'] == None 189​ assert updateinfo['date_pushed_stable'] == None
190 190​
191 def test_extract_bug_single(self): 191​ def test_extract_bug_single(self):
192 ref_bugs = [Bunch(bz_id=123456, parent=False, security=False, 192​ ref_bugs = [Bunch(bug_id=123456, parent=False, security=False,
193 title=u'First wonderful test bug') 193​ title=u'First wonderful test bug')
194 ] 194​ ]
195 self.testupdate.bugs = ref_bugs 195​ self.testupdate.bugs = ref_bugs
196 196​
197 updateinfo = self.testsync.extract_information(self.testupdate) 197​ updateinfo = self.testsync.extract_information(self.testupdate)
198 198​
199 assert len(updateinfo['bugs']) == 1 199​ assert len(updateinfo['bugs']) == 1
200 assert updateinfo['bugs'][0] == 123456 200​ assert updateinfo['bugs'][0] == 123456
201 201​
202 def test_extract_bug_multiple(self): 202​ def test_extract_bug_multiple(self):
203 ref_bugs = [ 203​ ref_bugs = [
204 Bunch(bz_id=123456, parent=False, security=False, 204​ Bunch(bug_id=123456, parent=False, security=False,
205 title=u'First wonderful test bug'), 205​ title=u'First wonderful test bug'),
206 Bunch(bz_id=234567, parent=False, security=False, 206​ Bunch(bug_id=234567, parent=False, security=False,
207 title=u'Second wonderful test bug'), 207​ title=u'Second wonderful test bug'),
208 Bunch(bz_id=345678, parent=False, security=False, 208​ Bunch(bug_id=345678, parent=False, security=False,
209 title=u'Third wonderful test bug'), 209​ title=u'Third wonderful test bug'),
210 ] 210​ ]
211 self.testupdate.bugs = ref_bugs 211​ self.testupdate.bugs = ref_bugs
212 212​
213 updateinfo = self.testsync.extract_information(self.testupdate) 213​ updateinfo = self.testsync.extract_information(self.testupdate)
214 214​
215 assert len(updateinfo['bugs']) == 3 215​ assert len(updateinfo['bugs']) == 3
216 assert 123456 in updateinfo['bugs'] 216​ assert 123456 in updateinfo['bugs']
Show All 17 Lines
View Options

testing/testfunc_update_sync.py

Show All 18 Lines18base_update = Bunch(
19 title=u'anaconda-18.6.8-1.fc18', 19​ title=u'anaconda-18.6.8-1.fc18',
20 date_pushed=u'2012-09-13 16:40:28', 20​ date_pushed=u'2012-09-13 16:40:28',
21 date_submitted=u'2012-09-12 23:43:04', 21​ date_submitted=u'2012-09-12 23:43:04',
22 karma=1, 22​ karma=1,
23 request=u'testing', 23​ request=u'testing',
24 stable_karma=3, 24​ stable_karma=3,
25 status=u'pending', 25​ status=u'pending',
26 bugs=[ 26​ bugs=[
27 Bunch(bz_id=2000, parent=False, security=False, 27​ Bunch(bug_id=2000, parent=False, security=False,
28 title=u'bodhi bug 2000 title'), 28​ title=u'bodhi bug 2000 title'),
29 Bunch(bz_id=2001, parent=False, security=False, 29​ Bunch(bug_id=2001, parent=False, security=False,
30 title=u'bodhi bug 2001 title')], 30​ title=u'bodhi bug 2001 title')],
31 release=Bunch(dist_tag=u'f99', id_prefix=u'FEDORA', locked=True, 31​ release=Bunch(dist_tag=u'f99', id_prefix=u'FEDORA', locked=True,
32 long_name=u'Fedora 99', name=u'F99'), 32​ long_name=u'Fedora 99', name=u'F99'),
33 updateid='FEDORA-2012-13902', 33​ updateid='FEDORA-2012-13902',
34) 34​)
35 35​
36update_for_bugs_2000_2001 = copy(base_update) 36​update_for_bugs_2000_2001 = copy(base_update)
37 37​
38update1_for_bug_3000 = copy(base_update) 38​update1_for_bug_3000 = copy(base_update)
39update1_for_bug_3000.update({ 39​update1_for_bug_3000.update({
40 'title': u'libreport-2.1.3-2.fc19', 40​ 'title': u'libreport-2.1.3-2.fc19',
41 'bugs': [Bunch(bz_id=3000, parent=False, security=False, 41​ 'bugs': [Bunch(bug_id=3000, parent=False, security=False,
42 title=u"anaconda can't report traceback to bugzilla")], 42​ title=u"anaconda can't report traceback to bugzilla")],
43}) 43​})
44 44​
45update2_for_bug_3000 = copy(base_update) 45​update2_for_bug_3000 = copy(base_update)
46update2_for_bug_3000.update({ 46​update2_for_bug_3000.update({
47 'title': u'jboss-servlet-2.5-api-1.0.1-3.fc19,resteasy-2.3.2-12.fc19', 47​ 'title': u'jboss-servlet-2.5-api-1.0.1-3.fc19,resteasy-2.3.2-12.fc19',
48 'bugs': [Bunch(bz_id=3000, parent=False, security=False, 48​ 'bugs': [Bunch(bug_id=3000, parent=False, security=False,
49 title=u"anaconda can't report traceback to bugzilla")], 49​ title=u"anaconda can't report traceback to bugzilla")],
50}) 50​})
51 51​
52 52​
53class FakeBodhiInterface(object): 53​class FakeBodhiInterface(object):
54 updates = { 54​ updates = {
55 ('f99', '2000'): [update_for_bugs_2000_2001], 55​ ('f99', '2000'): [update_for_bugs_2000_2001],
56 ('f99', '2001'): [update_for_bugs_2000_2001], 56​ ('f99', '2001'): [update_for_bugs_2000_2001],
▲ Show 20 Lines • Show All 154 Lines • Show Last 20 Lines