Differential D508

fixing job_id reference in create_results. Fixes T572
ClosedPublic
Actions

Authored by tflink on Aug 18 2015, 7:00 PM.

Details

Reviewers
roshi
Maniphest Tasks
T572: job_id is referenced in 'create_result()' before assignment
Commits
rRSDBf2d660d6c0cc: fixing job_id reference in create_results. Fixes T572
Summary

simple fix to allow results submission to actually work

Test Plan

unit tests pass, cursory funcitonal tests locally on my dev machine work

Diff Detail

Repository
rRSDB resultsdb
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tflink retitled this revision from to fixing job_id reference in create_results. Fixes T572.Aug 18 2015, 7:00 PM
tflink updated this object.
tflink edited the test plan for this revision. (Show Details)
tflink added a reviewer: roshi.
roshi accepted this revision.Aug 18 2015, 7:15 PM

Looks good to me.

This revision is now accepted and ready to land.Aug 18 2015, 7:15 PM
Closed by commit rRSDBf2d660d6c0cc: fixing job_id reference in create_results. Fixes T572 (authored by tflink). · Explain WhyAug 20 2015, 2:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mresultsdb/controllers/api_v1.py (4 lines)

Diff 1351

View Options

resultsdb/controllers/api_v1.py

Show First 20 Lines • Show All 546 Lines • ▼ Show 20 Line(s)546 try:
547 args = RP['create_result'].parse_args() 547​ args = RP['create_result'].parse_args()
548 except JSONBadRequest as error: 548​ except JSONBadRequest as error:
549 return jsonify({"message": "Malformed JSON data"}), error.code 549​ return jsonify({"message": "Malformed JSON data"}), error.code
550 except HTTPException as error: 550​ except HTTPException as error:
551 return jsonify(error.data), error.code 551​ return jsonify(error.data), error.code
552 552​
553 553​
554 try: 554​ try:
555 job_id = int(job_id) 555​ # since job_id is in the posted data here, get it from the processed
556​ # input args
557​ job_id = int(args['job_id'])
556 except ValueError: # uuid can not be parsed to int 558​ except ValueError: # uuid can not be parsed to int
557 q = Job.query.filter_by(uuid = job_id) 559​ q = Job.query.filter_by(uuid = job_id)
558 else: # id was int -> filter by id 560​ else: # id was int -> filter by id
559 q = Job.query.filter_by(id = job_id) 561​ q = Job.query.filter_by(id = job_id)
560 562​
561 # Fail early, if the job does not exist 563​ # Fail early, if the job does not exist
562 try: 564​ try:
563 job = q.one() 565​ job = q.one()
▲ Show 20 Lines • Show All 172 Lines • Show Last 20 Lines