Differential D503

add a 'no swap partition' test
ClosedPublic
Actions

Authored by adamwill on Aug 16 2015, 1:26 PM.

Details

Reviewers
garretraziel
jskladan
Commits
rOPENQATESTS95bc2657fb48: add a 'no swap partition' test
Summary

since we did this live at Flock today, I figured I'd tidy it
up and submit it. This is an 'optional' test, but some people
do run this way so it'd be nice to have it. This adds another
little helper method in anacondatest.pm, for deleting partitions,
which works much like the others added in previous commits.

Test Plan

Schedule a test run, see if the test runs and works.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to add a 'no swap partition' test.Aug 16 2015, 1:26 PM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: garretraziel, jskladan.
jskladan accepted this revision.Aug 16 2015, 2:50 PM
This revision is now accepted and ready to land.Aug 16 2015, 2:50 PM
garretraziel accepted this revision.Aug 17 2015, 8:36 AM

Yep, it LGTM. You didn't add any reviewer to D504, but I assume that I should review it too :-).

Closed by commit rOPENQATESTS95bc2657fb48: add a 'no swap partition' test (authored by adamwill). · Explain WhyAug 19 2015, 9:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 1348

View Options

lib/anacondatest.pm

Show First 20 Lines • Show All 123 Lines • ▼ Show 20 Line(s)121sub custom_change_fs {
124 assert_and_click "anaconda_part_select_$part"; 124​ assert_and_click "anaconda_part_select_$part";
125 assert_and_click "anaconda_part_fs"; 125​ assert_and_click "anaconda_part_fs";
126 # Move the mouse away from the menu 126​ # Move the mouse away from the menu
127 mouse_set(10, 10); 127​ mouse_set(10, 10);
128 assert_and_click "anaconda_part_fs_$fs"; 128​ assert_and_click "anaconda_part_fs_$fs";
129 assert_and_click "anaconda_part_update_settings"; 129​ assert_and_click "anaconda_part_update_settings";
130} 130​}
131 131​
132​sub custom_delete_part {
133​ my ($self, $part) = @_;
134​ return if not $part;
135​ assert_and_click "anaconda_part_select_$part";
136​ assert_and_click "anaconda_part_delete";
137​}
138​
1321; 139​1;
133 140​
134# vim: set sw=4 et: 141​# vim: set sw=4 et:
View Options

needles/anaconda_part_delete.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 20,
5​ "type": "match",
6​ "width": 55,
7​ "xpos": 65,
8​ "ypos": 625
9​ }
10​ ],
11​ "tags": [
12​ "anaconda_part_delete",
13​ "ENV-DISTRI-fedora",
14​ "ENV-INSTLANG-en_US",
15​ "ENV-FLAVOR-generic_boot"
16​ ]
17​}
View Options

needles/anaconda_part_delete.png

  • This binary file was added.
View Options

needles/anaconda_part_select_swap.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 19,
5​ "type": "match",
6​ "width": 48,
7​ "xpos": 51,
8​ "ypos": 245
9​ }
10​ ],
11​ "properties": [],
12​ "tags": [
13​ "anaconda_part_select_swap",
14​ "ENV-DISTRI-fedora",
15​ "ENV-INSTLANG-en_US",
16​ "ENV-FLAVOR-generic_boot"
17​ ]
18​}
View Options

needles/anaconda_part_select_swap.png

  • This binary file was added.
View Options

templates

Show First 20 Lines • Show All 198 Lines • ▼ Show 20 Line(s)8 JobTemplates => [
199 { 199​ {
200 machine => { name => "64bit" }, 200​ machine => { name => "64bit" },
201 product => { 201​ product => {
202 arch => "x86_64", 202​ arch => "x86_64",
203 distri => "fedora", 203​ distri => "fedora",
204 flavor => "universal", 204​ flavor => "universal",
205 version => "*", 205​ version => "*",
206 }, 206​ },
207​ test_suite => { name => "server_no_swap" },
208​ },
209​ {
210​ machine => { name => "64bit" },
211​ product => {
212​ arch => "x86_64",
213​ distri => "fedora",
214​ flavor => "universal",
215​ version => "*",
216​ },
207 test_suite => { name => "server_kickstart_hdd" }, 217​ test_suite => { name => "server_kickstart_hdd" },
208 }, 218​ },
209 { 219​ {
210 machine => { name => "64bit" }, 220​ machine => { name => "64bit" },
211 product => { 221​ product => {
212 arch => "x86_64", 222​ arch => "x86_64",
213 distri => "fedora", 223​ distri => "fedora",
214 flavor => "universal", 224​ flavor => "universal",
▲ Show 20 Lines • Show All 214 Lines • ▼ Show 20 Line(s)
429 { 439​ {
430 machine => { name => "32bit" }, 440​ machine => { name => "32bit" },
431 product => { 441​ product => {
432 arch => "i386", 442​ arch => "i386",
433 distri => "fedora", 443​ distri => "fedora",
434 flavor => "universal", 444​ flavor => "universal",
435 version => "*", 445​ version => "*",
436 }, 446​ },
447​ test_suite => { name => "server_no_swap" },
448​ },
449​ {
450​ machine => { name => "32bit" },
451​ product => {
452​ arch => "i386",
453​ distri => "fedora",
454​ flavor => "universal",
455​ version => "*",
456​ },
437 test_suite => { name => "server_kickstart_hdd" }, 457​ test_suite => { name => "server_kickstart_hdd" },
438 }, 458​ },
439 { 459​ {
440 machine => { name => "32bit" }, 460​ machine => { name => "32bit" },
441 product => { 461​ product => {
442 arch => "i386", 462​ arch => "i386",
443 distri => "fedora", 463​ distri => "fedora",
444 flavor => "universal", 464​ flavor => "universal",
▲ Show 20 Lines • Show All 288 Lines • ▼ Show 20 Line(s)751 {
733 prio => 16, 753​ prio => 16,
734 settings => [ 754​ settings => [
735 { key => "PARTITIONING", value => "custom_lvmthin" }, 755​ { key => "PARTITIONING", value => "custom_lvmthin" },
736 { key => "ROOT_PASSWORD", value => "weakpassword" }, 756​ { key => "ROOT_PASSWORD", value => "weakpassword" },
737 ], 757​ ],
738 variables => "", 758​ variables => "",
739 }, 759​ },
740 { 760​ {
741 name => "server_kickstart_hdd", 761​ name => "server_no_swap",
742 prio => 17, 762​ prio => 17,
743 settings => [ 763​ settings => [
764​ { key => "PARTITIONING", value => "custom_no_swap" },
765​ { key => "ROOT_PASSWORD", value => "weakpassword" },
766​ ],
767​ variables => "",
768​ },
769​ {
770​ name => "server_kickstart_hdd",
771​ prio => 18,
772​ settings => [
744 { key => "KICKSTART", value => "1" }, 773​ { key => "KICKSTART", value => "1" },
745 { key => "GRUB", value => "inst.ks=hd:vdb1:/root-user-crypted-net.ks" }, 774​ { key => "GRUB", value => "inst.ks=hd:vdb1:/root-user-crypted-net.ks" },
746 { key => "NUMDISKS", value => "2" }, 775​ { key => "NUMDISKS", value => "2" },
747 { key => "HDD_2", value => "disk_ks.img" }, 776​ { key => "HDD_2", value => "disk_ks.img" },
748 { key => "ROOT_PASSWORD", value => "111111" }, 777​ { key => "ROOT_PASSWORD", value => "111111" },
749 { key => "USER_LOGIN", value => "test" }, 778​ { key => "USER_LOGIN", value => "test" },
750 { key => "USER_PASSWORD", value => "test" }, 779​ { key => "USER_PASSWORD", value => "test" },
751 ], 780​ ],
752 variables => "", 781​ variables => "",
753 }, 782​ },
754 { 783​ {
755 name => "fedup_minimal", 784​ name => "fedup_minimal",
756 prio => 18, 785​ prio => 19,
757 settings => [ 786​ settings => [
758 { key => "ROOT_PASSWORD", value => "weakpassword" }, 787​ { key => "ROOT_PASSWORD", value => "weakpassword" },
759 { key => "BOOTFROM", value => "c" }, 788​ { key => "BOOTFROM", value => "c" },
760 { key => "HDD_1", value => "disk_f22_minimal.img" }, 789​ { key => "HDD_1", value => "disk_f22_minimal.img" },
761 { key => "UPGRADE", value => "minimal" }, 790​ { key => "UPGRADE", value => "minimal" },
762 ], 791​ ],
763 variables => "", 792​ variables => "",
764 }, 793​ },
765 { 794​ {
766 name => "fedup_desktop", 795​ name => "fedup_desktop",
767 prio => 19, 796​ prio => 20,
768 settings => [ 797​ settings => [
769 { key => "ROOT_PASSWORD", value => "weakpassword" }, 798​ { key => "ROOT_PASSWORD", value => "weakpassword" },
770 { key => "BOOTFROM", value => "c" }, 799​ { key => "BOOTFROM", value => "c" },
771 { key => "HDD_1", value => "disk_f22_desktop.img" }, 800​ { key => "HDD_1", value => "disk_f22_desktop.img" },
772 { key => "UPGRADE", value => "desktop" }, 801​ { key => "UPGRADE", value => "desktop" },
773 ], 802​ ],
774 variables => "", 803​ variables => "",
775 }, 804​ },
Show All 13 Lines
View Options

tests/disk_custom_no_swap.pm

  • This file was added.
1​use base "anacondatest";
2​use strict;
3​use testapi;
4​
5​sub run {
6​ my $self = shift;
7​ # Go to INSTALLATION DESTINATION and ensure the disk is selected.
8​ # Because PARTITIONING starts with 'custom_', this will select custom.
9​ $self->select_disks();
10​ assert_and_click "anaconda_spoke_done";
11​
12​ # Manual partitioning spoke should be displayed
13​ assert_and_click "anaconda_part_automatic";
14​ $self->custom_delete_part('swap');
15​ assert_and_click "anaconda_spoke_done";
16​ # Deleting swap shows a warning and requires a second click to confirm
17​ assert_and_click "anaconda_spoke_done";
18​ assert_and_click "anaconda_part_accept_changes";
19​
20​ # Anaconda hub
21​ assert_screen "anaconda_main_hub", 300; #
22​
23​}
24​
25​sub test_flags {
26​ # without anything - rollback to 'lastgood' snapshot if failed
27​ # 'fatal' - whole test suite is in danger if this fails
28​ # 'milestone' - after this test succeeds, update 'lastgood'
29​ # 'important' - if this fails, set the overall state to 'fail'
30​ return { fatal => 1 };
31​}
32​
33​1;
34​
35​# vim: set sw=4 et: