add ext3, btrfs and LVM thin tests, tweaks to custom methods
ClosedPublic

Authored by adamwill on Aug 7 2015, 9:16 PM.

Details

Summary

This adds three new custom storage tests and some needles to
support them, and tweaks the custom storage methods a bit to
address some things that cropped up in writing the tests. A
new method is added for changing the filesystem, as that's
a distinct operation from changing the device type.

This also restores the previous behaviour of select_disks()
where it handled selecting custom partitioning when needed.
Turns out it's pretty common to use regex'es in perl! Who'd'a
thought.

A corresponding commit to add the tests to openqa_fedora_tools
is coming.

There's no post-install step for the tests yet; I'll try and
write those up and add them soon.

Test Plan

Do a full run, including the new tests, on Alpha RC2 and check
all are scheduled correctly and run correctly. The LVM thinp
test is expected to fail as it catches a genuine bug.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to add ext3, btrfs and LVM thin tests, tweaks to custom methods.Aug 7 2015, 9:16 PM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
garretraziel accepted this revision.Aug 10 2015, 8:59 AM

This looks good to me. One thing - please mention behaviour with "custom_" in PARTITIONING in VARIABLES.md file I have just uploaded.

lib/anacondatest.pm
93–97

Yep, I think if we want select_disks() to handle clicking on "custom partitioning", this is the best solution.

This revision is now accepted and ready to land.Aug 10 2015, 8:59 AM
adamwill updated this revision to Diff 1297.Aug 10 2015, 5:58 PM

Update VARIABLES.md to explain PARTITIONING='custom_' behaviour

Also corrects and expands on the current info there.

This revision was automatically updated to reflect the committed changes.