Differential D472

pass --nogpgcheck to fedup when appropriate
AbandonedPublic
Actions

Authored by adamwill on Jul 23 2015, 2:53 AM.

Details

Reviewers
jskladan
Summary

upgrades with GPG checking rarely work prior to Alpha TC1, so
if release is rawhide or milestone is Branched, pass
--nogpgcheck to fedup. This isn't 100% accurate - we *might*
get signing enabled and all packages signed and RPM-GPG-KEY
properly packaged before we get Alpha TC1 built some time or
other, and we may well *not* get it done in time for Alpha
TC1 sometimes, and we might well want to test a Branched
nightly after Alpha TC1 sometimes - but it doesn't really need
to be perfect, as it's not like using --nogpgcheck when it's
not strictly necessary will break anything, just make the test
a bit less rigorous.

NOTE: this is on top of D471.
Test Plan

Run the fedup minimal test and see that it gets
further (to the point where it fails because of an actual fedup
bug).

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Branch
fedup-nogpg
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 38
Build 38: arc lint + arc unit
adamwill retitled this revision from to pass --nogpgcheck to fedup when appropriate.Jul 23 2015, 2:53 AM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: jskladan, garretraziel.
garretraziel resigned from this revision.Jul 28 2015, 11:00 AM
garretraziel removed a reviewer: garretraziel.

Since fedup isn't working anymore (and nobody even knows whether it will be), I think that it's safe to abandon this revision.

adamwill abandoned this revision.Aug 13 2015, 3:08 PM

I'm abandoning this as fedup is dead, we'll come back to this when the new upgrade solution is testable I guess.

Revision Contents

PathPackages
Mtests/upgrade_run.pm (6 lines)

Diff 1239

View Options

tests/upgrade_run.pm

1use base "fedoralog"; 1​use base "fedoralog";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6 my $fedup_url = get_var('FEDUPURL'); 6​ my $fedup_url = get_var('FEDUPURL');
7 my ($release, $milestone, $compose) = split(/_/, get_var('BUILD')); 7​ my ($release, $milestone, $compose) = split(/_/, get_var('BUILD'));
8 $release = lc($release); 8​ $release = lc($release);
9​ my $nogpg = "";
10​ if ($release eq "rawhide" or $milestone eq "Branched") {
11​ $nogpg = " --nogpgcheck";
12​ }
9 13​
10 type_string "fedup --network ".$release." --instrepo ".$fedup_url; 14​ type_string "fedup --network ".$release." --instrepo ".$fedup_url.$nogpg;
11 send_key "ret"; 15​ send_key "ret";
12 16​
13 wait_still_screen 30, 6000; # TODO: shorter timeout, longer stillscreen? 17​ wait_still_screen 30, 6000; # TODO: shorter timeout, longer stillscreen?
14 18​
15 upload_logs "/var/log/fedup.log"; 19​ upload_logs "/var/log/fedup.log";
16 20​
17 type_string "reboot"; 21​ type_string "reboot";
18 send_key "ret"; 22​ send_key "ret";
Show All 24 Lines