get fedup URL from openqa_fedora_trigger
AbandonedPublic
Actions

Authored by adamwill on Jul 22 2015, 9:13 PM.

Details

Reviewers

garretraziel
jskladan

Summary

This is a companion to D470 in openqa_fedora_tools. That makes
openqa_fedora_trigger figure out the correct fedup URL and pass
it in as an openQA variable; this has upgrade_run just use that
variable instead of trying to figure out the URL itself (which
it, er, doesn't do as well as fedfind). Note: 'man fedup' says
'fedup --network rawhide' is OK, so this should handle Rawhide
nightlies fine.

Test Plan

Run the fedup_minimal test. It won't succeed, due to
GPG issues (I have a follow-up commit to use --nogpgcheck when
appropriate), but you can verify that it uses the correct URL
and successfully downloads the upgrade.img. Obviously you must
also apply D470 to openqa_fedora_tools to test.

Diff Detail

Repository

rOPENQATESTS os-autoinst-distri-fedora

Branch

fedup

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 37
Build 37: arc lint + arc unit

adamwill retitled this revision from to get fedup URL from openqa_fedora_trigger.Jul 22 2015, 9:13 PM

adamwill updated this object.

adamwill edited the test plan for this revision. (Show Details)

adamwill added reviewers: jskladan, garretraziel.

Herald added a subscriber: tflink. · View Herald TranscriptJul 22 2015, 9:13 PM

adamwill mentioned this in D470: work out the fedup URL for the build and pass it to openQA.Jul 22 2015, 9:18 PM

adamwill mentioned this in T478: Use fedfind to provide `$fedup_url` in fedup tests.

adamwill mentioned this in D472: pass --nogpgcheck to fedup when appropriate.Jul 23 2015, 2:53 AM

Although the patches look like a working solution, I'd much prefer the solution discussed in T478.

This revision now requires changes to proceed.Jul 23 2015, 8:36 AM

I'm abandoning this as fedup is dead, we'll come back to this when the new upgrade solution is testable I guess.

Revision Contents

			Path	Packages
M			tests/upgrade_run.pm (16 lines)

Commit	Tree	Parents	Author	Summary	Date
f8bab6b4fc14	08ea3e6a5b5d	212926a07842	Adam Williamson	get fedup URL from openqa_fedora_trigger (Show More…)	Jul 22 2015, 9:05 PM

Diff 1238

View Options

tests/upgrade_run.pm

1	use base "fedoralog";	1	use base "fedoralog";
2	use strict;	2	use strict;
3	use testapi;	3	use testapi;
4		4
5	sub run {	5	sub run {
6	my $fedup_url;	6	my $fedup_url = get_var('FEDUPURL');
7	my $to_version;	7	my ($release, $milestone, $compose) = split(/_/, get_var('BUILD'));
8	# FIXME: this is just a workaround, see https://phab.qadevel.cloud.fedoraproject.org/T478	8	$release = lc($release);
9	if (get_var("BUILD") =~ /^(\d+)_Final_(.*)$/) {
10	$fedup_url = "https://dl.fedoraproject.org/pub/alt/stage/".$1."_".$2."/Server/".get_var("ARCH")."/os";
11	$to_version = $1;
12	} else {
13	$fedup_url = "https://dl.fedoraproject.org/pub/alt/stage/".get_var("BUILD")."/Server/".get_var("ARCH")."/os";
14	get_var("BUILD") =~ /^(\d+)/;
15	$to_version = $1;
16	}
17		9
18	type_string "fedup --network ".$to_version." --instrepo ".$fedup_url;	10	type_string "fedup --network ".$release." --instrepo ".$fedup_url;
19	send_key "ret";	11	send_key "ret";
20		12
21	wait_still_screen 30, 6000; # TODO: shorter timeout, longer stillscreen?	13	wait_still_screen 30, 6000; # TODO: shorter timeout, longer stillscreen?
22		14
23	upload_logs "/var/log/fedup.log";	15	upload_logs "/var/log/fedup.log";
24		16
25	type_string "reboot";	17	type_string "reboot";
26	send_key "ret";	18	send_key "ret";
Show All 24 Lines