Differential D462

create fedora base class, factor out console login
ClosedPublic
Actions

Authored by adamwill on Jul 22 2015, 12:29 AM.

Details

Reviewers
garretraziel
jskladan
Commits
rOPENQATESTS4b8e41147970: create fedora base class, factor out console login
Summary

Root console in anaconda got broken by RHBZ #1222413 - no
shell on tty2. Decided to clean up console use in general as
part of fixing it.

This creates a class 'fedorabase' and has 'anacondalog' and
'fedoralog' both inherit from it. boot_to_login_screen is
moved there (as it seems appropriate) and it has a new
method, console_login, which basically handles 'get me a
shell on a console': if we're already at one it returns,
if not it'll type the user name and the password *if
necessary* (sometimes it's not) and return once it sees a
prompt. It takes a hash of named parameters for user,
password and 'check', which is whether it should die if it
fails to reach a console or not (some users don't want it
to).

anacondalog and fedoralog both get 'root_console' methods
which do something appropriate and then call
console_login; both have a hash of named parameters,
anacondalog's version only bothers with 'check', while
fedoralog's also accepts 'tty' to pick the tty to use.

This also adjusts all things which try to get to a console
prompt to use either root_console or console_login as
appropriate.

It also tweaks the needle tags a bit, drops some unneeded
needles, and adds a new 'user console prompt' needle; we
really just need two versions of the root prompt needle
and two of the user prompt needle (one for <F23, one for
F23+ - the console font changed in F23, and the @ character
at least doesn't match between the two). I think we still
need the <F23 case for upgrade tests, for now.

Test Plan

Do a full test run and see that more tests
succeed. I've done a run on happyassassin with a hack to
workaround the SELinux issue for interactive installs,
and the results look good. I also fiddled about a bit to
test some different cases, like forcing a failure in a
live test to test post_fail_hook (and hence root_console)
in that scenario, and forcing failures after some console
commands had been run to check that it DTRT when we've
already reached a console, etc.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
adamwill retitled this revision from to create fedora base class, factor out console login.Jul 22 2015, 12:29 AM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: garretraziel, jskladan.
adamwill mentioned this in D460: fix use of console in anaconda.Jul 22 2015, 12:30 AM

This is an alternative to D460: we take one or the other. I like this more, but do yell if you preferred D460.

adamwill added inline comments.Jul 22 2015, 12:36 AM
tests/_console_wait_login.pm
18

So I should note - I really don't quite get why the original code is set to log in as user then 'su' to root, if both user and root accounts are configured. I don't know if the intent was to test that 'su' works, or what.

We can twiddle this quite easily. If we want to test su for some reason we can actually just run 'su' then call console_login, because console_login actually ought to handle the 'su' password prompt successfully. But for now I just made it so when both user and root accounts are configured it ought to log in as user, then log out (thanks to the $bad check in console_login) and log in again as root, which I guess proves that logging in as both user and root works.

adamwill added a comment.Jul 22 2015, 12:53 AM

With this plus D456 and a hack to deal with the SELinux bug, 10 of 18 tests pass on the 2015-07-17 nightly. All the kickstart tests fail because of the SELinux bug (my workaround doesn't help the kickstart path). The fedup tests fail I think because I'm missing something in my openQA deployment (the disk images, I guess). multi_empty fails because of a needle issue (the 'two disks' needle is quite fragile as the distance between the disk widgets varies a lot, I'll submit a separate revision for that). The remaining failures:

delete_partial
simple_free_space
software_raid

seem to be actual anaconda bugs. See the most recent runs on https://openqa.happyassassin.net/tests .

garretraziel accepted this revision.Jul 22 2015, 7:15 AM

Looks definitely better than D460.

This revision is now accepted and ready to land.Jul 22 2015, 7:15 AM
jskladan added a comment.Jul 22 2015, 12:14 PM

Looks very good to me? I don't really remember the reason for the User->Root login sequence, this new way is IMHO much better.

Overall, this is some great work, and if it works, then please feel free to merge!

jskladan accepted this revision.Jul 22 2015, 12:14 PM
adamwill updated this revision to Diff 1232.Jul 22 2015, 6:20 PM

Tweak the console_login loop a bit

I did some more testing and found some issues with the previous
version when doing the 'log in as user then log in as root' thing
and also when lots of tests are running at once (so each step
can take a bit of time). This version works rather better.
Basically I added a couple of vars to make sure we only enter
the username and password once per console_login call, and made
the sleeps a bit longer. There are still ways this can go wrong,
but it's hard to make it much better without making it a lot
messier, I think.

Closed by commit rOPENQATESTS4b8e41147970: create fedora base class, factor out console login (authored by adamwill). · Explain WhyJul 22 2015, 6:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 1233

View Options

lib/anacondalog.pm

1package anacondalog; 1​package anacondalog;
2use base 'basetest'; 2​use base 'fedorabase';
3 3​
4use testapi; 4​use testapi;
5 5​
6sub post_fail_hook { 6​sub post_fail_hook {
7 my $self = shift; 7​ my $self = shift;
8 8​
9 my $has_traceback = 0; 9​ my $has_traceback = 0;
10 if (check_screen "anaconda_error", 10) { 10​ if (check_screen "anaconda_error", 10) {
11 assert_and_click "anaconda_report_btn"; # Generage Anaconda ABRT logs 11​ assert_and_click "anaconda_report_btn"; # Generage Anaconda ABRT logs
12 $has_traceback = 1; 12​ $has_traceback = 1;
13 } 13​ }
14 14​
15 send_key "ctrl-alt-f2"; 15​ $self->root_console(check=>0);
16 my $logged_in = 0; 16​ if (check_screen "root_console", 10) {
17 if (get_var("LIVE") && check_screen "text_console_login", 20) { ​
18 # On live installs, we need to log in ​
19 type_string "root"; ​
20 send_key "ret"; ​
21 if (check_screen "root_logged_in", 10) { ​
22 $logged_in = 1; ​
23 } ​
24 } ​
25 elsif (check_screen "anaconda_console", 10) { ​
26 $logged_in = 1; ​
27 } ​
28 ​
29 if ($logged_in == 1) { ​
30 upload_logs "/tmp/X.log"; 17​ upload_logs "/tmp/X.log";
31 upload_logs "/tmp/anaconda.log"; 18​ upload_logs "/tmp/anaconda.log";
32 upload_logs "/tmp/packaging.log"; 19​ upload_logs "/tmp/packaging.log";
33 upload_logs "/tmp/storage.log"; 20​ upload_logs "/tmp/storage.log";
34 upload_logs "/tmp/syslog"; 21​ upload_logs "/tmp/syslog";
35 upload_logs "/tmp/program.log"; 22​ upload_logs "/tmp/program.log";
36 upload_logs "/tmp/dnf.log"; 23​ upload_logs "/tmp/dnf.log";
37 24​
Show All 9 Lines
47 send_key "ret"; 34​ send_key "ret";
48 upload_logs "/tmp/anaconda_tb.tar.gz"; 35​ upload_logs "/tmp/anaconda_tb.tar.gz";
49 } 36​ }
50 else { 37​ else {
51 save_screenshot; 38​ save_screenshot;
52 } 39​ }
53} 40​}
54 41​
42​sub root_console {
43​ my $self = shift;
44​ my %args = (
45​ check => 1,
46​ @_);
47​
48​ if (get_var("LIVE")) {
49​ send_key "ctrl-alt-f2";
50​ }
51​ else {
52​ # Working around RHBZ 1222413, no console on tty2
53​ send_key "ctrl-alt-f1";
54​ send_key "ctrl-b";
55​ send_key "2";
56​ }
57​ $self->console_login(user=>"root",check=>$args{check});
58​}
59​
551; 60​1;
56 61​
57# vim: set sw=4 et: 62​# vim: set sw=4 et:
58 63​
View Options

lib/fedorabase.pm

  • This file was added.
1​package fedorabase;
2​use base 'basetest';
3​
4​use testapi;
5​
6​sub console_login {
7​ my $self = shift;
8​ my %args = (
9​ user => "root",
10​ password => get_var("ROOT_PASSWORD", "weakpassword"),
11​ check => 1,
12​ @_);
13​
14​ my $good = "";
15​ my $bad = "";
16​ my $needuser = 1;
17​ my $needpass = 1;
18​ if ($args{user} eq "root") {
19​ $good = "root_console";
20​ $bad = "user_console";
21​ }
22​ else {
23​ $good = "user_console";
24​ $bad = "root_console";
25​ }
26​
27​ for my $n (1 .. 10) {
28​ # This little loop should handle all possibilities quite
29​ # efficiently: already at a prompt (previously logged in, or
30​ # anaconda case), only need to enter username (live case),
31​ # need to enter both username and password (installed system
32​ # case). There are some annoying cases here involving delays
33​ # to various commands and the limitations of needles;
34​ # text_console_login also matches when the password prompt
35​ # is displayed (as the login prompt is still visible), and
36​ # both still match after login is complete, unless something
37​ # runs 'clear'. The sleeps and $needuser / $needpass attempt
38​ # to mitigate these problems.
39​ if (check_screen $good, 0) {
40​ return;
41​ }
42​ elsif (check_screen $bad, 0) {
43​ type_string "exit\n";
44​ sleep 2;
45​ }
46​ if ($needuser and check_screen "text_console_login", 0) {
47​ type_string "$args{user}\n";
48​ $needuser = 0;
49​ sleep 2;
50​ }
51​ elsif ($needpass and check_screen "console_password_required", 0) {
52​ type_string "$args{password}\n";
53​ $needpass = 0;
54​ # Sometimes login takes a bit of time, so add an extra sleep
55​ sleep 2;
56​ }
57​
58​ sleep 1;
59​ }
60​ # If we got here we failed; if 'check' is set, die.
61​ $args{check} && die "Failed to reach console!"
62​}
63​
64​sub boot_to_login_screen {
65​ my $self = shift;
66​ my $boot_done_screen = shift;
67​ my $stillscreen = shift || 10;
68​ my $timeout = shift || 60;
69​
70​ wait_still_screen $stillscreen, $timeout;
71​
72​ if ($boot_done_screen ne "") {
73​ assert_screen $boot_done_screen;
74​ }
75​}
76​
77​1;
78​
79​# vim: set sw=4 et:
View Options

lib/fedoralog.pm

1package fedoralog; 1​package fedoralog;
2use base 'basetest'; 2​use base 'fedorabase';
3 3​
4use testapi; 4​use testapi;
5 5​
6sub login_as_root { 6​sub root_console {
7 my $self = shift; 7​ my $self = shift;
8 my $tty = shift || 1; 8​ my %args = (
9 my $password = get_var("ROOT_PASSWORD", "weakpassword"); 9​ tty => 1,
10​ check => 1,
11​ @_);
10 12​
11 send_key "ctrl-alt-f$tty"; 13​ send_key "ctrl-alt-f$args{tty}";
12 assert_screen "text_console_login", 20; 14​ $self->console_login(check=>$args{check});
13 ​
14 type_string "root"; ​
15 send_key "ret"; ​
16 assert_screen "console_password_required", 10; ​
17 type_string $password; ​
18 send_key "ret"; ​
19 ​
20 assert_screen "root_logged_in", 10; ​
21} ​
22 ​
23sub boot_to_login_screen { ​
24 my $self = shift; ​
25 my $boot_done_screen = shift; ​
26 my $stillscreen = shift || 10; ​
27 my $timeout = shift || 60; ​
28 ​
29 wait_still_screen $stillscreen, $timeout; ​
30 ​
31 if ($boot_done_screen ne "") { ​
32 assert_screen $boot_done_screen; ​
33 } ​
34} 15​}
35 16​
36sub post_fail_hook { 17​sub post_fail_hook {
37 my $self = shift; 18​ my $self = shift;
38 19​
39 $self->login_as_root(2); 20​ $self->root_console(tty=>2);
40 21​
41 # Upload all ABRT logs 22​ # Upload all ABRT logs
42 type_string "cd /var/tmp/abrt && tar czvf abrt.tar.gz *"; 23​ type_string "cd /var/tmp/abrt && tar czvf abrt.tar.gz *";
43 send_key "ret"; 24​ send_key "ret";
44 upload_logs "/var/tmp/abrt/abrt.tar.gz"; 25​ upload_logs "/var/tmp/abrt/abrt.tar.gz";
45 26​
46 # Upload /var/log 27​ # Upload /var/log
47 type_string "tar czvf /tmp/var_log.tar.gz /var/log"; 28​ type_string "tar czvf /tmp/var_log.tar.gz /var/log";
48 send_key "ret"; 29​ send_key "ret";
49 upload_logs "/tmp/var_log.tar.gz"; 30​ upload_logs "/tmp/var_log.tar.gz";
50} 31​}
51 32​
521; 33​1;
53 34​
54# vim: set sw=4 et: 35​# vim: set sw=4 et:
View Options

needles/anaconda_console.json

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

needles/anaconda_console.png

  • This binary file was deleted.
View Options

needles/root_logged_in.json

1{ 1​{
2 "properties": [], ​
3 "area": [ 2​ "area": [
4 { 3​ {
5 "width": 156, 4​ "height": 17,
6 "xpos": 0, 5​ "type": "match",
7 "height": 19, 6​ "width": 40,
8 "ypos": 113, 7​ "xpos": 7,
9 "type": "match" 8​ "ypos": 111
9​ },
10​ {
11​ "height": 14,
12​ "type": "match",
13​ "width": 17,
14​ "xpos": 137,
15​ "ypos": 112
10 } 16​ }
11 ], 17​ ],
18​ "properties": [],
12 "tags": [ 19​ "tags": [
13 "root_logged_in", 20​ "root_logged_in",
21​ "root_console",
14 "ENV-DISTRI-fedora", 22​ "ENV-DISTRI-fedora",
15 "ENV-INSTLANG-en_US", 23​ "ENV-INSTLANG-en_US",
16 "ENV-FLAVOR-server" 24​ "ENV-FLAVOR-server"
17 ] 25​ ]
18} 26​}
19No newline at end of file 27​No newline at end of file
View Options

needles/root_logged_in2.json

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

needles/root_logged_in2.png

  • This binary file was deleted.
View Options

needles/root_logged_in_rawhide20150311.json

1{ 1​{
2​ "area": [
3​ {
4​ "height": 14,
5​ "type": "match",
6​ "width": 41,
7​ "xpos": 7,
8​ "ypos": 80
9​ },
10​ {
11​ "height": 14,
12​ "type": "match",
13​ "width": 16,
14​ "xpos": 136,
15​ "ypos": 80
16​ }
17​ ],
2 "tags": [ 18​ "tags": [
3 "root_logged_in", 19​ "root_logged_in",
20​ "root_console",
4 "ENV-DISTRI-fedora", 21​ "ENV-DISTRI-fedora",
5 "ENV-INSTLANG-en_US", 22​ "ENV-INSTLANG-en_US",
6 "ENV-FLAVOR-server" 23​ "ENV-FLAVOR-server"
7 ], ​
8 "area": [ ​
9 { ​
10 "xpos": 0, ​
11 "ypos": 80, ​
12 "width": 152, ​
13 "height": 14, ​
14 "type": "match" ​
15 } ​
16 ] 24​ ]
17} 25​}
View Options

needles/user_logged_in.json

1{ 1​{
2​ "area": [
3​ {
4​ "height": 14,
5​ "type": "match",
6​ "width": 41,
7​ "xpos": 7,
8​ "ypos": 95
9​ },
10​ {
11​ "height": 17,
12​ "type": "match",
13​ "width": 17,
14​ "xpos": 136,
15​ "ypos": 93
16​ }
17​ ],
2 "tags": [ 18​ "tags": [
3 "user_logged_in", 19​ "user_logged_in",
20​ "user_console",
4 "ENV-DISTRI-fedora", 21​ "ENV-DISTRI-fedora",
5 "ENV-INSTLANG-en_US", 22​ "ENV-INSTLANG-en_US",
6 "ENV-FLAVOR-server" 23​ "ENV-FLAVOR-server"
7 ], ​
8 "area": [ ​
9 { ​
10 "xpos": 1, ​
11 "ypos": 94, ​
12 "width": 155, ​
13 "height": 20, ​
14 "type": "match" ​
15 } ​
16 ] 24​ ]
17} 25​}
18No newline at end of file ​
View Options

needles/user_logged_in_20150721f23.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "height": 14,
5​ "type": "match",
6​ "width": 41,
7​ "xpos": 7,
8​ "ypos": 95
9​ },
10​ {
11​ "height": 17,
12​ "type": "match",
13​ "width": 17,
14​ "xpos": 136,
15​ "ypos": 93
16​ }
17​ ],
18​ "tags": [
19​ "user_logged_in",
20​ "user_console",
21​ "ENV-DISTRI-fedora",
22​ "ENV-INSTLANG-en_US",
23​ "ENV-FLAVOR-server"
24​ ]
25​}
View Options

needles/user_logged_in_20150721f23.png

  • This binary file was added.
View Options

tests/_console_wait_login.pm

1use base "basetest"; 1​use base "fedorabase";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6​ my $self = shift;
6 7​
7 # If KICKSTART is set, then the wait_time needs to 8​ # If KICKSTART is set, then the wait_time needs to
8 # consider the install time 9​ # consider the install time
9 my $wait_time = get_var("KICKSTART") ? 1800 : 300; 10​ my $wait_time = get_var("KICKSTART") ? 1800 : 300;
10 11​
11 # Reboot and wait for the text login 12​ # Reboot and wait for the text login
12 assert_screen "text_console_login", $wait_time; 13​ assert_screen "text_console_login", $wait_time;
13 14​
14 if ((get_var("USER_LOGIN") && get_var("USER_PASSWORD")) || get_var("ROOT_PASSWORD")) 15​ if (get_var("USER_LOGIN") && get_var("USER_PASSWORD")) {
15 { 16​ $self->console_login(user=>get_var("USER_LOGIN"), password=>get_var("USER_PASSWORD"));
16 my $user_logged_in = 0; ​
17 if (get_var("USER_LOGIN")) ​
18 { ​
19 type_string get_var("USER_LOGIN"); ​
20 send_key "ret"; ​
21 type_string get_var("USER_PASSWORD"); ​
22 send_key "ret"; ​
23 assert_screen "user_logged_in", 10; ​
24 $user_logged_in = 1; ​
25 } 17​ }
26 if (get_var("ROOT_PASSWORD")) 18​ if (get_var("ROOT_PASSWORD")) {
adamwillAuthorUnsubmitted
Not Done

So I should note - I really don't quite get why the original code is set to log in as user then 'su' to root, if both user and root accounts are configured. I don't know if the intent was to test that 'su' works, or what.

We can twiddle this quite easily. If we want to test su for some reason we can actually just run 'su' then call console_login, because console_login actually ought to handle the 'su' password prompt successfully. But for now I just made it so when both user and root accounts are configured it ought to log in as user, then log out (thanks to the $bad check in console_login) and log in again as root, which I guess proves that logging in as both user and root works.

27 { 19​ $self->console_login(user=>"root", password=>get_var("ROOT_PASSWORD"));
28 if ($user_logged_in == 1) ​
29 { ​
30 type_string "su -"; ​
31 send_key "ret"; ​
32 assert_screen "console_password_required", 10; ​
33 } 20​ }
34 else ​
35 { ​
36 type_string "root"; ​
37 send_key "ret"; ​
38 } ​
39 type_string get_var("ROOT_PASSWORD"); ​
40 send_key "ret"; ​
41 assert_screen "root_logged_in", 10; ​
42 } ​
43 } ​
44 ​
45} 21​}
46 22​
47sub test_flags { 23​sub test_flags {
48 # without anything - rollback to 'lastgood' snapshot if failed 24​ # without anything - rollback to 'lastgood' snapshot if failed
49 # 'fatal' - whole test suite is in danger if this fails 25​ # 'fatal' - whole test suite is in danger if this fails
50 # 'milestone' - after this test succeeds, update 'lastgood' 26​ # 'milestone' - after this test succeeds, update 'lastgood'
51 # 'important' - if this fails, set the overall state to 'fail' 27​ # 'important' - if this fails, set the overall state to 'fail'
52 return { fatal => 1, milestone => 1 }; 28​ return { fatal => 1, milestone => 1 };
53} 29​}
54 30​
551; 31​1;
56 32​
57# vim: set sw=4 et: 33​# vim: set sw=4 et:
View Options

tests/disk_guided_delete_partial_postinstall.pm

1use base "basetest"; 1​use base "basetest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6 assert_screen "root_logged_in"; 6​ assert_screen "root_console";
7 type_string 'reset; mount /dev/vda2 /mnt; echo $?'; # if you use doublequotes, $? gets replaced by Perl with last error code 7​ type_string 'reset; mount /dev/vda2 /mnt; echo $?'; # if you use doublequotes, $? gets replaced by Perl with last error code
8 send_key "ret"; 8​ send_key "ret";
9 assert_screen "console_command_success"; 9​ assert_screen "console_command_success";
10 type_string 'reset; cat /mnt/testfile'; 10​ type_string 'reset; cat /mnt/testfile';
11 send_key "ret"; 11​ send_key "ret";
12 assert_screen "provided_second_partition_intact"; 12​ assert_screen "provided_second_partition_intact";
13} 13​}
14 14​
Show All 11 Lines
View Options

tests/disk_guided_free_space_postinstall.pm

1use base "basetest"; 1​use base "basetest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6 assert_screen "root_logged_in"; 6​ assert_screen "root_console";
7 type_string 'reset; mount /dev/vda1 /mnt; echo $?'; # if you use doublequotes, $? gets replaced by Perl with last error code 7​ type_string 'reset; mount /dev/vda1 /mnt; echo $?'; # if you use doublequotes, $? gets replaced by Perl with last error code
8 send_key "ret"; 8​ send_key "ret";
9 assert_screen "console_command_success"; 9​ assert_screen "console_command_success";
10 type_string 'reset; cat /mnt/testfile'; 10​ type_string 'reset; cat /mnt/testfile';
11 send_key "ret"; 11​ send_key "ret";
12 assert_screen "provided_disk_intact"; 12​ assert_screen "provided_disk_intact";
13} 13​}
14 14​
Show All 11 Lines
View Options

tests/disk_guided_multi_empty_all_postinstall.pm

1use base "basetest"; 1​use base "basetest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6 assert_screen "root_logged_in"; 6​ assert_screen "root_console";
7 7​
8 # when two disks are selected in installation, LVM is used 8​ # when two disks are selected in installation, LVM is used
9 type_string "reset; pvdisplay"; 9​ type_string "reset; pvdisplay";
10 send_key "ret"; 10​ send_key "ret";
11 assert_screen "console_two_disks_mounted_lvm"; 11​ assert_screen "console_two_disks_mounted_lvm";
12} 12​}
13 13​
14sub test_flags { 14​sub test_flags {
Show All 10 Lines
View Options

tests/disk_guided_multi_postinstall.pm

1use base "basetest"; 1​use base "basetest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6 assert_screen "root_logged_in"; 6​ assert_screen "root_console";
7 type_string 'reset; mount /dev/sdb1 /mnt; echo $?'; # if you use doublequotes, $? gets replaced by Perl with last error code 7​ type_string 'reset; mount /dev/sdb1 /mnt; echo $?'; # if you use doublequotes, $? gets replaced by Perl with last error code
8 send_key "ret"; 8​ send_key "ret";
9 assert_screen "console_command_success"; 9​ assert_screen "console_command_success";
10 type_string 'reset; cat /mnt/testfile'; 10​ type_string 'reset; cat /mnt/testfile';
11 send_key "ret"; 11​ send_key "ret";
12 assert_screen "provided_disk_intact"; 12​ assert_screen "provided_disk_intact";
13} 13​}
14 14​
Show All 11 Lines
View Options

tests/disk_part_software_raid_postinstall.pm

1use base "basetest"; 1​use base "basetest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6 assert_screen "root_logged_in"; 6​ assert_screen "root_console";
7 type_string "reset; cat /proc/mdstat"; 7​ type_string "reset; cat /proc/mdstat";
8 send_key "ret"; 8​ send_key "ret";
9 assert_screen "console_raid_used"; 9​ assert_screen "console_raid_used";
10} 10​}
11 11​
12sub test_flags { 12​sub test_flags {
13 # without anything - rollback to 'lastgood' snapshot if failed 13​ # without anything - rollback to 'lastgood' snapshot if failed
14 # 'fatal' - whole test suite is in danger if this fails 14​ # 'fatal' - whole test suite is in danger if this fails
15 # 'milestone' - after this test succeeds, update 'lastgood' 15​ # 'milestone' - after this test succeeds, update 'lastgood'
16 # 'important' - if this fails, set the overall state to 'fail' 16​ # 'important' - if this fails, set the overall state to 'fail'
17 return { fatal => 1 }; 17​ return { fatal => 1 };
18} 18​}
19 19​
201; 20​1;
21 21​
22# vim: set sw=4 et: 22​# vim: set sw=4 et:
View Options

tests/install_source_graphical.pm

1use base "anacondalog"; 1​use base "anacondalog";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6​ my $self = shift;
6 # Anaconda hub 7​ # Anaconda hub
7 assert_screen "anaconda_main_hub", 300; # 8​ assert_screen "anaconda_main_hub", 300; #
8 9​
9 # Go into the Install Source spoke 10​ # Go into the Install Source spoke
10 assert_and_click "anaconda_main_hub_installation_source"; 11​ assert_and_click "anaconda_main_hub_installation_source";
11 12​
12 13​
13 14​
Show All 29 Lines
43 } 44​ }
44 45​
45 assert_and_click "anaconda_spoke_done"; 46​ assert_and_click "anaconda_spoke_done";
46 47​
47 # Anaconda hub 48​ # Anaconda hub
48 assert_screen "anaconda_main_hub", 300; 49​ assert_screen "anaconda_main_hub", 300;
49 50​
50 # check that the repo was used 51​ # check that the repo was used
51 send_key "ctrl-alt-f2"; 52​ $self->root_console;
52 wait_idle 10; ​
53 type_string "grep \"".$repourl."\" /tmp/packaging.log"; # | grep \"added repo\""; 53​ type_string "grep \"".$repourl."\" /tmp/packaging.log"; # | grep \"added repo\"";
54 send_key "ret"; 54​ send_key "ret";
55 assert_screen "anaconda_install_source_check_repo_added"; 55​ assert_screen "anaconda_install_source_check_repo_added";
56 send_key "ctrl-alt-f6"; 56​ send_key "ctrl-alt-f6";
57 57​
58 # Anaconda hub 58​ # Anaconda hub
59 assert_screen "anaconda_main_hub", 30; # 59​ assert_screen "anaconda_main_hub", 30; #
60 60​
Show All 13 Lines
View Options

tests/install_source_variation.pm

1use base "anacondalog"; 1​use base "anacondalog";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6 # !!! GRUB parameter is set in _boot_to_anaconda.pm !!! 6​ # !!! GRUB parameter is set in _boot_to_anaconda.pm !!!
7 7​ my $self = shift;
8 # Anaconda hub 8​ # Anaconda hub
9 assert_screen "anaconda_main_hub"; 9​ assert_screen "anaconda_main_hub";
10 10​
11 # FIXME: this code is scattered in at least three places (here, _boot_to_anaconda, _install_source_graphical. Deduplicate 11​ # FIXME: this code is scattered in at least three places (here, _boot_to_anaconda, _install_source_graphical. Deduplicate
12 my $fedora_version = lc((split /_/, get_var("BUILD"))[0]); 12​ my $fedora_version = lc((split /_/, get_var("BUILD"))[0]);
13 my $repourl = ""; 13​ my $repourl = "";
14 14​
15 $repourl = get_var("REPOSITORY_VARIATION")."/".$fedora_version."/".get_var("ARCH")."/os"; 15​ $repourl = get_var("REPOSITORY_VARIATION")."/".$fedora_version."/".get_var("ARCH")."/os";
16 16​
17 # check that the repo was used 17​ # check that the repo was used
18 send_key "ctrl-alt-f2"; 18​ $self->root_console;
19 wait_idle 10; ​
20 type_string "grep \"".$repourl."\" /tmp/packaging.log"; #| grep \"added repo\""; 19​ type_string "grep \"".$repourl."\" /tmp/packaging.log"; #| grep \"added repo\"";
21 send_key "ret"; 20​ send_key "ret";
22 assert_screen "anaconda_install_source_check_repo_added"; 21​ assert_screen "anaconda_install_source_check_repo_added";
23 send_key "ctrl-alt-f6"; 22​ send_key "ctrl-alt-f6";
24 23​
25 # Anaconda hub 24​ # Anaconda hub
26 assert_screen "anaconda_main_hub", 30; # 25​ assert_screen "anaconda_main_hub", 30; #
27 26​
Show All 13 Lines
View Options

tests/upgrade_postinstall_minimal.pm

1use base "fedoralog"; 1​use base "fedoralog";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5 5​
6sub run { 6​sub run {
7 my $self = shift; 7​ my $self = shift;
8 8​
9 $self->boot_to_login_screen(); 9​ $self->boot_to_login_screen();
10 $self->login_as_root(3); 10​ $self->root_console(tty=>3);
11 11​
12 assert_screen "console_f22_installed"; 12​ assert_screen "console_f22_installed";
13} 13​}
14 14​
15 15​
16sub test_flags { 16​sub test_flags {
17 # without anything - rollback to 'lastgood' snapshot if failed 17​ # without anything - rollback to 'lastgood' snapshot if failed
18 # 'fatal' - whole test suite is in danger if this fails 18​ # 'fatal' - whole test suite is in danger if this fails
19 # 'milestone' - after this test succeeds, update 'lastgood' 19​ # 'milestone' - after this test succeeds, update 'lastgood'
20 # 'important' - if this fails, set the overall state to 'fail' 20​ # 'important' - if this fails, set the overall state to 'fail'
21 return { fatal => 1 }; 21​ return { fatal => 1 };
22} 22​}
23 23​
241; 24​1;
25 25​
26# vim: set sw=4 et: 26​# vim: set sw=4 et:
View Options

tests/upgrade_preinstall.pm

1use base "fedoralog"; 1​use base "fedoralog";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4 4​
5sub run { 5​sub run {
6 my $self = shift; 6​ my $self = shift;
7 7​
8 if (get_var('UPGRADE') eq "desktop") { 8​ if (get_var('UPGRADE') eq "desktop") {
9 $self->boot_to_login_screen("graphical_login", 30); # GDM takes time to load 9​ $self->boot_to_login_screen("graphical_login", 30); # GDM takes time to load
10 #} elsif (get_var('UPGRADE' eq "minimal")) { 10​ #} elsif (get_var('UPGRADE' eq "minimal")) {
11 } else { 11​ } else {
12 $self->boot_to_login_screen(); 12​ $self->boot_to_login_screen();
13 } 13​ }
14 $self->login_as_root(3); 14​ $self->root_console(tty=>3);
15 15​
16 type_string 'yum -y update; echo $?'; 16​ type_string 'yum -y update; echo $?';
17 send_key "ret"; 17​ send_key "ret";
18 18​
19 assert_screen "console_command_success", 1800; 19​ assert_screen "console_command_success", 1800;
20 20​
21 type_string "reboot"; 21​ type_string "reboot";
22 send_key "ret"; 22​ send_key "ret";
23 23​
24 if (get_var('UPGRADE') eq "desktop") { 24​ if (get_var('UPGRADE') eq "desktop") {
25 $self->boot_to_login_screen("graphical_login", 30); # GDM takes time to load 25​ $self->boot_to_login_screen("graphical_login", 30); # GDM takes time to load
26 #} elsif (get_var('UPGRADE' eq "minimal")) { 26​ #} elsif (get_var('UPGRADE' eq "minimal")) {
27 } else { 27​ } else {
28 $self->boot_to_login_screen(); 28​ $self->boot_to_login_screen();
29 } 29​ }
30 $self->login_as_root(3); 30​ $self->root_console(tty=>3);
31 31​
32 type_string 'yum -y install fedup; echo $?'; 32​ type_string 'yum -y install fedup; echo $?';
33 send_key "ret"; 33​ send_key "ret";
34 34​
35 assert_screen "console_command_success", 1800; 35​ assert_screen "console_command_success", 1800;
36} 36​}
37 37​
38 38​
Show All 11 Lines