add rpm_utils
ClosedPublic
Actions

Authored by kparal on Apr 8 2014, 2:23 PM.

Details

Reviewers

Commits

rLTRN2f2c7cd957c1: add rpm_utils abd basearch() method

Summary

Add rpm_utils.py and basearch() method.
This is needed by yumrepoinfo (my task) and bodhi_comment_directive (@jskladan's task).

Test Plan

Tests added.

Lint

Lint Skipped

Unit

Unit Tests Skipped

Looks good to me.

Looks good, ship it!

Closed by commit rLTRN2f2c7cd957c1 (authored by @kparal).

			Path
A	M		libtaskotron/rpm_utils.py (23 lines)
A	M		testing/test_rpm_utils.py (30 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	124	f39c5e5		Apr 8 2014, 2:23 PM	★	★
Diff 2	127	f39c5e5	Commit rLTRN2f2c7cd957c11068b376f901dca3f6e379ece08c	Apr 9 2014, 11:24 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
b71589fa51fe	a8c26979c4e4	f39c5e57c53c	Kamil Páral	add rpm_utils (Show More…)	Apr 8 2014, 2:21 PM

		1		# -- coding: utf-8 --
		2		# Copyright 2014, Red Hat, Inc.
		3		# License: GNU General Public License version 2 or later
		4
		5		''' Utility methods related to RPM and YUM '''
		6
		7		import os
		8
		9
		10		def basearch(arch=None):
		11		'''
		12		This returns the 'base' architecture identifier for a specified architecture
		13		(e.g. i386 for i[3-6]86), to be used by YUM etc.
		14
		15		@param arch an arch (string) to be converted to a basearch. If None, then
		16		the arch of the current machine is used.
		17		@return basearch, or @param arch if no basearch was found for it
		18		'''
		19		if arch == None:
		20		arch = os.uname()[4]
		21		if arch in ('i486', 'i586', 'i686'):
		22		arch = 'i386'
		23		return arch

		1		# -- coding: utf-8 --
		2		# Copyright 2014, Red Hat, Inc.
		3		# License: GNU General Public License version 2 or later
		4
		5		'''Unit tests for libtaskotron/rpm_utils.py'''
		6
		7		from libtaskotron import rpm_utils
		8
		9		class TestRpmUtils:
		10
		11		def test_basearch_i386(self):
		12		'''i386-like archs'''
		13		assert rpm_utils.basearch('i386') == 'i386'
		14		assert rpm_utils.basearch('i486') == 'i386'
		15		assert rpm_utils.basearch('i586') == 'i386'
		16		assert rpm_utils.basearch('i686') == 'i386'
		17
		18		def test_basearch_x86_64(self):
		19		'''x86_64 arch'''
		20		assert rpm_utils.basearch('x86_64') == 'x86_64'
		21
		22		def test_basearch_local(self):
		23		'''When no arch specified, local arch should be returned'''
		24		# let's say we're satisfied if /something/ is returned. Otherwise we
		25		# would have to copy most of the method's code in order to check it :-)
		26		assert rpm_utils.basearch()
		27
		28		def test_basearch_unknown(self):
		29		'''Unknown arch is just returned'''
		30		assert rpm_utils.basearch('some_arch') == 'some_arch'