| lbrabec | |
| mkrizek | |
| jskladan |
This happened for large Bodhi updates with many builds before it got
assigned an update id.
tested manually
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | upgradepath.py (19 lines) |
| Commit | Tree | Parents | Author | Summary | Date |
|---|---|---|---|---|---|
| 8348af063f94 | 323d4561eed1 | 081a1bc6c7ef | Kamil Páral | add assert, just to be sure | Jul 20 2015, 11:03 AM |
| 081a1bc6c7ef | c262bf6288a7 | de45058e2854 | Kamil Páral | don't try to create >255 chars long artifact filenames (Show More…) | Jul 20 2015, 10:46 AM |
| Show First 20 Lines • Show All 74 Lines • ▼ Show 20 Line(s) | 74 | try: | |||
|---|---|---|---|---|---|
| 75 | storedir = os.path.abspath(args.storedir) | 75 | storedir = os.path.abspath(args.storedir) | ||
| 76 | logger.debug('Writing individual logs into: %s', storedir) | 76 | logger.debug('Writing individual logs into: %s', storedir) | ||
| 77 | 77 | | |||
| 78 | if not os.path.exists(storedir): | 78 | if not os.path.exists(storedir): | ||
| 79 | os.makedirs(storedir) | 79 | os.makedirs(storedir) | ||
| 80 | 80 | | |||
| 81 | # save build logs | 81 | # save build logs | ||
| 82 | for build, detail in self.build2detail.items(): | 82 | for build, detail in self.build2detail.items(): | ||
| 83 | filename = os.path.join(storedir, build) + '.log' | 83 | filepath = os.path.join(storedir, build) + '.log' | ||
| 84 | fout = open(filename, 'w') | 84 | fout = open(filepath, 'w') | ||
| 85 | fout.write('\n'.join(detail.output) + '\n') | 85 | fout.write('\n'.join(detail.output) + '\n') | ||
| 86 | fout.close() | 86 | fout.close() | ||
| 87 | detail.artifact = filename | 87 | detail.artifact = filepath | ||
| 88 | 88 | | |||
| 89 | # save update logs | 89 | # save update logs | ||
| 90 | for update, detail in self.update2detail.items(): | 90 | for update, detail in self.update2detail.items(): | ||
| 91 | filename = os.path.join(storedir, update.update['updateid'] or | 91 | filename = (update.update['updateid'] or update.update['title']) + '.log' | ||
| 92 | update.update['title']) + '.log' | 92 | # update titles can be very long, we need to trim them | ||
| 93 | fout = open(filename, 'w') | 93 | if len(filename) > 255: # the max file name length for most Linux filesystems | ||
| 94 | suffix = '....log' | ||||
| 95 | filename = filename[:255-len(suffix)] + suffix | ||||
| 96 | assert len(filename) <= 255 | ||||
| 97 | filepath = os.path.join(storedir, filename) | ||||
| 98 | fout = open(filepath, 'w') | ||||
| 94 | fout.write('\n'.join(detail.output) + '\n') | 99 | fout.write('\n'.join(detail.output) + '\n') | ||
| 95 | fout.close() | 100 | fout.close() | ||
| 96 | detail.artifact = filename | 101 | detail.artifact = filepath | ||
| 97 | 102 | | |||
| 98 | except OSError as e: | 103 | except OSError as e: | ||
| 99 | logger.error('Individual logs not saved into %s, an error occured. ' | 104 | logger.error('Individual logs not saved into %s, an error occured. ' | ||
| 100 | 'Raising.', args.storedir) | 105 | 'Raising.', args.storedir) | ||
| 101 | raise e | 106 | raise e | ||
| 102 | 107 | | |||
| 103 | 108 | | |||
| 104 | def compare(self, proposed_build, tags, op, tag_builds, check_detail, | 109 | def compare(self, proposed_build, tags, op, tag_builds, check_detail, | ||
| ▲ Show 20 Lines • Show All 577 Lines • Show Last 20 Lines | |||||