firefox search fix
ClosedPublic
Actions

Authored by lbrabec on Jul 16 2015, 1:22 PM.

Details

Reviewers

Maniphest Tasks

T528: resultsdb frontend search doesn't work on Firefox

Commits

rRSFE8bc6d5a96d7f: firefox search fix

Summary

Current version of firefox (39) doesn't support str.includes(), this
was replaced with str.indexOf() != -1

Test Plan

try search

Repository

rRSFE resultsdb_frontend

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

lbrabec retitled this revision from to firefox search fix.Jul 16 2015, 1:22 PM

lbrabec updated this object.

lbrabec edited the test plan for this revision. (Show Details)

if it works with Firefox < 40, then it's good with me :)

This revision is now accepted and ready to land.Jul 16 2015, 2:17 PM

Works!

assuming this has been tested, LGTM

Closed by commit rRSFE8bc6d5a96d7f: firefox search fix (authored by Lukas Brabec <lbrabec@redhat.com>). · Explain WhyJul 16 2015, 3:12 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			resultsdb_frontend/static/js/search.js (22 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1189	d807462		Jul 16 2015, 1:22 PM	★	★
Diff 2	1194	14fe417	Commit rRSFE8bc6d5a96d7f9c4e2863d22f3e5692af6c5ef230	Jul 16 2015, 3:09 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
31524e1ab9ab	ab893f05063b	d807462011e0	Lukas Brabec	firefox search fix (Show More…)	Jul 16 2015, 1:21 PM

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 Line(s)		43	$(".popover #searchform").submit(function(e){
45	var query = $(".popover #query").val();	45		var query = $(".popover #query").val();
46	var testcase = $(".popover #testcase").val();	46		var testcase = $(".popover #testcase").val();
47	var type = $(".popover #type").val();	47		var type = $(".popover #type").val();
48	var url = $(".popover #url").val() + "?"	48		var url = $(".popover #url").val() + "?"
49		49
50		50
51	query = query.replace(/\*/g,"%");	51		query = query.replace(/\*/g,"%");
52		52
53	if(query.includes("%")){	53		if(query.indexOf("%") != -1){
54	//wildcard match	54		//wildcard match
55	url += "item:like=" + query;	55		url += "item:like=" + query;
56	} else {	56		} else {
57	//substring match	57		//substring match
58	url += "item:like=%" + query + "%";	58		url += "item:like=%" + query + "%";
59	}	59		}
60		60
61	if(testcase != 0)	61		if(testcase != 0)
Show All 22 Lines