libtaskotron/runner.py
134	Please document why this is necessary instead of `isinstance()`

libtaskotron/directives/exitcode_directive.py
12	The docs fail to build.
14	maybe "set runtask exit code" instead of "generate exitcode"
30	Let's document the return type as well, and the values (since they are hard-coded).
32–36	This seems to be part of the `returns` section, while it should be probably in `description`.
38–39	"exactly one of keys ..." would be probably more precise
40	Current libtaskotron version is `0.3.17`. You should make sure it is not the same as the last publicly released version, and if it is, bump it to `0.3.18` (I guess) and adjust the spec file as well.
58–59	Ditto.
63	Would this be a bit more readable? if ['tap_worst' in input_data, 'tap_last' in input_data].count(True) != 1: Or, alternatively, why do you have `not` and `!=` together? Would this work? if ('tap_worst' in input_data) == ('tap_last' in input_data):
64–65	Ditto.
76	assert 'tap_last' in input_data above this line would add some extra error checking. Just an idea.
78	This is probably not intended here. But a `log.debug` statement before every `return` statement in this directive would be nice.
libtaskotron/runner.py
39	Can you please document (using a standard Sphinx syntax, so that it's visible in the generated docs) what this is for (that's rather obvious) and what values this can have? Number, string, boolean,... and what `None` means?
135	It would be great to add a comment here documenting the intended intention (i.e. failure should not be overridden with later success).
136	Let's add a `log.info` here, it's an important change.
278–279	I'd add another `log.info` here, saying that we're exiting with exit status `$number` because something failed and this beahavior was requested.

libtaskotron/directives/exitcode_directive.py
63	Or, alternatively, why do you have not and != together? Would this work? The truth is, that the code is flawed - it is supposed to behave like XOR, but is not. The XOR-like behaviour is actually this piece of code: if ('tap_worst' in input_data) != ('tap_last' in input_data): Which corresponds to the `...count()` example of yours, but IMHO is quite a bit more readable.

libtaskotron/directives/exitcode_directive.py
63	Well, it should behave like NXOR, which is actually equivalence, wonder how i missed that, @kparal 's solution with `==` should be fine.

libtaskotron/directives/exitcode_directive.py
20–22	Please also mention what happens when the TAP is empty (no results).
39	I'm mildly confused by `input data`, it looks like a variable `input_data`, but without the underscore - but the user doesn't know anything about that variable. It's probably better to say * :class:`.TaskotronDirectiveError`: when there's not exactly one of parameters ``tap_last`` or ``tap_last`` present
45–58	I'd probably include even the `python` directive step so that it's more obvious. What about: Run a check returning multiple results and make ``runtask`` fail if any of the results is failed:: - name: run my check and return TAP python: file: my_check.py callable: run export: tap - name: set runtask exit code according to the worst result in TAP exitcode: tap_worst: ${tap} Run a check that returns multiple results and one "overall" result (at the end) which is computed according check's internal logic. Then make ``runtask`` fail if the overall result failed:: - name: run my check and return TAP python: file: my_check.py callable: run export: tap - name: set runtask exit code according to the last (overall) result in TAP exitcode: tap_last: ${tap}
60–61	Please move this into the description instead of examples, thanks.
84	I'm confused. Shouldn't this be `==` after all?
98	The idea of the proposed `assert` was that you try to catch a error that should never occur (defensive programming). So with your latest change, it would look like this: if 'tap_worst' in input_data: # do something elif 'tap_last' in input_data: # do something else: assert False, "This should never occur" This protects you against future changes (renaming one of the arguments and forgetting adjusting the code here).

libtaskotron/runner.py
137–139	Can you please write a short unit test for this as well? That it was saved correctly the first time, and that it can be overridden with worse but not better result.
testing/test_exitcode_directive.py
13	Please also test an empty TAP (no results), and imparseable TAP (that should probably also be documented to throw an error). Otherwise it looks good.

libtaskotron/directives/exitcode_directive.py
92	Please also add this to the main directive documentation.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1185	6b24b3d		Jul 16 2015, 8:33 AM	★	★
Diff 2	1186	6b24b3d	- docs	Jul 16 2015, 8:50 AM	★	★
Diff 3	1188	6b24b3d	- code polishing	Jul 16 2015, 1:13 PM	★	★
Diff 4	1190	6b24b3d	- exitcode unit tests	Jul 16 2015, 1:47 PM	★	★
Diff 5	1193	6b24b3d	- code polishing, more tests	Jul 16 2015, 3:04 PM	★	★
Diff 6	1195	6b24b3d	Commit rLTRN6d0d0cfa52a4e2d7d79fe7285f0daa1e37217b2e	Jul 17 2015, 7:33 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
81319833a104	9a40b31ba9d3	9ffbe0ba91af	Lukas Brabec	code polishing, more tests	Jul 16 2015, 3:04 PM
9ffbe0ba91af	e45b6bebbc56	10eaa3c62d21	Lukas Brabec	exitcode tests	Jul 16 2015, 1:44 PM
10eaa3c62d21	89f5dd848b94	5339b1b009ba	Lukas Brabec	code polishing	Jul 16 2015, 1:11 PM
5339b1b009ba	fa44923505b8	e6c7d0eb1363	Lukas Brabec	docs	Jul 16 2015, 8:50 AM
e6c7d0eb1363	bf861bcfc6b3	6b24b3d8fffc	Lukas Brabec	exitcode directive (Show More…)	Jul 16 2015, 7:10 AM

Diff 1195

libtaskotron.spec

1	# sitelib for noarch packages, sitearch for others (remove the unneeded one)	1	# sitelib for noarch packages, sitearch for others (remove the unneeded one)
2	%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")}	2	%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")}
3	%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}	3	%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
4		4
5	Name: libtaskotron	5	Name: libtaskotron
6	Version: 0.3.17	6	Version: 0.3.18
7	Release: 1%{?dist}	7	Release: 1%{?dist}
8	Summary: Taskotron Support Library	8	Summary: Taskotron Support Library
9		9
10	License: GPLv3	10	License: GPLv3
11	URL: https://bitbucket.org/fedoraqa/libtaskotron	11	URL: https://bitbucket.org/fedoraqa/libtaskotron
12	Source0: http://qadevel.fedoraproject.org/releases/%{name}/%{name}-%{version}.tar.gz	12	Source0: http://qadevel.fedoraproject.org/releases/%{name}/%{name}-%{version}.tar.gz
13		13
14	BuildArch: noarch	14	BuildArch: noarch
▲ Show 20 Lines • Show All 206 Lines • Show Last 20 Lines

View Options

libtaskotron/directives/exitcode_directive.py

This file was added.

1		# -- coding: utf-8 --
2		# Copyright 2009-2014, Red Hat, Inc.
3		# License: GPL-2.0+ <http://spdx.org/licenses/GPL-2.0+>
4		# See the LICENSE file for more details on Licensing
5
6		from libtaskotron.directives import BaseDirective
7		from libtaskotron.exceptions import TaskotronDirectiveError
8		from libtaskotron.logger import log
9		from libtaskotron import check
10
11
12		DOCUMENTATION = """
	kparalUnsubmitted Done The docs fail to build.
13		module: exitcode_directive
14		short_description: set runtask exit code based on last or worst TAP outcome
	kparalUnsubmitted Not Done maybe "set runtask exit code" instead of "generate exitcode"
15		description: \|
16		This directives takes TAP specified by key ``tap_last`` or ``tap_worst`` (keys are mutually
17		exclusive), and generates returncode based on last or worst TAP outcome. If TAP is empty,
18		exitcode is set to SUCCESS.
19
20		If task formula contains multiple usages of exitcode directive, worst exitcode is returned by
21		runtask.
22
	kparalUnsubmitted Not Done Please also mention what happens when the TAP is empty (no results).
23		Input for directive is supposed to be in a `TAP13 format`_. The easiest way to create it is to
24		use :class:`.CheckDetail` objects to construct your result (or results), and then generate
25		the TAP output with :func:`~.check.export_TAP`. Read more in :ref:`writing-tasks-for-taskotron`.
26
27		.. _TAP13 format: http://testanything.org/tap-version-13-specification.html
28		parameters:
29		tap_last:
30		required: true
	kparalUnsubmitted Not Done Let's document the return type as well, and the values (since they are hard-coded).
31		description: TAP output, last outcome is used. ``tap_worst`` cannot be specified together with
32		this one.
33		type: str
34		tap_worst:
35		required: true
36		description: TAP output, worst outcome is used. ``tap_last`` cannot be specified together with
	kparalUnsubmitted Not Done This seems to be part of the `returns` section, while it should be probably in `description`.
37		this one.
38		type: str
39		returns: \|
	kparalUnsubmitted Not Done "exactly one of keys ..." would be probably more precise
	kparalUnsubmitted Done I'm mildly confused by `input data`, it looks like a variable `input_data`, but without the underscore - but the user doesn't know anything about that variable. It's probably better to say * :class:`.TaskotronDirectiveError`: when there's not exactly one of parameters ``tap_last`` or ``tap_last`` present
40		:int: Returncode based on TAP last or worst outcome. Success is ``0``, failure is ``100``.
	kparalUnsubmitted Done Current libtaskotron version is `0.3.17`. You should make sure it is not the same as the last publicly released version, and if it is, bump it to `0.3.18` (I guess) and adjust the spec file as well.
41		raises: \|
42		* :class:`.TaskotronDirectiveError`: when there's not exactly one of parameters ``tap_last`` or
43		``tap_last`` present
44		* :class:`.TaskotronValueError`: when TAP input cannot be parsed
45		version_added: 0.3.18
46		"""
47
48		EXAMPLES = """
49		Run a check returning multiple results and make ``runtask`` fail if any of the results is failed::
50
51		- name: run my check and return TAP
52		python:
53		file: my_check.py
54		callable: run
55		export: tap
56
57		- name: set runtask exit code according to the worst result in TAP
58		exitcode:
	kparalUnsubmitted Done I'd probably include even the `python` directive step so that it's more obvious. What about: Run a check returning multiple results and make ``runtask`` fail if any of the results is failed:: - name: run my check and return TAP python: file: my_check.py callable: run export: tap - name: set runtask exit code according to the worst result in TAP exitcode: tap_worst: ${tap} Run a check that returns multiple results and one "overall" result (at the end) which is computed according check's internal logic. Then make ``runtask`` fail if the overall result failed:: - name: run my check and return TAP python: file: my_check.py callable: run export: tap - name: set runtask exit code according to the last (overall) result in TAP exitcode: tap_last: ${tap}
59		tap_worst: ${tap}
	kparalUnsubmitted Not Done Ditto.
60
61		Run a check that returns multiple results and one "overall" result (at the end) which is computed
	kparalUnsubmitted Not Done Please move this into the description instead of examples, thanks.
62		according check's internal logic. Then make ``runtask`` fail if the overall result failed::
63
	kparalUnsubmitted Not Done Would this be a bit more readable? if ['tap_worst' in input_data, 'tap_last' in input_data].count(True) != 1: Or, alternatively, why do you have `not` and `!=` together? Would this work? if ('tap_worst' in input_data) == ('tap_last' in input_data):
	jskladanUnsubmitted Not Done Or, alternatively, why do you have not and != together? Would this work? The truth is, that the code is flawed - it is supposed to behave like XOR, but is not. The XOR-like behaviour is actually this piece of code: if ('tap_worst' in input_data) != ('tap_last' in input_data): Which corresponds to the `...count()` example of yours, but IMHO is quite a bit more readable.
	lbrabecAuthorUnsubmitted Not Done Well, it should behave like NXOR, which is actually equivalence, wonder how i missed that, @kparal 's solution with `==` should be fine.
64		- name: run my check and return TAP
65		python:
	kparalUnsubmitted Not Done Ditto.
66		file: my_check.py
67		callable: run
68		export: tap
69
70		- name: set runtask exit code according to the last (overall) result in TAP
71		exitcode:
72		tap_last: ${tap}
73		"""
74
75		# exitcode for PASSED and INFO outcome
76		SUCCESS = 0
	kparalUnsubmitted Not Done assert 'tap_last' in input_data above this line would add some extra error checking. Just an idea.
77
78		# exitcode for other outcomes
	kparalUnsubmitted Not Done This is probably not intended here. But a `log.debug` statement before every `return` statement in this directive would be nice.
79		FAILURE = 100
80
81		directive_class = 'ExitcodeDirective'
82
83
84		class ExitcodeDirective(BaseDirective):
	kparalUnsubmitted Not Done I'm confused. Shouldn't this be `==` after all?
85		def process(self, input_data, env_data):
86		"""Process this directive.
87		:param dict input_data: dictionary of all kwargs from yaml declaration
88		:param dict env_data: information on the environment in which we're running
89		:returns: returncode based on TAP last or worst outcome
90		:raise TaskotronDirectiveError: ``input data`` doesn't contain exactly one of keys
91		``tap_last`` or ``tap_last``
92		:raise TaskotronValueError: when TAP input cannot be parsed
	kparalUnsubmitted Not Done Please also add this to the main directive documentation.
93		"""
94
95		# keys 'tap_worst' and 'tap_last' must be mutually exclusive
96		if ('tap_worst' in input_data) == ('tap_last' in input_data):
97		raise TaskotronDirectiveError("The exitcode directive requires exactly one of keys "
98		"'tap_worst' or 'tap_last'.")
	kparalUnsubmitted Done The idea of the proposed `assert` was that you try to catch a error that should never occur (defensive programming). So with your latest change, it would look like this: if 'tap_worst' in input_data: # do something elif 'tap_last' in input_data: # do something else: assert False, "This should never occur" This protects you against future changes (renaming one of the arguments and forgetting adjusting the code here).
99
100		if 'tap_worst' in input_data:
101		details = check.import_TAP(input_data['tap_worst'])
102		code = SUCCESS
103		for detail in details:
104		if detail.outcome not in ['PASSED', 'INFO']:
105		code = FAILURE
106
107		log.debug("Returning exitcode %d" % code)
108		return code
109
110		elif 'tap_last' in input_data:
111		details = check.import_TAP(input_data['tap_last'])
112		if details and details[-1].outcome not in ['PASSED', 'INFO']:
113
114		log.debug("Returning exitcode %d" % FAILURE)
115		return FAILURE
116		else:
117		log.debug("Returning exitcode %d" % SUCCESS)
118		return SUCCESS
119
120		else:
121		assert False, "This should never occur"

View Options

libtaskotron/runner.py

1	# -- coding: utf-8 --	1		# -- coding: utf-8 --
2	# Copyright 2009-2014, Red Hat, Inc.	2		# Copyright 2009-2014, Red Hat, Inc.
3	# License: GPL-2.0+ <http://spdx.org/licenses/GPL-2.0+>	3		# License: GPL-2.0+ <http://spdx.org/licenses/GPL-2.0+>
4	# See the LICENSE file for more details on Licensing	4		# See the LICENSE file for more details on Licensing
5		5
6	from __future__ import absolute_import	6		from __future__ import absolute_import
7	import logging	7		import logging
8	import tempfile	8		import tempfile
9	import os.path	9		import os.path
10	import argparse	10		import argparse
11	import imp	11		import imp
12	import copy	12		import copy
13	import collections	13		import collections
14	import datetime	14		import datetime
		15		import sys
15		16
16	import libtaskotron	17		import libtaskotron
17	from libtaskotron import taskformula	18		from libtaskotron import taskformula
18	from libtaskotron import logger	19		from libtaskotron import logger
19	from libtaskotron import python_utils	20		from libtaskotron import python_utils
20	from libtaskotron import file_utils	21		from libtaskotron import file_utils
21	from libtaskotron import config	22		from libtaskotron import config
22	from libtaskotron.logger import log	23		from libtaskotron.logger import log
23	from libtaskotron.exceptions import TaskotronYamlError, TaskotronError	24		from libtaskotron.exceptions import TaskotronYamlError, TaskotronError
		25		from libtaskotron.directives import exitcode_directive
24		26
25		27
26	# The list of accepted item types on the command line (--type option)	28		# The list of accepted item types on the command line (--type option)
27	_ITEM_TYPES = ["bodhi_id", "koji_build", "koji_tag", "compose"]	29		_ITEM_TYPES = ["bodhi_id", "koji_build", "koji_tag", "compose"]
28		30
29		31
30	class Runner(object):	32		class Runner(object):
31	def __init__(self, taskdata, argdata, workdir=None):	33		def __init__(self, taskdata, argdata, workdir=None):
32	self.taskdata = taskdata	34		self.taskdata = taskdata
33	self.envdata = argdata	35		self.envdata = argdata
34	self.working_data = {}	36		self.working_data = {}
35	self.directives = {}	37		self.directives = {}
36	self.workdir = workdir	38		self.workdir = workdir
		39		#: int exitcode set by exitcode directive, is None if exitcode directive was not used
			kparalUnsubmitted Not Done Can you please document (using a standard Sphinx syntax, so that it's visible in the generated docs) what this is for (that's rather obvious) and what values this can have? Number, string, boolean,... and what `None` means?
		40		self.exitcode = None
37		41
38	def run(self):	42		def run(self):
39	self._validate_input()	43		self._validate_input()
40		44
41	if not self.workdir: # create temporary workdir if needed	45		if not self.workdir: # create temporary workdir if needed
42	self.workdir = tempfile.mkdtemp(prefix="task-",	46		self.workdir = tempfile.mkdtemp(prefix="task-",
43	dir=config.get_config().tmpdir)	47		dir=config.get_config().tmpdir)
44	log.debug("Current workdir: %s", self.workdir)	48		log.debug("Current workdir: %s", self.workdir)
▲ Show 20 Lines • Show All 77 Lines • ▼ Show 20 Line(s)		108	def do_single_action(self, action):
122	output = directive_callable.process(rendered_action[directive_name],	126		output = directive_callable.process(rendered_action[directive_name],
123	self.envdata)	127		self.envdata)
124		128
125	if 'export' in action:	129		if 'export' in action:
126	self.working_data[action['export']] = output	130		self.working_data[action['export']] = output
127	log.debug("Variable ${%s} was exported with value:\n%s" %	131		log.debug("Variable ${%s} was exported with value:\n%s" %
128	(action['export'], output))	132		(action['export'], output))
129		133
		134		# unable to use isinstance() due to dynamically loaded directives
			jskladanUnsubmitted Not Done Please document why this is necessary instead of `isinstance()`
		135		if directive_classname == exitcode_directive.directive_class:
			kparalUnsubmitted Not Done It would be great to add a comment here documenting the intended intention (i.e. failure should not be overridden with later success).
		136		# set exitcode if was None or overwrite previous SUCCESS with FAILURE (not vice versa)
			kparalUnsubmitted Not Done Let's add a `log.info` here, it's an important change.
		137		if not self.exitcode or output != exitcode_directive.SUCCESS:
		138		log.info("Setting exitcode to %s" % output)
		139		self.exitcode = output
			kparalUnsubmitted Done Can you please write a short unit test for this as well? That it was saved correctly the first time, and that it can be overridden with worse but not better result.
		140
130	def do_actions(self):	141		def do_actions(self):
131	'''Sequentially run all actions for a task. An 'action' is a single step	142		'''Sequentially run all actions for a task. An 'action' is a single step
132	under the ``actions:`` key. An example action looks like::	143		under the ``actions:`` key. An example action looks like::
133		144
134	- name: download rpms from koji	145		- name: download rpms from koji
135	koji:	146		koji:
136	action: download	147		action: download
137	koji_build: $koji_build	148		koji_build: $koji_build
▲ Show 20 Lines • Show All 120 Lines • ▼ Show 20 Line(s)		244	def main():
258		269
259	# run the task	270		# run the task
260	task_runner = Runner(task_data, arg_data)	271		task_runner = Runner(task_data, arg_data)
261	task_runner.run()	272		task_runner.run()
262		273
263	# finalization	274		# finalization
264	log.info('Execution finished at: %s',	275		log.info('Execution finished at: %s',
265	datetime.datetime.utcnow().strftime('%Y-%m-%d %H:%M:%S UTC'))	276		datetime.datetime.utcnow().strftime('%Y-%m-%d %H:%M:%S UTC'))
		277
		278		if task_runner.exitcode:
		279		log.info("Exiting with exit status %d (this behavior was requested by exitcode directive)"
			kparalUnsubmitted Not Done I'd add another `log.info` here, saying that we're exiting with exit status `$number` because something failed and this beahavior was requested.
		280		% task_runner.exitcode)
		281		sys.exit(task_runner.exitcode)

View Options

testing/test_exitcode_directive.py

This file was added.

1		# -- coding: utf-8 --
2		# Copyright 2009-2014, Red Hat, Inc.
3		# License: GPL-2.0+ <http://spdx.org/licenses/GPL-2.0+>
4		# See the LICENSE file for more details on Licensing
5
6		from libtaskotron.directives import exitcode_directive
7		from libtaskotron.exceptions import TaskotronDirectiveError, TaskotronValueError
8		import pytest
9
10
11		@pytest.mark.usefixtures("setup")
12		class TestReturncode(object):
13
	kparalUnsubmitted Done Please also test an empty TAP (no results), and imparseable TAP (that should probably also be documented to throw an error). Otherwise it looks good.
14		@pytest.fixture
15		def setup(self):
16		self.test_env_data = {}
17		self.test_input_data = {}
18		self.test_tap = """
19		TAP version 13
20		1..4
21		ok - $CHECKNAME for Hello World P
22		---
23		item: Hello World P
24		outcome: PASSED
25		...
26		ok - $CHECKNAME for Hello World I
27		---
28		item: Hello World I
29		outcome: INFO
30		...
31		not ok - $CHECKNAME for Hello World F # FAIL
32		---
33		item: Hello World F
34		outcome: FAILED
35		...
36		ok - $CHECKNAME for Hello World P
37		---
38		item: Hello World P
39		outcome: PASSED
40		...
41		"""
42
43		def test_tap_last(self):
44		self.test_input_data['tap_last'] = self.test_tap
45		exitcode = exitcode_directive.ExitcodeDirective().process(self.test_input_data,
46		self.test_env_data)
47		assert exitcode == exitcode_directive.SUCCESS
48
49		def test_tap_worst(self):
50		self.test_input_data['tap_worst'] = self.test_tap
51		exitcode = exitcode_directive.ExitcodeDirective().process(self.test_input_data,
52		self.test_env_data)
53		assert exitcode == exitcode_directive.FAILURE
54
55		def test_bad_input(self):
56		with pytest.raises(TaskotronDirectiveError):
57		exitcode_directive.ExitcodeDirective().process(self.test_input_data,
58		self.test_env_data)
59
60		def test_bad_tap(self):
61		self.test_tap = "noworky"
62		self.test_input_data['tap_worst'] = self.test_tap
63		with pytest.raises(TaskotronValueError):
64		exitcode_directive.ExitcodeDirective().process(self.test_input_data,
65		self.test_env_data)
66
67		def test_empty_tap_worst(self):
68		self.test_tap = """
69		TAP version 13
70		1..0
71		"""
72		self.test_input_data['tap_worst'] = self.test_tap
73		exitcode = exitcode_directive.ExitcodeDirective().process(self.test_input_data,
74		self.test_env_data)
75		assert exitcode == exitcode_directive.SUCCESS
76
77		def test_empty_tap_last(self):
78		self.test_tap = """
79		TAP version 13
80		1..0
81		"""
82		self.test_input_data['tap_last'] = self.test_tap
83		exitcode = exitcode_directive.ExitcodeDirective().process(self.test_input_data,
84		self.test_env_data)
85		assert exitcode == exitcode_directive.SUCCESS

View Options

testing/test_runner.py

1	# -- coding: utf-8 --	1		# -- coding: utf-8 --
2	# Copyright 2009-2014, Red Hat, Inc.	2		# Copyright 2009-2014, Red Hat, Inc.
3	# License: GPL-2.0+ <http://spdx.org/licenses/GPL-2.0+>	3		# License: GPL-2.0+ <http://spdx.org/licenses/GPL-2.0+>
4	# See the LICENSE file for more details on Licensing	4		# See the LICENSE file for more details on Licensing
5		5
6	import pytest	6		import pytest
7	import os	7		import os
8	import sys	8		import sys
9	import copy	9		import copy
10	from dingus import Dingus	10		from dingus import Dingus
11		11
12	from libtaskotron import runner	12		from libtaskotron import runner
		13		from libtaskotron.directives import exitcode_directive
13	from libtaskotron import exceptions as exc	14		from libtaskotron import exceptions as exc
14		15
15		16
16	class TestRunnerInputVerify():	17		class TestRunnerInputVerify():
17	def test_yamlrunner_valid_input(self):	18		def test_yamlrunner_valid_input(self):
18	ref_cmd = '-i foo-1.2-3.fc99 -t koji_build -a x86_64 footask.yml'	19		ref_cmd = '-i foo-1.2-3.fc99 -t koji_build -a x86_64 footask.yml'
19	ref_argdata = {'input': {'args': ['koji_build', 'arch']}}	20		ref_argdata = {'input': {'args': ['koji_build', 'arch']}}
20		21
▲ Show 20 Lines • Show All 129 Lines • ▼ Show 20 Line(s)		150	with pytest.raises(exc.TaskotronYamlError):
150	test_runner._load_directive(self.ref_directivename, self.ref_dir)	151		test_runner._load_directive(self.ref_directivename, self.ref_dir)
151		152
152	class TestRunnerSingleAction():	153		class TestRunnerSingleAction():
153		154
154	def setup_method(self, method):	155		def setup_method(self, method):
155	self.ref_taskdata = {}	156		self.ref_taskdata = {}
156	self.ref_inputdata = {}	157		self.ref_inputdata = {}
157		158
		159		self.ref_tap_passed = """
		160		TAP version 13
		161		1..1
		162		ok - foo for Hello World P
		163		---
		164		item: Hello World P
		165		outcome: PASSED
		166		...
		167		"""
		168		self.ref_tap_failed = """
		169		TAP version 13
		170		1..1
		171		not ok - foo for Hello World P # FAIL
		172		---
		173		item: Hello World P
		174		outcome: FAILED
		175		...
		176
		177		"""
		178
		179
158	def test_runner_extract_directive_name(self):	180		def test_runner_extract_directive_name(self):
159	ref_directivename = 'dummy'	181		ref_directivename = 'dummy'
160	ref_action = {'name': 'test action',	182		ref_action = {'name': 'test action',
161	ref_directivename: {'result': 'pass',	183		ref_directivename: {'result': 'pass',
162	'msg': 'dummy message'}}	184		'msg': 'dummy message'}}
163		185
164	test_runner = runner.Runner(self.ref_taskdata, self.ref_inputdata)	186		test_runner = runner.Runner(self.ref_taskdata, self.ref_inputdata)
165		187
▲ Show 20 Lines • Show All 45 Lines • ▼ Show 20 Line(s)		225	def test_runner_do_single_dummy_action_pass_export_rendered_msg(self):
211		233
212	test_runner = runner.Runner(self.ref_taskdata, self.ref_inputdata)	234		test_runner = runner.Runner(self.ref_taskdata, self.ref_inputdata)
213	test_runner.working_data[ref_messagename] = ref_message	235		test_runner.working_data[ref_messagename] = ref_message
214		236
215	test_runner.do_single_action(ref_action)	237		test_runner.do_single_action(ref_action)
216		238
217	assert test_runner.working_data[ref_exportname] == ref_message	239		assert test_runner.working_data[ref_exportname] == ref_message
218		240
		241		def test_runner_do_single_dummy_action_exitcode_None(self):
		242		ref_action = {'name': 'Return exitcode', 'exitcode': {'tap_last': self.ref_tap_passed}}
		243
		244		test_runner = runner.Runner(self.ref_taskdata, self.ref_inputdata)
		245
		246		test_runner.do_single_action(ref_action)
		247
		248		assert test_runner.exitcode == exitcode_directive.SUCCESS
		249
		250		def test_runner_do_single_dummy_action_exitcode_success(self):
		251		ref_action = {'name': 'Return exitcode', 'exitcode': {'tap_last': self.ref_tap_passed}}
		252
		253		test_runner = runner.Runner(self.ref_taskdata, self.ref_inputdata)
		254
		255		test_runner.do_single_action(ref_action)
		256
		257		assert test_runner.exitcode == exitcode_directive.SUCCESS
		258
		259		def test_runner_do_single_dummy_action_exitcode_failure(self):
		260		ref_action = {'name': 'Return exitcode', 'exitcode': {'tap_last': self.ref_tap_failed}}
		261
		262		test_runner = runner.Runner(self.ref_taskdata, self.ref_inputdata)
		263
		264		test_runner.do_single_action(ref_action)
		265
		266		assert test_runner.exitcode == exitcode_directive.FAILURE
		267
		268		def test_runner_do_single_dummy_action_exitcode_failure_overwrite_success(self):
		269		ref_action = {'name': 'Return exitcode', 'exitcode': {'tap_last': self.ref_tap_failed}}
		270
		271		test_runner = runner.Runner(self.ref_taskdata, self.ref_inputdata)
		272		test_runner.exitcode = exitcode_directive.SUCCESS
		273		test_runner.do_single_action(ref_action)
		274
		275		assert test_runner.exitcode == exitcode_directive.FAILURE
		276
		277		def test_runner_do_single_dummy_action_exitcode_success_not_overwrite_failure(self):
		278		ref_action = {'name': 'Return exitcode', 'exitcode': {'tap_last': self.ref_tap_passed}}
		279
		280		test_runner = runner.Runner(self.ref_taskdata, self.ref_inputdata)
		281		test_runner.exitcode = exitcode_directive.FAILURE
		282		test_runner.do_single_action(ref_action)
		283
		284		assert test_runner.exitcode == exitcode_directive.FAILURE
		285
219		286
220	class TestRunnerDoActions():	287		class TestRunnerDoActions():
221		288
222	def setup_method(self, method):	289		def setup_method(self, method):
223	self.ref_taskdata = {}	290		self.ref_taskdata = {}
224	self.ref_inputdata = {}	291		self.ref_inputdata = {}
225		292
226	def test_runner_do_single_dummy_pass(self):	293		def test_runner_do_single_dummy_pass(self):
▲ Show 20 Lines • Show All 228 Lines • Show Last 20 Lines

		Path
M		libtaskotron.spec (2 lines)
A	M	libtaskotron/directives/exitcode_directive.py (121 lines)
M		libtaskotron/runner.py (16 lines)
A	M	testing/test_exitcode_directive.py (85 lines)
M		testing/test_runner.py (67 lines)

exitcode directive
ClosedPublic
Actions

Details

Diff Detail

Revision Contents

Diff 1195

libtaskotron.spec

libtaskotron/directives/exitcode_directive.py

libtaskotron/runner.py

testing/test_exitcode_directive.py

testing/test_runner.py

exitcode directiveClosedPublicActions

Details

Diff Detail

Revision Contents

Diff 1195

libtaskotron.spec

libtaskotron/directives/exitcode_directive.py

libtaskotron/runner.py

testing/test_exitcode_directive.py

testing/test_runner.py

exitcode directive
ClosedPublic
Actions