Differential D442

New argument to return non-zero code when failed
AbandonedPublic
Actions

Authored by lbrabec on Jul 14 2015, 1:10 PM.

Details

Reviewers
kparal
tflink
mkrizek
jskladan
Maniphest Tasks
T450: implement --make-fatal and return non-zero exit code if task fails
Summary

New argument --fatal added. Runner now collects last export. If --fatal was passed, last outcome is extracted from last export and return code set accordingly to it. WIP, open for discussion.

Test Plan

runtask with passed and failed rpmlint, both with and without --fatal

Diff Detail

Repository
rLTRN libtaskotron
Branch
feature/T450
Lint
Lint OK
Unit
No Unit Test Coverage
lbrabec retitled this revision from to New argument to return non-zero code when failed.Jul 14 2015, 1:10 PM
lbrabec updated this object.
lbrabec edited the test plan for this revision. (Show Details)
lbrabec added reviewers: kparal, mkrizek, tflink, jskladan.
jskladan requested changes to this revision.Jul 15 2015, 8:15 AM
jskladan added inline comments.
libtaskotron/runner.py
277

I don't really like, that when no export is used we end with 0, but when the last export is not TAP, this will just die on the TaskotronValueError('Failed to parse TAP contents: %s' % e) exeption. I'd rather log warning/error about no/wrong TAP being present in the last_export, and ended with sys.exit(101) or something in the likes of that.

This revision now requires changes to proceed.Jul 15 2015, 8:15 AM
kparal added a comment.Jul 15 2015, 11:49 AM

I think we forgot that we can't easily tell what the task result is and what isn't, and relying on export is not a good idea. I proposed different ways of implementation in T450. Comments welcome.

lbrabec abandoned this revision.Jul 15 2015, 2:00 PM

Seems that thing have taken different direction, abandoning this diff.

Revision Contents

PathPackages
Mlibtaskotron/runner.py (14 lines)

Diff 1165

View Options

libtaskotron/runner.py

1# -*- coding: utf-8 -*- 1​# -*- coding: utf-8 -*-
2# Copyright 2009-2014, Red Hat, Inc. 2​# Copyright 2009-2014, Red Hat, Inc.
3# License: GPL-2.0+ <http://spdx.org/licenses/GPL-2.0+> 3​# License: GPL-2.0+ <http://spdx.org/licenses/GPL-2.0+>
4# See the LICENSE file for more details on Licensing 4​# See the LICENSE file for more details on Licensing
5 5​
6from __future__ import absolute_import 6​from __future__ import absolute_import
7import logging 7​import logging
8import tempfile 8​import tempfile
9import os.path 9​import os.path
10import argparse 10​import argparse
11import imp 11​import imp
12import copy 12​import copy
13import collections 13​import collections
14import datetime 14​import datetime
15​import sys
15 16​
16import libtaskotron 17​import libtaskotron
17from libtaskotron import taskformula 18​from libtaskotron import taskformula
18from libtaskotron import logger 19​from libtaskotron import logger
19from libtaskotron import python_utils 20​from libtaskotron import python_utils
20from libtaskotron import file_utils 21​from libtaskotron import file_utils
21from libtaskotron import config 22​from libtaskotron import config
23​from libtaskotron import check
22from libtaskotron.logger import log 24​from libtaskotron.logger import log
23from libtaskotron.exceptions import TaskotronYamlError, TaskotronError 25​from libtaskotron.exceptions import TaskotronYamlError, TaskotronError
24 26​
25 27​
26# The list of accepted item types on the command line (--type option) 28​# The list of accepted item types on the command line (--type option)
27_ITEM_TYPES = ["bodhi_id", "koji_build", "koji_tag", "compose"] 29​_ITEM_TYPES = ["bodhi_id", "koji_build", "koji_tag", "compose"]
28 30​
29 31​
30class Runner(object): 32​class Runner(object):
31 def __init__(self, taskdata, argdata, workdir=None): 33​ def __init__(self, taskdata, argdata, workdir=None):
32 self.taskdata = taskdata 34​ self.taskdata = taskdata
33 self.envdata = argdata 35​ self.envdata = argdata
34 self.working_data = {} 36​ self.working_data = {}
35 self.directives = {} 37​ self.directives = {}
36 self.workdir = workdir 38​ self.workdir = workdir
39​ self.last_export = None
37 40​
38 def run(self): 41​ def run(self):
39 self._validate_input() 42​ self._validate_input()
40 43​
41 if not self.workdir: # create temporary workdir if needed 44​ if not self.workdir: # create temporary workdir if needed
42 self.workdir = tempfile.mkdtemp(prefix="task-", 45​ self.workdir = tempfile.mkdtemp(prefix="task-",
43 dir=config.get_config().tmpdir) 46​ dir=config.get_config().tmpdir)
44 log.debug("Current workdir: %s", self.workdir) 47​ log.debug("Current workdir: %s", self.workdir)
▲ Show 20 Lines • Show All 74 Lines • ▼ Show 20 Line(s)107 def do_single_action(self, action):
119 122​
120 directive_callable = getattr(directive_object, directive_classname)() 123​ directive_callable = getattr(directive_object, directive_classname)()
121 124​
122 output = directive_callable.process(rendered_action[directive_name], 125​ output = directive_callable.process(rendered_action[directive_name],
123 self.envdata) 126​ self.envdata)
124 127​
125 if 'export' in action: 128​ if 'export' in action:
126 self.working_data[action['export']] = output 129​ self.working_data[action['export']] = output
130​ self.last_export = output
127 log.debug("Variable ${%s} was exported with value:\n%s" % 131​ log.debug("Variable ${%s} was exported with value:\n%s" %
128 (action['export'], output)) 132​ (action['export'], output))
129 133​
130 def do_actions(self): 134​ def do_actions(self):
131 '''Sequentially run all actions for a task. An 'action' is a single step 135​ '''Sequentially run all actions for a task. An 'action' is a single step
132 under the ``actions:`` key. An example action looks like:: 136​ under the ``actions:`` key. An example action looks like::
133 137​
134 - name: download rpms from koji 138​ - name: download rpms from koji
▲ Show 20 Lines • Show All 57 Lines • ▼ Show 20 Line(s)195 help="Unique job identifier for the execution"
192 "status tracking purposes. If unset, defaults to" 196​ "status tracking purposes. If unset, defaults to"
193 "current datetime in UTC") 197​ "current datetime in UTC")
194 parser.add_argument("--override", action="append", default=[], 198​ parser.add_argument("--override", action="append", default=[],
195 metavar='VAR=VALUE', 199​ metavar='VAR=VALUE',
196 help="override internal variable values used in runner " 200​ help="override internal variable values used in runner "
197 "and the task formula. Value itself is evaluated " 201​ "and the task formula. Value itself is evaluated "
198 "by eval(). This option can be used multiple times. " 202​ "by eval(). This option can be used multiple times. "
199 "Example: --override \"workdir='/some/dir/'\"") 203​ "Example: --override \"workdir='/some/dir/'\"")
204​ parser.add_argument("--fatal", action="store_true",
205​ help="make the taskotron return non-zero code when "
206​ "the outcome of last task was not 'PASSED' or 'INFO'.")
200 207​
201 return parser 208​ return parser
202 209​
203 210​
204def process_args(args): 211​def process_args(args):
205 """ Processes raw input args and converts them into specific data types that 212​ """ Processes raw input args and converts them into specific data types that
206 can be used by tasks. This includes e.g. creating new args based on 213​ can be used by tasks. This includes e.g. creating new args based on
207 (item, item_type) pairs, or adjusting selected architecture. 214​ (item, item_type) pairs, or adjusting selected architecture.
▲ Show 20 Lines • Show All 50 Lines • ▼ Show 20 Line(s)240def main():
258 265​
259 # run the task 266​ # run the task
260 task_runner = Runner(task_data, arg_data) 267​ task_runner = Runner(task_data, arg_data)
261 task_runner.run() 268​ task_runner.run()
262 269​
263 # finalization 270​ # finalization
264 log.info('Execution finished at: %s', 271​ log.info('Execution finished at: %s',
265 datetime.datetime.utcnow().strftime('%Y-%m-%d %H:%M:%S UTC')) 272​ datetime.datetime.utcnow().strftime('%Y-%m-%d %H:%M:%S UTC'))
273​
274​ # if --fatal was passed to runtask, exit with code according to last outcome
275​ if arg_data['fatal']:
276​ if task_runner.last_export:
277​ last_outcome = check.import_TAP(task_runner.last_export)[-1].outcome
jskladanUnsubmitted
Not Done

I don't really like, that when no export is used we end with 0, but when the last export is not TAP, this will just die on the TaskotronValueError('Failed to parse TAP contents: %s' % e) exeption. I'd rather log warning/error about no/wrong TAP being present in the last_export, and ended with sys.exit(101) or something in the likes of that.

278​ if last_outcome not in ['PASSED', 'INFO']:
279​ sys.exit(100)