move logging in as a root into parent class
ClosedPublic

Authored by garretraziel on Jul 14 2015, 11:34 AM.

Details

Summary

Because "login as a root" and "boot and login" is used
a lot in tests, I have moved them into parent class.

Test Plan

Run fedup test.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
garretraziel retitled this revision from to move logging in as a root into parent class.Jul 14 2015, 11:34 AM
garretraziel updated this object.
garretraziel edited the test plan for this revision. (Show Details)
garretraziel added a reviewer: jskladan.
jskladan accepted this revision.EditedJul 14 2015, 11:48 AM

apart from the minor nitpick, LGTM

lib/fedoralog.pm
8

Would it be possible to provide some default value? Or at least check whether the $tty is set, and only call send_key "ctrl-alt-f$tty"; then?

This revision is now accepted and ready to land.Jul 14 2015, 11:48 AM
Closed by commit rOPENQATESTS4abc1aecf2fa: move logging in as a root into parent class (authored by Garret Raziel <boloomka@gmail.com>). · Explain WhyJul 15 2015, 5:22 AM
This revision was automatically updated to reflect the committed changes.