Differential D432

Correctly check Testcase related exception in resultsdb_directive
ClosedPublic
Actions

Authored by jskladan on Jul 13 2015, 12:38 PM.

Details

Reviewers
kparal
tflink
mkrizek
Maniphest Tasks
T519: new test cases are not automatically created in resultsdb, crashes instead
Commits
rLTRN8581d1c52964: Correctly check Testcase related exception in resultsdb_directive
Summary

The error mentioned in T519 is fixed by this simple change. Although
the entire ensure_testcase_exists() method can (and IMHO should)
be removed once D431 lands.

Test Plan

None

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jskladan retitled this revision from to Correctly check Testcase related exception in resultsdb_directive.Jul 13 2015, 12:38 PM
jskladan updated this object.
jskladan edited the test plan for this revision. (Show Details)
jskladan added reviewers: kparal, tflink, mkrizek.
mkrizek accepted this revision.Jul 13 2015, 12:58 PM
This revision is now accepted and ready to land.Jul 13 2015, 12:58 PM
kparal accepted this revision.Jul 14 2015, 10:31 AM
Closed by commit rLTRN8581d1c52964: Correctly check Testcase related exception in resultsdb_directive (authored by Josef Skladanka <jskladan@redhat.com>). · Explain WhyJul 15 2015, 8:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 1168

View Options

libtaskotron/directives/resultsdb_directive.py

Show First 20 Lines • Show All 114 Lines • ▼ Show 20 Line(s)108 def ensure_testcase_exists(self, name):
115 if name in self._ensured_testcases: 115​ if name in self._ensured_testcases:
116 return 116​ return
117 117​
118 try: 118​ try:
119 self.resultsdb.get_testcase(name) 119​ self.resultsdb.get_testcase(name)
120 self._ensured_testcases.append(name) 120​ self._ensured_testcases.append(name)
121 return 121​ return
122 except resultsdb_api.ResultsDBapiException, e: 122​ except resultsdb_api.ResultsDBapiException, e:
123 if e.message != 'Testcase not found': 123​ if e.message.startswith('Testcase not found'):
124 raise e 124​ raise e
125 125​
126 # since the testcase doesn't exist, create it with a dummy value for url 126​ # since the testcase doesn't exist, create it with a dummy value for url
127 # it can be updated later when it's not blocking results reporting 127​ # it can be updated later when it's not blocking results reporting
128 dummyurl = 'http://faketestcasesRus.com/%s' % name 128​ dummyurl = 'http://faketestcasesRus.com/%s' % name
129 self.resultsdb.create_testcase(name, dummyurl) 129​ self.resultsdb.create_testcase(name, dummyurl)
130 self._ensured_testcases.append(name) 130​ self._ensured_testcases.append(name)
131 131​
▲ Show 20 Lines • Show All 157 Lines • Show Last 20 Lines