Differential D431

Allow Testcase autocreation for create_result
ClosedPublic
Actions

Authored by jskladan on Jul 13 2015, 12:32 PM.

Details

Reviewers
kparal
tflink
mkrizek
Maniphest Tasks
T519: new test cases are not automatically created in resultsdb, crashes instead
Commits
rRSDB6832b40f838d: Allow Testcase autocreation for create_result
Summary

In the "old" resultsdb, testcases were identified just by the URL,
with the transition to RESTfull interface, we switched to identification
by name, and compulsory URL attribute (which is meant to point to the
testcase's documentation). We don't actually really use the URL attribute
anyways, and needing to check for Testcase's existence prior to any
create_result() call is kind of pointless anyways - since "not found"
testcase is then created anyway, just on the client side.

This patch moves the "automagic" part to the server, while still allowing
the client to instruct the server to require the testcase to be created
beforehand by introducing the strict parameter (False by default) to the
create_result() routine

This does not fix the issue in T519 per se (patch will follow), per se,
but changes the way testcase-creation is handled in clients.

Test Plan

Tested locally via httpie

Diff Detail

Repository
rRSDB resultsdb
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jskladan retitled this revision from to Allow Testcase autocreation for create_result.Jul 13 2015, 12:32 PM
jskladan updated this object.
jskladan edited the test plan for this revision. (Show Details)
jskladan added reviewers: kparal, tflink, mkrizek.
mkrizek accepted this revision.Jul 13 2015, 12:56 PM
This revision is now accepted and ready to land.Jul 13 2015, 12:56 PM
kparal accepted this revision.Jul 14 2015, 10:30 AM
Closed by commit rRSDB6832b40f838d: Allow Testcase autocreation for create_result (authored by Josef Skladanka <jskladan@redhat.com>). · Explain WhyJul 15 2015, 8:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mresultsdb/controllers/api_v1.py (11 lines)

Diff 1167

View Options

resultsdb/controllers/api_v1.py

Show First 20 Lines • Show All 386 Lines • ▼ Show 20 Line(s)
387 387​
388RP['create_result'] = reqparse.RequestParser() 388​RP['create_result'] = reqparse.RequestParser()
389RP['create_result'].add_argument('job_id', type = int, required = True, location = 'json') 389​RP['create_result'].add_argument('job_id', type = int, required = True, location = 'json')
390RP['create_result'].add_argument('outcome', type = str, required = True, location = 'json') 390​RP['create_result'].add_argument('outcome', type = str, required = True, location = 'json')
391RP['create_result'].add_argument('testcase_name', type = str, required = True, location = 'json') 391​RP['create_result'].add_argument('testcase_name', type = str, required = True, location = 'json')
392RP['create_result'].add_argument('summary', type = str, location = 'json') 392​RP['create_result'].add_argument('summary', type = str, location = 'json')
393RP['create_result'].add_argument('result_data', type = dict, location = 'json') 393​RP['create_result'].add_argument('result_data', type = dict, location = 'json')
394RP['create_result'].add_argument('log_url', type = str, location = 'json') 394​RP['create_result'].add_argument('log_url', type = str, location = 'json')
395​RP['create_result'].add_argument('strict', type = bool, default=False, location = 'json')
395 396​
396 397​
397def __get_results_parse_args(): 398​def __get_results_parse_args():
398 retval = {"args": None, "error": None, "result_data": None} 399​ retval = {"args": None, "error": None, "result_data": None}
399 try: 400​ try:
400 args = RP['get_results'].parse_args() 401​ args = RP['get_results'].parse_args()
401 except JSONBadRequest as error: 402​ except JSONBadRequest as error:
402 retval["error"] = (jsonify({"message": "Malformed JSON data"}), error.code) 403​ retval["error"] = (jsonify({"message": "Malformed JSON data"}), error.code)
▲ Show 20 Lines • Show All 109 Lines • ▼ Show 20 Line(s)512 except orm_exc.NoResultFound:
512 return jsonify({'message': "Job not found" }), 404 513​ return jsonify({'message': "Job not found" }), 404
513 514​
514 if job.status != 'RUNNING': 515​ if job.status != 'RUNNING':
515 return jsonify({'message': "Job not running" }), 400 516​ return jsonify({'message': "Job not running" }), 400
516 517​
517 try: 518​ try:
518 testcase = Testcase.query.filter_by(name = args['testcase_name']).one() 519​ testcase = Testcase.query.filter_by(name = args['testcase_name']).one()
519 except orm_exc.NoResultFound: 520​ except orm_exc.NoResultFound:
520 return jsonify({'message': "Testcase not found" }), 404 521​ if args['strict']:
522​ return jsonify({'message': "Testcase not found" }), 404
523​ else:
524​ # TODO: add configurable default "empty" URL
525​ testcase = Testcase(args['testcase_name'], "")
526​ db.session.add(testcase)
527​ db.session.commit()
521 528​
522 outcome = args['outcome'].strip().upper() 529​ outcome = args['outcome'].strip().upper()
523 if outcome not in RESULT_OUTCOME: 530​ if outcome not in RESULT_OUTCOME:
524 return jsonify({'message': "outcome must be one of %r" % (RESULT_OUTCOME,) }), 400 531​ return jsonify({'message': "outcome must be one of %r" % (RESULT_OUTCOME,) }), 400
525 532​
526 533​
527 result = Result(job, testcase, outcome, args['log_url'], args['summary']) 534​ result = Result(job, testcase, outcome, args['log_url'], args['summary'])
528 535​
▲ Show 20 Lines • Show All 43 Lines • ▼ Show 20 Line(s)
572RP['get_testcases'].add_argument('page', default = 0, type = int, location = 'args') 579​RP['get_testcases'].add_argument('page', default = 0, type = int, location = 'args')
573RP['get_testcases'].add_argument('limit', default = QUERY_LIMIT, type = int, location = 'args') 580​RP['get_testcases'].add_argument('limit', default = QUERY_LIMIT, type = int, location = 'args')
574# These two are ignored. They're present so reqparse isn't confused by JSONP. 581​# These two are ignored. They're present so reqparse isn't confused by JSONP.
575RP['get_testcases'].add_argument('callback', type = str, location = 'args') 582​RP['get_testcases'].add_argument('callback', type = str, location = 'args')
576RP['get_testcases'].add_argument('_', type = str, location = 'args') 583​RP['get_testcases'].add_argument('_', type = str, location = 'args')
577 584​
578RP['create_testcase'] = reqparse.RequestParser() 585​RP['create_testcase'] = reqparse.RequestParser()
579RP['create_testcase'].add_argument('name', type = str, required = True, location = 'json') 586​RP['create_testcase'].add_argument('name', type = str, required = True, location = 'json')
580RP['create_testcase'].add_argument('url', type = str, required = True, location = 'json') 587​RP['create_testcase'].add_argument('url', type = str, required = False, location = 'json')
581 588​
582RP['update_testcase'] = reqparse.RequestParser() 589​RP['update_testcase'] = reqparse.RequestParser()
583RP['update_testcase'].add_argument('url', type = str, required = True, location = 'json') 590​RP['update_testcase'].add_argument('url', type = str, required = True, location = 'json')
584 591​
585 592​
586@api.route('/v1.0/testcases', methods = ['GET']) 593​@api.route('/v1.0/testcases', methods = ['GET'])
587def get_testcases(): #page = None, limit = QUERY_LIMIT): 594​def get_testcases(): #page = None, limit = QUERY_LIMIT):
588 595​
▲ Show 20 Lines • Show All 81 Lines • Show Last 20 Lines